unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 3746@emacsbugs.donarmstrong.com, Dan Nicolaescu <dann@ics.uci.edu>
Subject: bug#3746: M-r in comint mode should use isearch
Date: Mon, 23 Nov 2009 22:39:51 +0200	[thread overview]
Message-ID: <87zl6dxkiw.fsf@mail.jurta.org> (raw)
In-Reply-To: <jwv4ooqjk3l.fsf-monnier+emacsbugreports@gnu.org> (Stefan Monnier's message of "Thu, 19 Nov 2009 16:12:31 -0500")

>> Maybe we should change `comint-previous-input' and `comint-next-input'
>> to signal an error at the beginning/end of the history ring?
>
> That sounds fine to me, but pleast double check all uses of those
> functions to make sure it won't introduce other problems.

To avoid possible problems, I installed a non-intrusive implementation
that signals an error inside `comint-history-isearch-search' before
calling `comint-next-input' or `comint-previous-input'.

-- 
Juri Linkov
http://www.jurta.org/emacs/





  parent reply	other threads:[~2009-11-23 20:39 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87ocmknicw.fsf@mail.jurta.org>
2009-07-03 13:26 ` bug#3746: M-r in comint mode should use isearch Dan Nicolaescu
2009-07-03 23:36   ` Juri Linkov
2009-07-05 15:03     ` Dan Nicolaescu
2009-07-07  0:09       ` Juri Linkov
2009-07-07  1:21         ` Dan Nicolaescu
2009-07-08  0:45           ` Juri Linkov
2009-07-08  5:53             ` Drew Adams
2009-07-08 23:27               ` Juri Linkov
2009-07-08 23:42                 ` Lennart Borgman
2009-07-09 15:01                 ` Drew Adams
2009-07-09 22:16                   ` Juri Linkov
2009-07-09 22:32                     ` Drew Adams
2009-07-09 23:05                       ` Juri Linkov
2009-07-09 23:15                         ` Drew Adams
2009-07-08 23:49             ` Dan Nicolaescu
2009-07-09 22:19               ` Juri Linkov
2009-11-19 17:30                 ` Juri Linkov
2009-11-19 21:12                   ` Stefan Monnier
2009-11-20  9:28                     ` Juri Linkov
2009-11-23 20:39                     ` Juri Linkov [this message]
2009-11-30 16:30   ` bug#3746: marked as done (M-r in comint mode should use isearch) Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zl6dxkiw.fsf@mail.jurta.org \
    --to=juri@jurta.org \
    --cc=3746@emacsbugs.donarmstrong.com \
    --cc=dann@ics.uci.edu \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).