From: Jim Porter <jporterbugs@gmail.com>
To: James Thomas <jimjoe@gmx.net>
Cc: Eli Zaretskii <eliz@gnu.org>, 69232@debbugs.gnu.org
Subject: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop
Date: Thu, 29 Feb 2024 17:00:22 -0800 [thread overview]
Message-ID: <e590ad83-f10c-565c-5de2-e20e1b2c2430@gmail.com> (raw)
In-Reply-To: <878r32u9ut.fsf@gmx.net>
On 2/29/2024 3:30 PM, James Thomas via Bug reports for GNU Emacs, the
Swiss army knife of text editors wrote:
> The current patch is much better for me personally: 'l' and 'r' now do
> what they're supposed to do. But my ideal (short of any advanced 'tree'
> mechanism), as I originally stated, would've been to _insert_ (rather
> than _replace_) the new history at the position in the current history
> where it's created (but I see that there's no SOP for that in (info
> "(elisp) Minibuffer History"), and that there could be performance
> implications).
That shouldn't be too hard to do, at the very least with the appropriate
hooks (i.e. you might need to write some Elisp depending on how many
built-in options we want to support, but you won't have to use
'advice-add').
> Why not simply make 'eww-save-history' customizable?
In a general sense, that's the idea. I don't want to make
'eww-save-history' itself customizable though, since a) I want to let
people define a history pruning/fixup function and b) I don't want that
customizable function to have to be responsible for saving the current
page's history; 'eww-save-history' can do that for us. In practice
though, I think it'll all work out about the same, albeit easier to use.
> TBH I don't think anyone would have been (ab)using it effectively
> because each 'l' or 'r' made things more complicated; but the advantage
> that *all* of history was available with 'H'.
Yeah, I think the main thing we need here is some option to prevent loss
of existing history.
> (I'm using this patch and will let you know if I see anything amiss)
I already found one issue with reloading messing up history, but that
was an easy fix. Once I finish up the other parts of my v3 patch, I'll
post it here.
next prev parent reply other threads:[~2024-03-01 1:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-18 4:59 bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop Jim Porter
2024-02-19 12:12 ` Eli Zaretskii
2024-02-19 18:55 ` Jim Porter
2024-02-19 19:17 ` Eli Zaretskii
2024-02-22 13:22 ` Eli Zaretskii
2024-02-22 17:18 ` Jim Porter
2024-02-22 19:04 ` Eli Zaretskii
2024-02-22 20:10 ` Jim Porter
2024-02-22 20:13 ` Eli Zaretskii
2024-02-24 14:15 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-24 14:20 ` Eli Zaretskii
2024-02-24 22:29 ` Jim Porter
2024-02-25 0:50 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-24 22:34 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-25 5:57 ` Eli Zaretskii
2024-02-25 19:40 ` Jim Porter
2024-02-25 19:49 ` Eli Zaretskii
2024-02-25 22:41 ` Jim Porter
2024-02-28 23:39 ` Jim Porter
2024-02-29 7:03 ` Eli Zaretskii
2024-02-29 17:32 ` Jim Porter
2024-02-29 23:30 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-01 1:00 ` Jim Porter [this message]
2024-03-01 2:10 ` Jim Porter
2024-03-01 7:26 ` Eli Zaretskii
2024-03-01 20:13 ` Jim Porter
2024-03-02 7:38 ` Eli Zaretskii
2024-03-07 0:26 ` Jim Porter
2024-03-01 8:50 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-01 11:56 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e590ad83-f10c-565c-5de2-e20e1b2c2430@gmail.com \
--to=jporterbugs@gmail.com \
--cc=69232@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=jimjoe@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).