From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 69232@debbugs.gnu.org, jimjoe@gmx.net
Subject: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop
Date: Thu, 29 Feb 2024 09:03:33 +0200 [thread overview]
Message-ID: <86plwfsqey.fsf@gnu.org> (raw)
In-Reply-To: <10a0d839-24f6-b521-1504-a5ca568b3dcc@gmail.com> (message from Jim Porter on Wed, 28 Feb 2024 15:39:16 -0800)
> Date: Wed, 28 Feb 2024 15:39:16 -0800
> From: Jim Porter <jporterbugs@gmail.com>
> Cc: 69232@debbugs.gnu.org, jimjoe@gmx.net
>
> On 2/25/2024 2:41 PM, Jim Porter wrote:
> > On 2/25/2024 11:49 AM, Eli Zaretskii wrote:
> >>> If anything, I think this should be the default, with some other options
> >>> provided for people who don't want to lose any history. That way the
> >>> default behavior is what people know.
> >>
> >> I don't think I mind.
> >
> > Thanks. Even if there were multiple options, this is probably what I'd
> > choose, if only out of habit.
>
> Here's a patch that deletes "future history" in the case we'd previously
> discussed. I also added some regression tests for this. I think this all
> works correctly, but it's probably worth some manual testing over a few
> days just to be on the safe side.
Thanks, but I thought we were talking about some user option, since at
least some people said they don't like what other browsers do?
> +(defun eww-save-history (&optional clear-future)
> + "Save the current page's data to the history.
> +If the current page is a historial one loaded from
> +`eww-history' (e.g. by calling `eww-back-url'), this will update the
> +page's entry in `eww-history' and return nil. Otherwise, add a new
> +entry to `eww-history' and return t.
> +
> +If CLEAR-FUTURE is non-nil, clear any future history elements from
> +`eww-history'."
This should probably explain what it means by "future history
elements".
Thanks.
next prev parent reply other threads:[~2024-02-29 7:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-18 4:59 bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop Jim Porter
2024-02-19 12:12 ` Eli Zaretskii
2024-02-19 18:55 ` Jim Porter
2024-02-19 19:17 ` Eli Zaretskii
2024-02-22 13:22 ` Eli Zaretskii
2024-02-22 17:18 ` Jim Porter
2024-02-22 19:04 ` Eli Zaretskii
2024-02-22 20:10 ` Jim Porter
2024-02-22 20:13 ` Eli Zaretskii
2024-02-24 14:15 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-24 14:20 ` Eli Zaretskii
2024-02-24 22:29 ` Jim Porter
2024-02-25 0:50 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-24 22:34 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-25 5:57 ` Eli Zaretskii
2024-02-25 19:40 ` Jim Porter
2024-02-25 19:49 ` Eli Zaretskii
2024-02-25 22:41 ` Jim Porter
2024-02-28 23:39 ` Jim Porter
2024-02-29 7:03 ` Eli Zaretskii [this message]
2024-02-29 17:32 ` Jim Porter
2024-02-29 23:30 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-01 1:00 ` Jim Porter
2024-03-01 2:10 ` Jim Porter
2024-03-01 7:26 ` Eli Zaretskii
2024-03-01 20:13 ` Jim Porter
2024-03-02 7:38 ` Eli Zaretskii
2024-03-07 0:26 ` Jim Porter
2024-03-01 8:50 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-01 11:56 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86plwfsqey.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=69232@debbugs.gnu.org \
--cc=jimjoe@gmx.net \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).