From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 69232@debbugs.gnu.org, jimjoe@gmx.net
Subject: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop
Date: Sat, 02 Mar 2024 09:38:03 +0200 [thread overview]
Message-ID: <86plwdozhg.fsf@gnu.org> (raw)
In-Reply-To: <c1379e38-e471-f3b1-83ef-2f7d46980887@gmail.com> (message from Jim Porter on Fri, 1 Mar 2024 12:13:08 -0800)
> Date: Fri, 1 Mar 2024 12:13:08 -0800
> Cc: 69232@debbugs.gnu.org, jimjoe@gmx.net
> From: Jim Porter <jporterbugs@gmail.com>
>
> > Therefore, I suggest a history-specific defcustom, whose possible
> > values could be 'clear', 'clone', and 'add', and whose effect will be
> > to call the corresponding function via eww-before-browse-function.
> > The defcustom could also have a user-defined function value to allow
> > additional functions, of course.
>
> I've done something close to this, though I retained the previous form
> where the possible values are things like 'eww-delete-future-history'.
> That keeps the code to *use* this option simpler (no special-case symbol
> names), and the only difference with your suggestion is that users who
> manually edit their init.el will have a longer symbol name to type.
>
> For Customize users, I added 'function-item' choices so they should just
> be able to click on the option they want without having to worry about
> the exact symbol name.
>
> If you strongly prefer to have this accept non-function symbol names
> like 'clear', let me know and I can change it. I don't care too much,
> but this way seemed simpler and easier to maintain.
I think what you did is functionally equivalent, and not harder to use
in practice. So I'm okay with this version of the patch. Thanks.
next prev parent reply other threads:[~2024-03-02 7:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-18 4:59 bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop Jim Porter
2024-02-19 12:12 ` Eli Zaretskii
2024-02-19 18:55 ` Jim Porter
2024-02-19 19:17 ` Eli Zaretskii
2024-02-22 13:22 ` Eli Zaretskii
2024-02-22 17:18 ` Jim Porter
2024-02-22 19:04 ` Eli Zaretskii
2024-02-22 20:10 ` Jim Porter
2024-02-22 20:13 ` Eli Zaretskii
2024-02-24 14:15 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-24 14:20 ` Eli Zaretskii
2024-02-24 22:29 ` Jim Porter
2024-02-25 0:50 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-24 22:34 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-25 5:57 ` Eli Zaretskii
2024-02-25 19:40 ` Jim Porter
2024-02-25 19:49 ` Eli Zaretskii
2024-02-25 22:41 ` Jim Porter
2024-02-28 23:39 ` Jim Porter
2024-02-29 7:03 ` Eli Zaretskii
2024-02-29 17:32 ` Jim Porter
2024-02-29 23:30 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-01 1:00 ` Jim Porter
2024-03-01 2:10 ` Jim Porter
2024-03-01 7:26 ` Eli Zaretskii
2024-03-01 20:13 ` Jim Porter
2024-03-02 7:38 ` Eli Zaretskii [this message]
2024-03-07 0:26 ` Jim Porter
2024-03-01 8:50 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-01 11:56 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86plwdozhg.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=69232@debbugs.gnu.org \
--cc=jimjoe@gmx.net \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).