From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 69232@debbugs.gnu.org
Subject: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop
Date: Mon, 19 Feb 2024 14:12:07 +0200 [thread overview]
Message-ID: <864je4r6ug.fsf@gnu.org> (raw)
In-Reply-To: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> (message from Jim Porter on Sat, 17 Feb 2024 20:59:57 -0800)
> Date: Sat, 17 Feb 2024 20:59:57 -0800
> From: Jim Porter <jporterbugs@gmail.com>
>
> If you navigate back in EWW history, and then forward, you can never hit
> the "end": it keeps adding duplicate history elements, even though
> you're not visiting any new pages. To see this in action, start from
> `emacs -Q`, then:
>
> M-x eww RET fsf.org RET
> M-x eww RET gnu.org RET
> H ;; Notice that there's one item in the history: the FSF page[1]
> q ;; Close history window
> l ;; Go back one in the history to the FSF page
> H ;; Notice that there are two items in the history
> r ;; Go forward one, back at the GNU page
> r ;; Go forward again, now at the FSF page(?!)
> r ;; Ditto, now at the GNU page
> r ;; Repeat ad infinitum
> H ;; Now there are many entries, alternating between GNU and FSF
>
> Attached is a patch that fixes this. Now, 'eww-save-history' will update
> the history entry in-place when viewing a historical page, and
> 'eww-back-url' / 'eww-forward-url' take that into account. I also fixed
> the predicates for when the back/forward menu items were enabled.
>
> I think this is just a straightforward bug fix, so I didn't add a NEWS
> entry. I could add one though if it seems worthwhile.
I'm not sure this is a bug fix, and I think this behavior change does
need a NEWS entry.
And have sure you are that no one will want the current behavior?
next prev parent reply other threads:[~2024-02-19 12:12 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-18 4:59 bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop Jim Porter
2024-02-19 12:12 ` Eli Zaretskii [this message]
2024-02-19 18:55 ` Jim Porter
2024-02-19 19:17 ` Eli Zaretskii
2024-02-22 13:22 ` Eli Zaretskii
2024-02-22 17:18 ` Jim Porter
2024-02-22 19:04 ` Eli Zaretskii
2024-02-22 20:10 ` Jim Porter
2024-02-22 20:13 ` Eli Zaretskii
2024-02-24 14:15 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-24 14:20 ` Eli Zaretskii
2024-02-24 22:29 ` Jim Porter
2024-02-25 0:50 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-24 22:34 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-25 5:57 ` Eli Zaretskii
2024-02-25 19:40 ` Jim Porter
2024-02-25 19:49 ` Eli Zaretskii
2024-02-25 22:41 ` Jim Porter
2024-02-28 23:39 ` Jim Porter
2024-02-29 7:03 ` Eli Zaretskii
2024-02-29 17:32 ` Jim Porter
2024-02-29 23:30 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-01 1:00 ` Jim Porter
2024-03-01 2:10 ` Jim Porter
2024-03-01 7:26 ` Eli Zaretskii
2024-03-01 20:13 ` Jim Porter
2024-03-02 7:38 ` Eli Zaretskii
2024-03-07 0:26 ` Jim Porter
2024-03-01 8:50 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-01 11:56 ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864je4r6ug.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=69232@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).