From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop Date: Thu, 29 Feb 2024 17:00:22 -0800 Message-ID: References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> <86sf1k1fss.fsf@gnu.org> <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> <87r0h2x816.fsf@outlook.com> <8634tiymd4.fsf@gnu.org> <87cyslxziy.fsf@gmx.net> <86frxhxezx.fsf@gnu.org> <3f0da1b2-e256-6124-4d6a-47c922ccd64f@gmail.com> <86bk84wci4.fsf@gnu.org> <7b67c305-1e41-9db2-55d3-f74f1ac302a6@gmail.com> <10a0d839-24f6-b521-1504-a5ca568b3dcc@gmail.com> <86plwfsqey.fsf@gnu.org> <77426857-4d81-29da-9b1a-70931393215e@gmail.com> <878r32u9ut.fsf@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23411"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 69232@debbugs.gnu.org To: James Thomas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 01 02:02:07 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rfrHr-0005xu-6H for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 01 Mar 2024 02:02:07 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rfrHP-0003C9-CY; Thu, 29 Feb 2024 20:01:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rfrHL-0003Bz-QD for bug-gnu-emacs@gnu.org; Thu, 29 Feb 2024 20:01:35 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rfrHK-0005qI-Uc for bug-gnu-emacs@gnu.org; Thu, 29 Feb 2024 20:01:35 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rfrHm-0003UU-2a for bug-gnu-emacs@gnu.org; Thu, 29 Feb 2024 20:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 01 Mar 2024 01:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69232 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69232-submit@debbugs.gnu.org id=B69232.170925491913408 (code B ref 69232); Fri, 01 Mar 2024 01:02:02 +0000 Original-Received: (at 69232) by debbugs.gnu.org; 1 Mar 2024 01:01:59 +0000 Original-Received: from localhost ([127.0.0.1]:35733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfrHi-0003UB-JX for submit@debbugs.gnu.org; Thu, 29 Feb 2024 20:01:58 -0500 Original-Received: from mail-il1-f181.google.com ([209.85.166.181]:53441) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfrHg-0003Tt-57 for 69232@debbugs.gnu.org; Thu, 29 Feb 2024 20:01:57 -0500 Original-Received: by mail-il1-f181.google.com with SMTP id e9e14a558f8ab-365c773ae6cso5732015ab.2 for <69232@debbugs.gnu.org>; Thu, 29 Feb 2024 17:01:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709254823; x=1709859623; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=WRgWetmmZEdcGdyYkQN8Gn/xqywyzhy/3AjCV7ZkWzs=; b=d8uJgm+86laOn3opuhHih+f8Ox5zALikHdrUZo3Rms/+wGK2BhF22KZOsj9qdlgwrN FQphyiXvsMLoicOQH1IUBbWFNbfiv9ihAUa4pf3x2SjPMnfO47jzBGX8Q2Y10F+MoRZI vIxaWoy4zU7GtlX9sx4bM5dtDzJd+tGhqNpVMgZ8A2UerkOCDUHUjBF9iQFjxLB0/SId f9mLpOAsEGNPFiR5jVB4ZZb6X8Ol9/eHuPxD/D8JwhXak0qCBwZo5fB6TyJnccV8IL6H BwYVq4DoBZk7JEYx8L4AZ+9KyggtL/pS3XQtFBvZWra8UlrOFxIZteUYB9RCWAWbQKK3 rHQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709254823; x=1709859623; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WRgWetmmZEdcGdyYkQN8Gn/xqywyzhy/3AjCV7ZkWzs=; b=hH8BsdBENcXIbA8SlTKx/kInW9yyBgseYKtQZp3ifzLNtnCZgMIHs8MJqJZjfcA78O smP6SsLMPfZ3d75XH9OHbPAkrGw6/ahLKT8v0GJMwJt0Hxofy4dtgVZk+UVi/nwz2tb3 IXnN6EilWGVJeJd/1fM0cIPCkTvm/FEYNZRJWXX1DpFjMrJxUAI2OW2VkV6gFy1Jo37e WPq0gl9JdS7BGxC9xFbCqqZHDiVKYFaZlIgl59usPoUGwS0I1kpa27L2ofxNloXFXO5w Rxsw8G5Ttzwj0g+7IXF2o88STPTgnFWxyNNN/oa20FvUNsBf8djH0utMfIMYA59gkBKR wzPQ== X-Forwarded-Encrypted: i=1; AJvYcCU1zd5fpCsOOlZKZXrdMxRTotNrGMPif+cnGtCoWUDQJn3/Kw4sQnPDWCvc0cdXjTt7um09wLnyLzyfpZ8v4b7+ZyCsmSA= X-Gm-Message-State: AOJu0YwDPEwEW2ExXlpJZg/QgNHYS9Vz5HYI+dKJb4zKj++9c94fEhsK hlfHchjPPjGmK5FTZflJbx8L6+gjQjadfFgpXBkwQFcvcKHqeO2Y X-Google-Smtp-Source: AGHT+IEXyTHcGU4sXpyPubDkqdaWNp7Zf6piDvOTw77J6GlHloKjZ/dfrfkdQBB/s7NAvtz27UH2JA== X-Received: by 2002:a05:6e02:19ce:b0:365:1959:c288 with SMTP id r14-20020a056e0219ce00b003651959c288mr329684ill.30.1709254822886; Thu, 29 Feb 2024 17:00:22 -0800 (PST) Original-Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id j36-20020a63fc24000000b0059b2316be86sm1896162pgi.46.2024.02.29.17.00.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Feb 2024 17:00:22 -0800 (PST) Content-Language: en-US In-Reply-To: <878r32u9ut.fsf@gmx.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280830 Archived-At: On 2/29/2024 3:30 PM, James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > The current patch is much better for me personally: 'l' and 'r' now do > what they're supposed to do. But my ideal (short of any advanced 'tree' > mechanism), as I originally stated, would've been to _insert_ (rather > than _replace_) the new history at the position in the current history > where it's created (but I see that there's no SOP for that in (info > "(elisp) Minibuffer History"), and that there could be performance > implications). That shouldn't be too hard to do, at the very least with the appropriate hooks (i.e. you might need to write some Elisp depending on how many built-in options we want to support, but you won't have to use 'advice-add'). > Why not simply make 'eww-save-history' customizable? In a general sense, that's the idea. I don't want to make 'eww-save-history' itself customizable though, since a) I want to let people define a history pruning/fixup function and b) I don't want that customizable function to have to be responsible for saving the current page's history; 'eww-save-history' can do that for us. In practice though, I think it'll all work out about the same, albeit easier to use. > TBH I don't think anyone would have been (ab)using it effectively > because each 'l' or 'r' made things more complicated; but the advantage > that *all* of history was available with 'H'. Yeah, I think the main thing we need here is some option to prevent loss of existing history. > (I'm using this patch and will let you know if I see anything amiss) I already found one issue with reloading messing up history, but that was an easy fix. Once I finish up the other parts of my v3 patch, I'll post it here.