From: Gregory Heytings <gregory@heytings.org>
To: Juri Linkov <juri@linkov.net>
Cc: 56815@debbugs.gnu.org, Lars Ingebrigtsen <larsi@gnus.org>,
Eli Zaretskii <eliz@gnu.org>
Subject: bug#56815: 29.0.50; Isearch lazy-highlight highlights too much when truncate-lines is in effect
Date: Fri, 29 Jul 2022 18:37:55 +0000 [thread overview]
Message-ID: <bf6b6a6fd369cd74b0fd@heytings.org> (raw)
In-Reply-To: <86mtcrpyzs.fsf@mail.linkov.net>
>> Would it be possibly to make the isearch lazy-highlight just skip the
>> portions of the buffer that aren't visible?
>
> Indeed what is worth trying is to add pos-visible-in-window-group-p
> either to isearch-filter-predicate, or directly to
> isearch-lazy-highlight-search.
>
That wouldn't work alas.
The problem is how "visible" is defined here (by pos-visible-in-window-p).
With truncated lines, all buffer positions between window-start and
window-end are "visible", or IOW, all buffer positions on the left or
right of the actually visible line portion are "visible".
Moreover pos-visible-in-window-p is a slow function, so it would be
terribly slow to call it for each candidate position in a buffer with
(tens of) thousands of candidate positions.
next prev parent reply other threads:[~2022-07-29 18:37 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 17:29 bug#56815: 29.0.50; Isearch lazy-highlight highlights too much when truncate-lines is in effect Eli Zaretskii
2022-07-28 20:08 ` Juri Linkov
2022-07-29 5:50 ` Eli Zaretskii
2022-07-29 11:48 ` Lars Ingebrigtsen
2022-07-29 18:14 ` Juri Linkov
2022-07-29 18:37 ` Gregory Heytings [this message]
2022-07-29 19:02 ` Eli Zaretskii
2022-07-29 19:11 ` Gregory Heytings
2022-07-29 19:31 ` Eli Zaretskii
2022-07-29 19:36 ` Eli Zaretskii
2022-07-29 19:52 ` Gregory Heytings
2022-07-29 19:59 ` Eli Zaretskii
2022-07-29 20:26 ` Gregory Heytings
2022-07-30 5:35 ` Eli Zaretskii
2022-07-31 19:40 ` Juri Linkov
2022-07-31 21:21 ` Gregory Heytings
2022-08-01 11:51 ` Eli Zaretskii
2022-08-01 18:09 ` Juri Linkov
2022-08-02 7:31 ` Gregory Heytings
2022-08-02 11:10 ` Eli Zaretskii
2022-08-14 13:53 ` Eli Zaretskii
2022-08-21 16:32 ` Juri Linkov
2022-08-21 17:06 ` Eli Zaretskii
2022-08-21 19:03 ` Juri Linkov
2022-08-21 19:35 ` Eli Zaretskii
2022-08-22 6:48 ` Juri Linkov
2022-08-22 11:32 ` Eli Zaretskii
2022-08-23 7:41 ` Juri Linkov
2022-08-23 12:11 ` Eli Zaretskii
2022-08-23 16:49 ` Juri Linkov
2022-08-27 19:52 ` Juri Linkov
2022-08-08 17:20 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf6b6a6fd369cd74b0fd@heytings.org \
--to=gregory@heytings.org \
--cc=56815@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).