unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Gregory Heytings <gregory@heytings.org>
Cc: larsi@gnus.org, 56815@debbugs.gnu.org, juri@linkov.net
Subject: bug#56815: 29.0.50; Isearch lazy-highlight highlights too much when truncate-lines is in effect
Date: Sat, 30 Jul 2022 08:35:58 +0300	[thread overview]
Message-ID: <835yjf6u2p.fsf@gnu.org> (raw)
In-Reply-To: <bf6b6a6fd35ae2bb3303@heytings.org> (message from Gregory Heytings on Fri, 29 Jul 2022 20:26:00 +0000)

> Date: Fri, 29 Jul 2022 20:26:00 +0000
> From: Gregory Heytings <gregory@heytings.org>
> cc: larsi@gnus.org, 56815@debbugs.gnu.org, juri@linkov.net
> 
> > And yes, if we want truncate-lines to work reasonably well, we need to 
> > fix any features which behave silly in that display mode.
> 
> If we want truncate-lines to work reasonably well without fixing all such 
> features one-by-one, we need to fix the root cause of that dysfunction, 
> which is not inside these individual features, but is the fact that (- 
> (window-end) (window-start)) is huge.

I'm not convinced that this is the root cause, nor that there is
indeed a single cause.  So far we have found only one feature where
this is true, and even that is only because Isearch uses that
particular method of deciding when to produce the highlight overlays.

It is true that the narrowing optimizations work less well under
truncate-lines, for these reasons, but there are other places where we
can make improvements and other methods of doing that.

There's no reason to believe that the general issue of long lines can
be solved by a small number of changes that narrow the buffer.
Whatever is left after that we should try solving by other methods.

> > We will not remove truncate-lines from Emacs, and we will not make it 
> > dysfunctional.
> >
> 
> Nobody is asking or suggesting to remove truncate-lines from Emacs, or to 
> make is dysfunctional.  Admitting that it doesn't work together with long 
> lines, which has always been the case, is something entirely different.

I admit that it's a tougher nut that currently is not yet cracked,
yes.  But if improvements can be made in that mode, we should at least
try making them, even if those improvements call for some
complications in our code.





  reply	other threads:[~2022-07-30  5:35 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-28 17:29 bug#56815: 29.0.50; Isearch lazy-highlight highlights too much when truncate-lines is in effect Eli Zaretskii
2022-07-28 20:08 ` Juri Linkov
2022-07-29  5:50   ` Eli Zaretskii
2022-07-29 11:48     ` Lars Ingebrigtsen
2022-07-29 18:14       ` Juri Linkov
2022-07-29 18:37         ` Gregory Heytings
2022-07-29 19:02           ` Eli Zaretskii
2022-07-29 19:11             ` Gregory Heytings
2022-07-29 19:31               ` Eli Zaretskii
2022-07-29 19:36                 ` Eli Zaretskii
2022-07-29 19:52                 ` Gregory Heytings
2022-07-29 19:59                   ` Eli Zaretskii
2022-07-29 20:26                     ` Gregory Heytings
2022-07-30  5:35                       ` Eli Zaretskii [this message]
2022-07-31 19:40                       ` Juri Linkov
2022-07-31 21:21                         ` Gregory Heytings
2022-08-01 11:51                         ` Eli Zaretskii
2022-08-01 18:09                           ` Juri Linkov
2022-08-02  7:31                             ` Gregory Heytings
2022-08-02 11:10                               ` Eli Zaretskii
2022-08-14 13:53                             ` Eli Zaretskii
2022-08-21 16:32                               ` Juri Linkov
2022-08-21 17:06                                 ` Eli Zaretskii
2022-08-21 19:03                                   ` Juri Linkov
2022-08-21 19:35                                     ` Eli Zaretskii
2022-08-22  6:48                                       ` Juri Linkov
2022-08-22 11:32                                         ` Eli Zaretskii
2022-08-23  7:41                                           ` Juri Linkov
2022-08-23 12:11                                             ` Eli Zaretskii
2022-08-23 16:49                                               ` Juri Linkov
2022-08-27 19:52                                                 ` Juri Linkov
2022-08-08 17:20 ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=835yjf6u2p.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=56815@debbugs.gnu.org \
    --cc=gregory@heytings.org \
    --cc=juri@linkov.net \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).