unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 56815@debbugs.gnu.org
Subject: bug#56815: 29.0.50; Isearch lazy-highlight highlights too much when truncate-lines is in effect
Date: Thu, 28 Jul 2022 23:08:23 +0300	[thread overview]
Message-ID: <865yjhc85k.fsf@mail.linkov.net> (raw)
In-Reply-To: <83mtct87ti.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 28 Jul 2022 20:29:13 +0300")

> To reproduce, visit any file with very long lines, turn on
> truncate-lines, and invoke Isearch. after typing some search string
> for which there are matches in the buffer, Isearch will highlight many
> matches that are not visible in the window.  In an extreme case where
> a file has a single very long line, all the matches in the buffer will
> be highlighted.  This both takes long time, and slows down many
> display-related commands, because the large number of overlays created
> for the highlighting slows down redisplay.
>
> This happens because isearch.el uses window-end as the limit beyond
> which to stop highlighting, but that is a poor indicator of visibility
> in buffers under truncate-lines.
>
> If isearch.el cannot find a better criterion for stopping highlighting
> beyond some buffer position, it should at least use some reasonable
> fixed (or customizable) limit.  Another possibility is to turn off
> lazy-highlight by default when truncate-lines is turned on.
>
> This issue is related to poor Emacs performance in buffers with very
> long lines, and its fix is essential for making Emacs more usable with
> such buffers.

I didn't follow the new design of long lines handling.
Does it just narrow each long truncated line?
When narrowing is in effect then lazy-highlight
should already do the right thing since it can't go
outside of the narrowed regions.





  reply	other threads:[~2022-07-28 20:08 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-28 17:29 bug#56815: 29.0.50; Isearch lazy-highlight highlights too much when truncate-lines is in effect Eli Zaretskii
2022-07-28 20:08 ` Juri Linkov [this message]
2022-07-29  5:50   ` Eli Zaretskii
2022-07-29 11:48     ` Lars Ingebrigtsen
2022-07-29 18:14       ` Juri Linkov
2022-07-29 18:37         ` Gregory Heytings
2022-07-29 19:02           ` Eli Zaretskii
2022-07-29 19:11             ` Gregory Heytings
2022-07-29 19:31               ` Eli Zaretskii
2022-07-29 19:36                 ` Eli Zaretskii
2022-07-29 19:52                 ` Gregory Heytings
2022-07-29 19:59                   ` Eli Zaretskii
2022-07-29 20:26                     ` Gregory Heytings
2022-07-30  5:35                       ` Eli Zaretskii
2022-07-31 19:40                       ` Juri Linkov
2022-07-31 21:21                         ` Gregory Heytings
2022-08-01 11:51                         ` Eli Zaretskii
2022-08-01 18:09                           ` Juri Linkov
2022-08-02  7:31                             ` Gregory Heytings
2022-08-02 11:10                               ` Eli Zaretskii
2022-08-14 13:53                             ` Eli Zaretskii
2022-08-21 16:32                               ` Juri Linkov
2022-08-21 17:06                                 ` Eli Zaretskii
2022-08-21 19:03                                   ` Juri Linkov
2022-08-21 19:35                                     ` Eli Zaretskii
2022-08-22  6:48                                       ` Juri Linkov
2022-08-22 11:32                                         ` Eli Zaretskii
2022-08-23  7:41                                           ` Juri Linkov
2022-08-23 12:11                                             ` Eli Zaretskii
2022-08-23 16:49                                               ` Juri Linkov
2022-08-27 19:52                                                 ` Juri Linkov
2022-08-08 17:20 ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=865yjhc85k.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=56815@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).