unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 56815@debbugs.gnu.org, gregory@heytings.org, larsi@gnus.org
Subject: bug#56815: 29.0.50; Isearch lazy-highlight highlights too much when truncate-lines is in effect
Date: Sun, 14 Aug 2022 16:53:50 +0300	[thread overview]
Message-ID: <83r11jj5ht.fsf@gnu.org> (raw)
In-Reply-To: <86y1w7bzum.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 01 Aug 2022 21:09:05 +0300)

> From: Juri Linkov <juri@linkov.net>
> Cc: gregory@heytings.org,  larsi@gnus.org,  56815@debbugs.gnu.org
> Date: Mon, 01 Aug 2022 21:09:05 +0300
> 
> > So if no good ideas arise that are simple enough to implement, I'm
> > okay with simply disabling isearch-lazy-highlight in such buffers, as
> > I wrote in the original bug report.  (Doing that will probably require
> > exposing the "long-lines" flag to Lisp, but that's fine by me.)
> 
> Exposing the "long-lines" flag to Lisp is exactly what is needed.
> So when lazy-highlight will detect a special value of a new
> buffer-local variable when narrowing is in effect due to long lines,
> then lazy-highlight can switch to a different algorithm
> like you described earlier.  Currently isearch-lazy-highlight-new-loop
> checks for window-group-start and window-group-end.  But when
> the "long-lines" flag is set, it should also check for window-hscroll
> because narrowed lazy-highlighting should be updated on hscrolling.
> 
> This "long-lines" flag will be also useful for pre-command-hook
> and post-command-hook to convey the information about narrowing
> to hooks.

You can now use the new long-line-optimizations-p predicate for that.
Although from your description above, perhaps Isearch should behave
like that in a buffer with line-truncation regardless of the long
lines.





  parent reply	other threads:[~2022-08-14 13:53 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-28 17:29 bug#56815: 29.0.50; Isearch lazy-highlight highlights too much when truncate-lines is in effect Eli Zaretskii
2022-07-28 20:08 ` Juri Linkov
2022-07-29  5:50   ` Eli Zaretskii
2022-07-29 11:48     ` Lars Ingebrigtsen
2022-07-29 18:14       ` Juri Linkov
2022-07-29 18:37         ` Gregory Heytings
2022-07-29 19:02           ` Eli Zaretskii
2022-07-29 19:11             ` Gregory Heytings
2022-07-29 19:31               ` Eli Zaretskii
2022-07-29 19:36                 ` Eli Zaretskii
2022-07-29 19:52                 ` Gregory Heytings
2022-07-29 19:59                   ` Eli Zaretskii
2022-07-29 20:26                     ` Gregory Heytings
2022-07-30  5:35                       ` Eli Zaretskii
2022-07-31 19:40                       ` Juri Linkov
2022-07-31 21:21                         ` Gregory Heytings
2022-08-01 11:51                         ` Eli Zaretskii
2022-08-01 18:09                           ` Juri Linkov
2022-08-02  7:31                             ` Gregory Heytings
2022-08-02 11:10                               ` Eli Zaretskii
2022-08-14 13:53                             ` Eli Zaretskii [this message]
2022-08-21 16:32                               ` Juri Linkov
2022-08-21 17:06                                 ` Eli Zaretskii
2022-08-21 19:03                                   ` Juri Linkov
2022-08-21 19:35                                     ` Eli Zaretskii
2022-08-22  6:48                                       ` Juri Linkov
2022-08-22 11:32                                         ` Eli Zaretskii
2022-08-23  7:41                                           ` Juri Linkov
2022-08-23 12:11                                             ` Eli Zaretskii
2022-08-23 16:49                                               ` Juri Linkov
2022-08-27 19:52                                                 ` Juri Linkov
2022-08-08 17:20 ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83r11jj5ht.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=56815@debbugs.gnu.org \
    --cc=gregory@heytings.org \
    --cc=juri@linkov.net \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).