From: Carlos Pita <carlosjosepita@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 37756@debbugs.gnu.org
Subject: bug#37756: [PATCH] Wrong initialization of fringe bitmap
Date: Tue, 15 Oct 2019 07:14:25 -0300 [thread overview]
Message-ID: <CAELgYhccqv4SJhayZT=jedXsvD8rKDjruJ-xRojARZjFrR5kEQ@mail.gmail.com> (raw)
In-Reply-To: <838spmgx1t.fsf@gnu.org>
> Can you explain your reasoning? The loop after that does initialize
Ok, TBH I hadn't looked at the loop. But anyway:
> > xfb = xmalloc (sizeof fb + fb.height * BYTES_PER_BITMAP_ROW);
This allocates fb.height * BYTES_PER_BITMAP_ROW for bits = b.
> > memset (b, 0, fb.height);
This only initializes fb.height bytes to zero.
And then the loop indeed initializes all fb.height *
BYTES_PER_BITMAP_ROW bytes (b being an unsigned short pointer):
j = 0;
while (j < fb.height)
{
...
b[j++] = something;
...
}
So instead of memset (b, 0, fb.height) being incomplete I would now
say that it is redundant and misleading.
next prev parent reply other threads:[~2019-10-15 10:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 2:39 bug#37756: [PATCH] Wrong initialization of fringe bitmap Carlos Pita
2019-10-15 9:47 ` Eli Zaretskii
2019-10-15 10:14 ` Carlos Pita [this message]
2019-10-16 17:28 ` Carlos Pita
2019-10-16 18:35 ` Eli Zaretskii
2019-10-16 18:54 ` Carlos Pita
2019-10-16 19:05 ` Eli Zaretskii
2019-10-16 20:01 ` Carlos Pita
2019-10-17 11:53 ` Alan Third
2019-10-17 15:01 ` Robert Pluim
2019-10-26 10:21 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAELgYhccqv4SJhayZT=jedXsvD8rKDjruJ-xRojARZjFrR5kEQ@mail.gmail.com' \
--to=carlosjosepita@gmail.com \
--cc=37756@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).