From: Carlos Pita <carlosjosepita@gmail.com>
To: 37756@debbugs.gnu.org
Subject: bug#37756: [PATCH] Wrong initialization of fringe bitmap
Date: Mon, 14 Oct 2019 23:39:19 -0300 [thread overview]
Message-ID: <CAELgYheP_R7LoEcV8GqqOy218FLPU99qV5_UZPwaRG2VKufZUQ@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 462 bytes --]
In fringe.c:1606 you have:
xfb = xmalloc (sizeof fb + fb.height * BYTES_PER_BITMAP_ROW);
fb.bits = b = ((unsigned short *)
ptr_bounds_clip (xfb + 1, fb.height * BYTES_PER_BITMAP_ROW));
xfb = ptr_bounds_clip (xfb, sizeof *xfb);
memset (b, 0, fb.height);
I might be wrong but it seems to me that the last line should be:
memset (b, 0, fb.height * BYTES_PER_BITMAP_ROW);
instead.
I've attached a patch that does exactly that.
Best regards
--
Carlos
[-- Attachment #2: 0001-Fix-zero-initialization-of-fringe-bitmap.patch --]
[-- Type: text/x-patch, Size: 895 bytes --]
From fe3f040d6614ee4b990f3f4252c89d9a17c52845 Mon Sep 17 00:00:00 2001
From: memeplex <carlosjosepita@gmail.com>
Date: Mon, 14 Oct 2019 23:33:37 -0300
Subject: [PATCH] Fix zero initialization of fringe bitmap
* src/fringe.c: the size in bytes of fb.bits is
fb.height * BYTES_PER_BITMAP_ROW
and not simply the number of rows fb.height.
---
src/fringe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/fringe.c b/src/fringe.c
index 22f3bdc..db91209 100644
--- a/src/fringe.c
+++ b/src/fringe.c
@@ -1607,7 +1607,7 @@ list (ALIGN PERIODIC) where PERIODIC non-nil specifies that the bitmap
fb.bits = b = ((unsigned short *)
ptr_bounds_clip (xfb + 1, fb.height * BYTES_PER_BITMAP_ROW));
xfb = ptr_bounds_clip (xfb, sizeof *xfb);
- memset (b, 0, fb.height);
+ memset (b, 0, fb.height * BYTES_PER_BITMAP_ROW);
j = 0;
while (j < fb.height)
--
2.20.1
next reply other threads:[~2019-10-15 2:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 2:39 Carlos Pita [this message]
2019-10-15 9:47 ` bug#37756: [PATCH] Wrong initialization of fringe bitmap Eli Zaretskii
2019-10-15 10:14 ` Carlos Pita
2019-10-16 17:28 ` Carlos Pita
2019-10-16 18:35 ` Eli Zaretskii
2019-10-16 18:54 ` Carlos Pita
2019-10-16 19:05 ` Eli Zaretskii
2019-10-16 20:01 ` Carlos Pita
2019-10-17 11:53 ` Alan Third
2019-10-17 15:01 ` Robert Pluim
2019-10-26 10:21 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAELgYheP_R7LoEcV8GqqOy218FLPU99qV5_UZPwaRG2VKufZUQ@mail.gmail.com \
--to=carlosjosepita@gmail.com \
--cc=37756@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).