From: Carlos Pita <carlosjosepita@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 37756@debbugs.gnu.org
Subject: bug#37756: [PATCH] Wrong initialization of fringe bitmap
Date: Wed, 16 Oct 2019 17:01:11 -0300 [thread overview]
Message-ID: <CAELgYhc+=Edoizon+B8CfgfaUdt+-LT91PAH6RB8RW6743rM3Q@mail.gmail.com> (raw)
In-Reply-To: <83sgnscxyi.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 437 bytes --]
> Use one of the related Emacs commands, and Emacs will do that for you.
> Those commands are described in CONTRIBUTE under "Generating ChangeLog
> entries".
I'm having some issues doing that because I'm using magit to amend /
reword previously committed changes, so the instructions there don't
quite match my situation. Will try harder later, for now I just
modified the message after some examples in your git log. Hope it's ok
now.
[-- Attachment #2: 0001-Remove-redundant-initialization-of-fringe-bitmap-Bug.patch --]
[-- Type: text/x-patch, Size: 833 bytes --]
From dcb47d7cfb83fb4b5a28c7f909aea8e5aab11893 Mon Sep 17 00:00:00 2001
From: memeplex <carlosjosepita@gmail.com>
Date: Wed, 16 Oct 2019 13:44:00 -0300
Subject: [PATCH] Remove redundant initialization of fringe bitmap (Bug#37756)
* src/fringe.c (Fdefine-fringe-bitmap): Remove redundant zeroing
of fb.bits that only zeroed half of the array anyway.
---
src/fringe.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/fringe.c b/src/fringe.c
index 22f3bdc..08bf271 100644
--- a/src/fringe.c
+++ b/src/fringe.c
@@ -1607,7 +1607,6 @@ list (ALIGN PERIODIC) where PERIODIC non-nil specifies that the bitmap
fb.bits = b = ((unsigned short *)
ptr_bounds_clip (xfb + 1, fb.height * BYTES_PER_BITMAP_ROW));
xfb = ptr_bounds_clip (xfb, sizeof *xfb);
- memset (b, 0, fb.height);
j = 0;
while (j < fb.height)
--
2.20.1
next prev parent reply other threads:[~2019-10-16 20:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 2:39 bug#37756: [PATCH] Wrong initialization of fringe bitmap Carlos Pita
2019-10-15 9:47 ` Eli Zaretskii
2019-10-15 10:14 ` Carlos Pita
2019-10-16 17:28 ` Carlos Pita
2019-10-16 18:35 ` Eli Zaretskii
2019-10-16 18:54 ` Carlos Pita
2019-10-16 19:05 ` Eli Zaretskii
2019-10-16 20:01 ` Carlos Pita [this message]
2019-10-17 11:53 ` Alan Third
2019-10-17 15:01 ` Robert Pluim
2019-10-26 10:21 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAELgYhc+=Edoizon+B8CfgfaUdt+-LT91PAH6RB8RW6743rM3Q@mail.gmail.com' \
--to=carlosjosepita@gmail.com \
--cc=37756@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).