unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Carlos Pita <carlosjosepita@gmail.com>
Cc: 37756@debbugs.gnu.org
Subject: bug#37756: [PATCH] Wrong initialization of fringe bitmap
Date: Wed, 16 Oct 2019 21:35:03 +0300	[thread overview]
Message-ID: <83zhi0cze0.fsf@gnu.org> (raw)
In-Reply-To: <CAELgYhdk3D7CAWH5ttGnuJKtA0FZ1K7GPuFdyXRsiK9z18Kecg@mail.gmail.com> (message from Carlos Pita on Wed, 16 Oct 2019 14:28:29 -0300)

> From: Carlos Pita <carlosjosepita@gmail.com>
> Date: Wed, 16 Oct 2019 14:28:29 -0300
> Cc: 37756@debbugs.gnu.org
> 
> Here is a patch that removes the superfluous line with a detailed
> explanation in the commit message.

Thanks, but please format the log message according to CONTRIBUTE: it
should name the function in which the change is being made, start with
a capital letter, and keep 2 spaces between sentences.  Also, there's
no need to describe in such detail what the code does, when the code
speaks for itself.  You could just say "Remove redundant zeroing of
fb.bits".





  reply	other threads:[~2019-10-16 18:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-15  2:39 bug#37756: [PATCH] Wrong initialization of fringe bitmap Carlos Pita
2019-10-15  9:47 ` Eli Zaretskii
2019-10-15 10:14   ` Carlos Pita
2019-10-16 17:28     ` Carlos Pita
2019-10-16 18:35       ` Eli Zaretskii [this message]
2019-10-16 18:54         ` Carlos Pita
2019-10-16 19:05           ` Eli Zaretskii
2019-10-16 20:01             ` Carlos Pita
2019-10-17 11:53               ` Alan Third
2019-10-17 15:01                 ` Robert Pluim
2019-10-26 10:21               ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83zhi0cze0.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=37756@debbugs.gnu.org \
    --cc=carlosjosepita@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).