From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Carlos Pita Newsgroups: gmane.emacs.bugs Subject: bug#37756: [PATCH] Wrong initialization of fringe bitmap Date: Tue, 15 Oct 2019 07:14:25 -0300 Message-ID: References: <838spmgx1t.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="220907"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37756@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 15 12:15:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKJrD-000vMV-1U for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Oct 2019 12:15:11 +0200 Original-Received: from localhost ([::1]:39532 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKJrB-0005jm-M4 for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Oct 2019 06:15:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43861) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKJr5-0005hD-J2 for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2019 06:15:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKJr4-0003vg-AL for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2019 06:15:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33952) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKJr4-0003va-6v for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2019 06:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKJr4-00038x-07 for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2019 06:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Carlos Pita Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Oct 2019 10:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37756 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37756-submit@debbugs.gnu.org id=B37756.157113448612041 (code B ref 37756); Tue, 15 Oct 2019 10:15:01 +0000 Original-Received: (at 37756) by debbugs.gnu.org; 15 Oct 2019 10:14:46 +0000 Original-Received: from localhost ([127.0.0.1]:42773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKJqo-000389-Gp for submit@debbugs.gnu.org; Tue, 15 Oct 2019 06:14:46 -0400 Original-Received: from mail-yw1-f44.google.com ([209.85.161.44]:37774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKJqk-00037t-9T for 37756@debbugs.gnu.org; Tue, 15 Oct 2019 06:14:44 -0400 Original-Received: by mail-yw1-f44.google.com with SMTP id m7so7139899ywe.4 for <37756@debbugs.gnu.org>; Tue, 15 Oct 2019 03:14:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kuXCPFpuxyRcCzxlKIjGF1iZnom7zyVY/DjvEwsdckw=; b=UoLjVe/r4TyFBpkZ4CKGihSsf494KBJQk2YL3ukbXbIdcpnImT4pcsGTgP3L3C6gNT b4Wyzphv82PpO46W8sw74esdDEn8nvAQFlRZ82GtLGl3ITmUTEBi98ysPFcQPGWsaaKj 4bsBBmENUgOyHxw2yr7dY32zc6GXHjX/3l9z21HPYyGWKxi+OvN/mD6Sx4pObWZuKOan ntJ8z9/HMChNxAZDeyRmX4FjGj2TgbGu5gyEsUQAPvF6OqVTRzgikMIAHmmqoKeOP9wd IO0AF8MTsITEnIpm3Lx4dgmkaw2Yl8sdOK3rk3P9l19Nj6OiQqOuS8qge6LHzxrqg8u8 CrUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kuXCPFpuxyRcCzxlKIjGF1iZnom7zyVY/DjvEwsdckw=; b=mwJQpdvFvz/qVIp0XErROubZ0zz0pZGuUmhLjHNXMpicS5lJjvg3/YSmCFNkG5oNVX Ayd2jHXnwM8XpXqloAYJo8hQKnc4CHZ+rmTe/YFsBZFcQO5VbGmbzF7fVLLphw0nDNXi 3wyl6NyXc5Id7gncUwntnraCqElgp+B6Mz/Ab1nAn8f4GkS1W7tYiwczDjqf2FRiVHCl 9+bA/hOZBsrhClnv7eSM/w9Gd45SmX/xT8jEKR8bGBgV24sLwgTPvdtpO8nJqYWIu0dG Xdo86pilSIkNetRlVy236xD1s8eQqTtyiiGaYFemd3+bSyCZha6/+5bsoJbSfw9fgp9n zkIA== X-Gm-Message-State: APjAAAXIHFBVOepl3VWziBqNnr++gxVdSauWi1FvyFAmdqY6kF620ZaZ ksil38pKC45rxGlIRd7AwBW5YzxTa4LlBtl4WE8= X-Google-Smtp-Source: APXvYqxrkq6RoFOMs80LLLMTQdP44OITtkyw6AbCLh0k65b3Q4nOsND2VSdbljQivVfi87E7TFww/ckmMVhVI2BgC7A= X-Received: by 2002:a81:ab42:: with SMTP id d2mr15665979ywk.64.1571134476502; Tue, 15 Oct 2019 03:14:36 -0700 (PDT) In-Reply-To: <838spmgx1t.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169376 Archived-At: > Can you explain your reasoning? The loop after that does initialize Ok, TBH I hadn't looked at the loop. But anyway: > > xfb = xmalloc (sizeof fb + fb.height * BYTES_PER_BITMAP_ROW); This allocates fb.height * BYTES_PER_BITMAP_ROW for bits = b. > > memset (b, 0, fb.height); This only initializes fb.height bytes to zero. And then the loop indeed initializes all fb.height * BYTES_PER_BITMAP_ROW bytes (b being an unsigned short pointer): j = 0; while (j < fb.height) { ... b[j++] = something; ... } So instead of memset (b, 0, fb.height) being incomplete I would now say that it is redundant and misleading.