* bug#41221: Add some ediff faces to misterioso theme to improve readability
@ 2020-05-12 22:18 Simon Lang
2020-05-13 1:16 ` Stefan Kangas
0 siblings, 1 reply; 5+ messages in thread
From: Simon Lang @ 2020-05-12 22:18 UTC (permalink / raw)
To: 41221
[-- Attachment #1: Type: text/plain, Size: 108 bytes --]
This fix adds ediff faces for
ediff-even-diff-A
ediff-even-diff-B
ediff-odd-diff-A
ediff-odd-diff-B
[-- Attachment #2: 0001-Improve-ediff-readability-in-misterioso-theme.patch --]
[-- Type: application/octet-stream, Size: 1153 bytes --]
From 34b3bba8b919fc4e513c6202444d1287765de64e Mon Sep 17 00:00:00 2001
From: Simon Lang <simon.lang@outlook.com>
Date: Tue, 12 May 2020 22:54:52 +0100
Subject: [PATCH] Improve ediff readability in misterioso theme
* etc/themes/misterioso-theme.el: Add ediff faces
---
etc/themes/misterioso-theme.el | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/etc/themes/misterioso-theme.el b/etc/themes/misterioso-theme.el
index 8161dbd9e9..030cb3dd75 100644
--- a/etc/themes/misterioso-theme.el
+++ b/etc/themes/misterioso-theme.el
@@ -63,6 +63,11 @@
`(button ((,class (:underline t))))
`(link ((,class (:foreground "#59e9ff" :underline t))))
`(link-visited ((,class (:foreground "#ed74cd" :underline t))))
+ ;; Ediff
+ `(ediff-even-diff-A ((,class (:background "#1d2430"))))
+ `(ediff-even-diff-B ((,class (:background "#1d2430"))))
+ `(ediff-odd-diff-A ((,class (:background "#415160"))))
+ `(ediff-odd-diff-B ((,class (:background "#415160"))))
;; Gnus faces
`(gnus-group-news-1 ((,class (:foreground "#ff4242" :weight bold))))
`(gnus-group-news-1-low ((,class (:foreground "#ff4242"))))
--
2.21.0 (Apple Git-122)
^ permalink raw reply related [flat|nested] 5+ messages in thread
* bug#41221: Add some ediff faces to misterioso theme to improve readability
2020-05-12 22:18 bug#41221: Add some ediff faces to misterioso theme to improve readability Simon Lang
@ 2020-05-13 1:16 ` Stefan Kangas
2020-05-13 6:24 ` Simon Lang
2020-05-13 14:45 ` Eli Zaretskii
0 siblings, 2 replies; 5+ messages in thread
From: Stefan Kangas @ 2020-05-13 1:16 UTC (permalink / raw)
To: Simon Lang, 41221
Simon Lang <simon.lang@outlook.com> writes:
> This fix adds ediff faces for
>
> ediff-even-diff-A
> ediff-even-diff-B
> ediff-odd-diff-A
> ediff-odd-diff-B
Thank you for your contribution.
This is obviously broken in the theme as is, since you can't read the
changed text in ediff. I tested it, and your change looks good to me.
Eli, is the below acceptable for emacs-27?
> diff --git a/etc/themes/misterioso-theme.el b/etc/themes/misterioso-theme.el
> index 8161dbd9e9..030cb3dd75 100644
> --- a/etc/themes/misterioso-theme.el
> +++ b/etc/themes/misterioso-theme.el
> @@ -63,6 +63,11 @@
> `(button ((,class (:underline t))))
> `(link ((,class (:foreground "#59e9ff" :underline t))))
> `(link-visited ((,class (:foreground "#ed74cd" :underline t))))
> + ;; Ediff
> + `(ediff-even-diff-A ((,class (:background "#1d2430"))))
> + `(ediff-even-diff-B ((,class (:background "#1d2430"))))
> + `(ediff-odd-diff-A ((,class (:background "#415160"))))
> + `(ediff-odd-diff-B ((,class (:background "#415160"))))
Best regards,
Stefan Kangas
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#41221: Add some ediff faces to misterioso theme to improve readability
2020-05-13 1:16 ` Stefan Kangas
@ 2020-05-13 6:24 ` Simon Lang
2020-05-13 17:51 ` Stefan Kangas
2020-05-13 14:45 ` Eli Zaretskii
1 sibling, 1 reply; 5+ messages in thread
From: Simon Lang @ 2020-05-13 6:24 UTC (permalink / raw)
To: Stefan Kangas, 41221@debbugs.gnu.org
[-- Attachment #1: Type: text/plain, Size: 1520 bytes --]
Hi,
sorry, I relaized that I forgot about
ediff-even-diff-C
ediff-odd-diff-C
I added these now (trivial change, same faces as the others).
Thank you!!
________________________________________
From: Stefan Kangas <stefankangas@gmail.com>
Sent: 13 May 2020 02:16
To: Simon Lang; 41221@debbugs.gnu.org
Cc: Eli Zaretskii
Subject: Re: bug#41221: Add some ediff faces to misterioso theme to improve readability
Simon Lang <simon.lang@outlook.com> writes:
> This fix adds ediff faces for
>
> ediff-even-diff-A
> ediff-even-diff-B
> ediff-odd-diff-A
> ediff-odd-diff-B
Thank you for your contribution.
This is obviously broken in the theme as is, since you can't read the
changed text in ediff. I tested it, and your change looks good to me.
Eli, is the below acceptable for emacs-27?
> diff --git a/etc/themes/misterioso-theme.el b/etc/themes/misterioso-theme.el
> index 8161dbd9e9..030cb3dd75 100644
> --- a/etc/themes/misterioso-theme.el
> +++ b/etc/themes/misterioso-theme.el
> @@ -63,6 +63,11 @@
> `(button ((,class (:underline t))))
> `(link ((,class (:foreground "#59e9ff" :underline t))))
> `(link-visited ((,class (:foreground "#ed74cd" :underline t))))
> + ;; Ediff
> + `(ediff-even-diff-A ((,class (:background "#1d2430"))))
> + `(ediff-even-diff-B ((,class (:background "#1d2430"))))
> + `(ediff-odd-diff-A ((,class (:background "#415160"))))
> + `(ediff-odd-diff-B ((,class (:background "#415160"))))
Best regards,
Stefan Kangas
[-- Attachment #2: 0001-Improve-ediff-readability-in-misterioso-theme.patch --]
[-- Type: application/octet-stream, Size: 1274 bytes --]
From bdd582487a02275d82bfda01ebb6d0605c0349d0 Mon Sep 17 00:00:00 2001
From: Simon Lang <simon.lang@outlook.com>
Date: Tue, 12 May 2020 22:54:52 +0100
Subject: [PATCH] Improve ediff readability in misterioso theme
* etc/themes/misterioso-theme.el: Add ediff faces
---
etc/themes/misterioso-theme.el | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/etc/themes/misterioso-theme.el b/etc/themes/misterioso-theme.el
index 8161dbd9e9..ff9af0c744 100644
--- a/etc/themes/misterioso-theme.el
+++ b/etc/themes/misterioso-theme.el
@@ -63,6 +63,13 @@
`(button ((,class (:underline t))))
`(link ((,class (:foreground "#59e9ff" :underline t))))
`(link-visited ((,class (:foreground "#ed74cd" :underline t))))
+ ;; Ediff
+ `(ediff-even-diff-A ((,class (:background "#1d2430"))))
+ `(ediff-even-diff-B ((,class (:background "#1d2430"))))
+ `(ediff-even-diff-C ((,class (:background "#1d2430"))))
+ `(ediff-odd-diff-A ((,class (:background "#415160"))))
+ `(ediff-odd-diff-B ((,class (:background "#415160"))))
+ `(ediff-odd-diff-C ((,class (:background "#415160"))))
;; Gnus faces
`(gnus-group-news-1 ((,class (:foreground "#ff4242" :weight bold))))
`(gnus-group-news-1-low ((,class (:foreground "#ff4242"))))
--
2.21.0 (Apple Git-122)
^ permalink raw reply related [flat|nested] 5+ messages in thread
* bug#41221: Add some ediff faces to misterioso theme to improve readability
2020-05-13 1:16 ` Stefan Kangas
2020-05-13 6:24 ` Simon Lang
@ 2020-05-13 14:45 ` Eli Zaretskii
1 sibling, 0 replies; 5+ messages in thread
From: Eli Zaretskii @ 2020-05-13 14:45 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 41221, simon.lang
> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Tue, 12 May 2020 18:16:55 -0700
> Cc: Eli Zaretskii <eliz@gnu.org>
>
> Eli, is the below acceptable for emacs-27?
Yes, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#41221: Add some ediff faces to misterioso theme to improve readability
2020-05-13 6:24 ` Simon Lang
@ 2020-05-13 17:51 ` Stefan Kangas
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Kangas @ 2020-05-13 17:51 UTC (permalink / raw)
To: Simon Lang, 41221@debbugs.gnu.org
close 41221 27.1
thanks
Hi Simon,
Simon Lang <Simon.lang@outlook.com> writes:
> I added these now (trivial change, same faces as the others).
Great, looks good to me.
Thanks again for your contribution, which I have now pushed to emacs-27
as commit 747e0a2523. It will be part of the upcoming Emacs 27.1.
Best regards,
Stefan Kangas
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-13 17:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-12 22:18 bug#41221: Add some ediff faces to misterioso theme to improve readability Simon Lang
2020-05-13 1:16 ` Stefan Kangas
2020-05-13 6:24 ` Simon Lang
2020-05-13 17:51 ` Stefan Kangas
2020-05-13 14:45 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).