From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#41221: Add some ediff faces to misterioso theme to improve readability Date: Tue, 12 May 2020 18:16:55 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="108773"; mail-complaints-to="usenet@ciao.gmane.io" To: Simon Lang , 41221@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 13 03:20:32 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jYg4V-000SCq-QX for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 13 May 2020 03:20:31 +0200 Original-Received: from localhost ([::1]:52600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYg4U-0007w8-Pj for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 12 May 2020 21:20:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41364) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYg26-00037B-5H for bug-gnu-emacs@gnu.org; Tue, 12 May 2020 21:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45418) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jYg25-0004SO-Rk for bug-gnu-emacs@gnu.org; Tue, 12 May 2020 21:18:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jYg25-0008Jl-Nk for bug-gnu-emacs@gnu.org; Tue, 12 May 2020 21:18:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 May 2020 01:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41221 X-GNU-PR-Package: emacs Original-Received: via spool by 41221-submit@debbugs.gnu.org id=B41221.158933262231896 (code B ref 41221); Wed, 13 May 2020 01:18:01 +0000 Original-Received: (at 41221) by debbugs.gnu.org; 13 May 2020 01:17:02 +0000 Original-Received: from localhost ([127.0.0.1]:56964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYg18-0008IO-M2 for submit@debbugs.gnu.org; Tue, 12 May 2020 21:17:02 -0400 Original-Received: from mail-yb1-f172.google.com ([209.85.219.172]:44800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYg17-0008Hp-Eq for 41221@debbugs.gnu.org; Tue, 12 May 2020 21:17:01 -0400 Original-Received: by mail-yb1-f172.google.com with SMTP id o8so7961934ybc.11 for <41221@debbugs.gnu.org>; Tue, 12 May 2020 18:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :cc; bh=MNbm0ICK/gDR2379bGLStxdpFMkhTI6XJURWaRsb6Z0=; b=XO2OS7rSew0oPa6Ofu8I99ys3N4endo2f1tJX8XWgv00pweZzXFEkRcathuL1OxcI6 80dXJ8yyd7yKk/JPBUJTYBwuPuVXXEt8rn1TRiEqTjtvlTVmckVlSqQNNi+S2ULySw45 Z3/otynv2vjsHsC0Va7dahveaxo4crmlWGHRrrINtdVbpffgF60drqJOofuBmspmwiV9 Ou8Q+lm0R91/ofqMeQT7aIbXD6WfmIFu9Lr+POzMaVmfJXHbF2Mbjmdwf6m+C1w64d4s Nvs/otUK3c6OJeAp43AEHxpKKlpsS+Xd+TcF+DZqF4WfcULY7yTI8jgGr5SWxHtEiI6w C77A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=MNbm0ICK/gDR2379bGLStxdpFMkhTI6XJURWaRsb6Z0=; b=pwnIx71Jj/lAFOvLVm9cBquOBYMfWzWEt/h6JS8lq5y3i60HeGnHg6Lbst2oWbSnKv wQthrXo/PdoaXZvOFImmYzP9Ot28aHt/KaS4dqVA/iJA4AkoYOJfKIXjYm34fFLc9hyj xV8F2y91JyLoSBAU9wKUNH2eSPg+lbHgpWajkCRprxv/gwsujhsbrzvTA399OiwRB3ol aX8tOkN3muwgkeffwEQ8w3A+xb7DREbxLvc1QaNXyFMGOH/1KfJCmpqojuJFno3bHxea R/N6gg3M8YolD4FHY+5gFIVsMlcu0T/AHhhg5F1qSgd05c4yETPP2y/EY1QDwaRrmkp+ Lexg== X-Gm-Message-State: AGi0PuZrguf2sfrv/qgNg/Cqo+UTr0g3va97Pou/7UoRvNNfXiTvpjaA /xlBhWmGoIqmU41KQVINgrw6myp6PU3IPfFL6Ik= X-Google-Smtp-Source: APiQypIlHtDzne/BnWfI/1PePPaAspbb65woShBSCb0idpr5hW3skIDJ/jmAqyz8MY488nf/bqRXFqKuAkiPRpVYEKU= X-Received: by 2002:a25:c402:: with SMTP id u2mr37569194ybf.231.1589332615816; Tue, 12 May 2020 18:16:55 -0700 (PDT) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 12 May 2020 18:16:55 -0700 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180135 Archived-At: Simon Lang writes: > This fix adds ediff faces for > > ediff-even-diff-A > ediff-even-diff-B > ediff-odd-diff-A > ediff-odd-diff-B Thank you for your contribution. This is obviously broken in the theme as is, since you can't read the changed text in ediff. I tested it, and your change looks good to me. Eli, is the below acceptable for emacs-27? > diff --git a/etc/themes/misterioso-theme.el b/etc/themes/misterioso-theme.el > index 8161dbd9e9..030cb3dd75 100644 > --- a/etc/themes/misterioso-theme.el > +++ b/etc/themes/misterioso-theme.el > @@ -63,6 +63,11 @@ > `(button ((,class (:underline t)))) > `(link ((,class (:foreground "#59e9ff" :underline t)))) > `(link-visited ((,class (:foreground "#ed74cd" :underline t)))) > + ;; Ediff > + `(ediff-even-diff-A ((,class (:background "#1d2430")))) > + `(ediff-even-diff-B ((,class (:background "#1d2430")))) > + `(ediff-odd-diff-A ((,class (:background "#415160")))) > + `(ediff-odd-diff-B ((,class (:background "#415160")))) Best regards, Stefan Kangas