From: Simon Lang <Simon.lang@outlook.com>
To: Stefan Kangas <stefankangas@gmail.com>,
"41221@debbugs.gnu.org" <41221@debbugs.gnu.org>
Subject: bug#41221: Add some ediff faces to misterioso theme to improve readability
Date: Wed, 13 May 2020 06:24:19 +0000 [thread overview]
Message-ID: <DB8PR10MB27958AD0CEFC5D7762A935DF80BF0@DB8PR10MB2795.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CADwFkmmbj0qqdH6vwD1AQsATXuUtS2E1VY7M=SdKwZSiWVc_rg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1520 bytes --]
Hi,
sorry, I relaized that I forgot about
ediff-even-diff-C
ediff-odd-diff-C
I added these now (trivial change, same faces as the others).
Thank you!!
________________________________________
From: Stefan Kangas <stefankangas@gmail.com>
Sent: 13 May 2020 02:16
To: Simon Lang; 41221@debbugs.gnu.org
Cc: Eli Zaretskii
Subject: Re: bug#41221: Add some ediff faces to misterioso theme to improve readability
Simon Lang <simon.lang@outlook.com> writes:
> This fix adds ediff faces for
>
> ediff-even-diff-A
> ediff-even-diff-B
> ediff-odd-diff-A
> ediff-odd-diff-B
Thank you for your contribution.
This is obviously broken in the theme as is, since you can't read the
changed text in ediff. I tested it, and your change looks good to me.
Eli, is the below acceptable for emacs-27?
> diff --git a/etc/themes/misterioso-theme.el b/etc/themes/misterioso-theme.el
> index 8161dbd9e9..030cb3dd75 100644
> --- a/etc/themes/misterioso-theme.el
> +++ b/etc/themes/misterioso-theme.el
> @@ -63,6 +63,11 @@
> `(button ((,class (:underline t))))
> `(link ((,class (:foreground "#59e9ff" :underline t))))
> `(link-visited ((,class (:foreground "#ed74cd" :underline t))))
> + ;; Ediff
> + `(ediff-even-diff-A ((,class (:background "#1d2430"))))
> + `(ediff-even-diff-B ((,class (:background "#1d2430"))))
> + `(ediff-odd-diff-A ((,class (:background "#415160"))))
> + `(ediff-odd-diff-B ((,class (:background "#415160"))))
Best regards,
Stefan Kangas
[-- Attachment #2: 0001-Improve-ediff-readability-in-misterioso-theme.patch --]
[-- Type: application/octet-stream, Size: 1274 bytes --]
From bdd582487a02275d82bfda01ebb6d0605c0349d0 Mon Sep 17 00:00:00 2001
From: Simon Lang <simon.lang@outlook.com>
Date: Tue, 12 May 2020 22:54:52 +0100
Subject: [PATCH] Improve ediff readability in misterioso theme
* etc/themes/misterioso-theme.el: Add ediff faces
---
etc/themes/misterioso-theme.el | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/etc/themes/misterioso-theme.el b/etc/themes/misterioso-theme.el
index 8161dbd9e9..ff9af0c744 100644
--- a/etc/themes/misterioso-theme.el
+++ b/etc/themes/misterioso-theme.el
@@ -63,6 +63,13 @@
`(button ((,class (:underline t))))
`(link ((,class (:foreground "#59e9ff" :underline t))))
`(link-visited ((,class (:foreground "#ed74cd" :underline t))))
+ ;; Ediff
+ `(ediff-even-diff-A ((,class (:background "#1d2430"))))
+ `(ediff-even-diff-B ((,class (:background "#1d2430"))))
+ `(ediff-even-diff-C ((,class (:background "#1d2430"))))
+ `(ediff-odd-diff-A ((,class (:background "#415160"))))
+ `(ediff-odd-diff-B ((,class (:background "#415160"))))
+ `(ediff-odd-diff-C ((,class (:background "#415160"))))
;; Gnus faces
`(gnus-group-news-1 ((,class (:foreground "#ff4242" :weight bold))))
`(gnus-group-news-1-low ((,class (:foreground "#ff4242"))))
--
2.21.0 (Apple Git-122)
next prev parent reply other threads:[~2020-05-13 6:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 22:18 bug#41221: Add some ediff faces to misterioso theme to improve readability Simon Lang
2020-05-13 1:16 ` Stefan Kangas
2020-05-13 6:24 ` Simon Lang [this message]
2020-05-13 17:51 ` Stefan Kangas
2020-05-13 14:45 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB8PR10MB27958AD0CEFC5D7762A935DF80BF0@DB8PR10MB2795.EURPRD10.PROD.OUTLOOK.COM \
--to=simon.lang@outlook.com \
--cc=41221@debbugs.gnu.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).