From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Simon Lang Newsgroups: gmane.emacs.bugs Subject: bug#41221: Add some ediff faces to misterioso theme to improve readability Date: Wed, 13 May 2020 06:24:19 +0000 Message-ID: References: , Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="_002_DB8PR10MB27958AD0CEFC5D7762A935DF80BF0DB8PR10MB2795EURP_" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="78754"; mail-complaints-to="usenet@ciao.gmane.io" To: Stefan Kangas , "41221@debbugs.gnu.org" <41221@debbugs.gnu.org> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 13 08:36:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jYkzy-000KNq-Ot for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 13 May 2020 08:36:10 +0200 Original-Received: from localhost ([::1]:57080 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYkzx-0003hT-Qf for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 13 May 2020 02:36:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47500) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYkzq-0003gw-Ba for bug-gnu-emacs@gnu.org; Wed, 13 May 2020 02:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45653) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jYkzq-0000NM-0r for bug-gnu-emacs@gnu.org; Wed, 13 May 2020 02:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jYkzp-0000F2-T8 for bug-gnu-emacs@gnu.org; Wed, 13 May 2020 02:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Simon Lang Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 May 2020 06:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41221 X-GNU-PR-Package: emacs Original-Received: via spool by 41221-submit@debbugs.gnu.org id=B41221.1589351757919 (code B ref 41221); Wed, 13 May 2020 06:36:01 +0000 Original-Received: (at 41221) by debbugs.gnu.org; 13 May 2020 06:35:57 +0000 Original-Received: from localhost ([127.0.0.1]:57199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYkzl-0000Ek-8T for submit@debbugs.gnu.org; Wed, 13 May 2020 02:35:57 -0400 Original-Received: from mail-oln040092073032.outbound.protection.outlook.com ([40.92.73.32]:25071 helo=EUR04-HE1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYkoc-0008Iw-Mg for 41221@debbugs.gnu.org; Wed, 13 May 2020 02:24:27 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZG0mxJOoVC/rRX4hPIKyxrPRz+bfHmqGNs//nonmFgR0XCmCVUJgG8j6LhOB835CGl+nsYTWw4qcyrXpEKI/QaF2G9TMEQawImOV2Iv16CDpkTnnHhOZyNT4jR2b2PBosNmFQLkIOF0+LzCVHPK99ssAhy2YcwIyTuBb8rDGH//Uh2vffTXzok7TSE/5EUCvPkUZO/1b7Sci/NSjxgcot4bc/+hh4qBpcN04LltzpYXrRRz3sQ/EghVjEbPldiRHzH5SgiHJTb/Y10sPb/dyQbrN1i4Yd5ekddN2ZgJVwo/I5WiVjOw3qch6+yswaxyl47dqGmTfDOh1Dr3LW9z9PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c8qrjI1zuC2qw0tUCugRrA6i+NTDqG10ZCpq0T8KWCA=; b=SkH7Wd1Gc8wCpycaAZaxyf2d3O3t/cfC7jSJTICmiLvZQh1qklML46EX1nuJjlmtbalQ+JdorJYMtraLD+MgiQ0SZcgqR5vQ+9rTbmf5ZI0mmxhbYc+QaR0FDnX3jknFTMOqQjC2rv8MGWEdcVOAT3w/bWx++5es2+VIZK6mAhb9l/ZWtrAu3wZ/c+sWqIKU4gygsFJEu+uGEqEsdk7IzLS69kE7+7EUHwQ7EEQ0m9pogyORyNQiBiBL7V0raAnOYfhDwv6QV5DpYW8LBv9fL3/4EnpliJTJ4MUUdopeo3RJZL2S+Y32uTVEhWAkrZYeBXMB/VCAc3BMIDcIy5jVLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c8qrjI1zuC2qw0tUCugRrA6i+NTDqG10ZCpq0T8KWCA=; b=YCgX8LZvqy+UvFbXcylFqrDiLVvNaLjT8iMWFZUENemIZGnlUDtr3o9dW+PqmRdAprnqGYxODLhKdNOUyl2eVUYfTl9K02i5g+NU680zfEpP3yK4BLweOAbf9syMK6zwymH6XuOKN+J/mz+V+bVhGHQEtMXA2Pvn2JCqsD9iyIEJnsV+iwSgFvBoFRA9Oc56M4w9UkJpnR7p6BhTvtP8BDzluIPnhEoBSFjz5v6BDtUbDWR/9oqGqf0WQ8kr6PHii126vnh15LtlI+VzRI3lnZksAACT3kV5zv9hntn4Kv5nW2TVn6bn7ahNibnUhf7vZymJComfjzdnrzSj4bL6iQ== Original-Received: from VI1EUR04FT018.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0e::50) by VI1EUR04HT136.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0e::385) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.27; Wed, 13 May 2020 06:24:19 +0000 Original-Received: from DB8PR10MB2795.EURPRD10.PROD.OUTLOOK.COM (2a01:111:e400:7e0e::4d) by VI1EUR04FT018.mail.protection.outlook.com (2a01:111:e400:7e0e::359) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.27 via Frontend Transport; Wed, 13 May 2020 06:24:19 +0000 Original-Received: from DB8PR10MB2795.EURPRD10.PROD.OUTLOOK.COM ([fe80::e194:f64b:e547:e9ab]) by DB8PR10MB2795.EURPRD10.PROD.OUTLOOK.COM ([fe80::e194:f64b:e547:e9ab%6]) with mapi id 15.20.2979.033; Wed, 13 May 2020 06:24:19 +0000 Thread-Topic: bug#41221: Add some ediff faces to misterioso theme to improve readability Thread-Index: AQHWKKrWrbztuwWmM0ecwcexgeYYP6ilNwuAgABVE80= In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: yes x-incomingtopheadermarker: OriginalChecksum:87BFB2EB8ECF01C1EF218A1D7854D2BF410BADCF3833B11C6F9C42B1EF5741F6; UpperCasedChecksum:B6BEBA457EBA0B244706D09E848B306360898FE01BF289799F69AC8747CCFC4E; SizeAsReceived:7183; Count:46 x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [L3QSyA2SaWa8GVpN6+rgC5hgHMEJqCn9] x-ms-publictraffictype: Email x-incomingheadercount: 46 x-eopattributedmessage: 0 x-ms-office365-filtering-correlation-id: 978a62a1-47a9-454f-f10b-08d7f706451c x-ms-traffictypediagnostic: VI1EUR04HT136: x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wLfbPrWZxi5NDEEDA8eb56Xgo0yXKwXj/yf2YAUbJApdk4G6381LO5WicYyJbMheV2Tfb6Taxk1Okq0d6IXT9VJhlj/0YeT9yHAHdhCTUxIZ20KEBweOtSwRWeGIZea6pRjIru1m6Wxd/bJHF9oloUGTfSMjtWn/4VsRl/9F+dUyaoR/YuKtCOSPHT7sz/FHuE+yrtoYxPJYnmYaOG0eWw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:0; SRV:; IPV:NLI; SFV:NSPM; H:DB8PR10MB2795.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFTY:; SFS:; DIR:OUT; SFP:1901; x-ms-exchange-antispam-messagedata: ZsgsoUvS1Zbp6I7ak+noEBKpVZENoR442QcjNWwUA27hVQtuPLGhl8Vopc+z97iYjdboE8qFGJHE4Il4r4FLLJN/+7PZMTqpxjIsRN8/O3tS1jZTQxfRbXyXB+zTXgvL5rCbZJ1SLsFU4EGDn45HGA== x-ms-exchange-transport-forked: True X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-Network-Message-Id: 978a62a1-47a9-454f-f10b-08d7f706451c X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2020 06:24:19.7203 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1EUR04HT136 X-Mailman-Approved-At: Wed, 13 May 2020 02:35:55 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180144 Archived-At: --_002_DB8PR10MB27958AD0CEFC5D7762A935DF80BF0DB8PR10MB2795EURP_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi,=0A= =0A= sorry, I relaized that I forgot about =0A= =0A= ediff-even-diff-C=0A= ediff-odd-diff-C=0A= =0A= I added these now (trivial change, same faces as the others).=0A= =0A= Thank you!!=0A= =0A= ________________________________________=0A= From: Stefan Kangas =0A= Sent: 13 May 2020 02:16=0A= To: Simon Lang; 41221@debbugs.gnu.org=0A= Cc: Eli Zaretskii=0A= Subject: Re: bug#41221: Add some ediff faces to misterioso theme to improve= readability=0A= =0A= Simon Lang writes:=0A= =0A= > This fix adds ediff faces for=0A= >=0A= > ediff-even-diff-A=0A= > ediff-even-diff-B=0A= > ediff-odd-diff-A=0A= > ediff-odd-diff-B=0A= =0A= Thank you for your contribution.=0A= =0A= This is obviously broken in the theme as is, since you can't read the=0A= changed text in ediff. I tested it, and your change looks good to me.=0A= =0A= Eli, is the below acceptable for emacs-27?=0A= =0A= > diff --git a/etc/themes/misterioso-theme.el b/etc/themes/misterioso-theme= .el=0A= > index 8161dbd9e9..030cb3dd75 100644=0A= > --- a/etc/themes/misterioso-theme.el=0A= > +++ b/etc/themes/misterioso-theme.el=0A= > @@ -63,6 +63,11 @@=0A= > `(button ((,class (:underline t))))=0A= > `(link ((,class (:foreground "#59e9ff" :underline t))))=0A= > `(link-visited ((,class (:foreground "#ed74cd" :underline t))))=0A= > + ;; Ediff=0A= > + `(ediff-even-diff-A ((,class (:background "#1d2430"))))=0A= > + `(ediff-even-diff-B ((,class (:background "#1d2430"))))=0A= > + `(ediff-odd-diff-A ((,class (:background "#415160"))))=0A= > + `(ediff-odd-diff-B ((,class (:background "#415160"))))=0A= =0A= Best regards,=0A= Stefan Kangas=0A= --_002_DB8PR10MB27958AD0CEFC5D7762A935DF80BF0DB8PR10MB2795EURP_ Content-Type: application/octet-stream; name="0001-Improve-ediff-readability-in-misterioso-theme.patch" Content-Description: 0001-Improve-ediff-readability-in-misterioso-theme.patch Content-Disposition: attachment; filename="0001-Improve-ediff-readability-in-misterioso-theme.patch"; size=1274; creation-date="Wed, 13 May 2020 06:23:44 GMT"; modification-date="Wed, 13 May 2020 06:23:44 GMT" Content-Transfer-Encoding: base64 RnJvbSBiZGQ1ODI0ODdhMDIyNzVkODJiZmRhMDFlYmI2ZDA2MDVjMDM0OWQwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTaW1vbiBMYW5nIDxzaW1vbi5sYW5nQG91dGxvb2suY29tPgpE YXRlOiBUdWUsIDEyIE1heSAyMDIwIDIyOjU0OjUyICswMTAwClN1YmplY3Q6IFtQQVRDSF0gSW1w cm92ZSBlZGlmZiByZWFkYWJpbGl0eSBpbiBtaXN0ZXJpb3NvIHRoZW1lCgoqIGV0Yy90aGVtZXMv bWlzdGVyaW9zby10aGVtZS5lbDogQWRkIGVkaWZmIGZhY2VzCi0tLQogZXRjL3RoZW1lcy9taXN0 ZXJpb3NvLXRoZW1lLmVsIHwgNyArKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRpb25z KCspCgpkaWZmIC0tZ2l0IGEvZXRjL3RoZW1lcy9taXN0ZXJpb3NvLXRoZW1lLmVsIGIvZXRjL3Ro ZW1lcy9taXN0ZXJpb3NvLXRoZW1lLmVsCmluZGV4IDgxNjFkYmQ5ZTkuLmZmOWFmMGM3NDQgMTAw NjQ0Ci0tLSBhL2V0Yy90aGVtZXMvbWlzdGVyaW9zby10aGVtZS5lbAorKysgYi9ldGMvdGhlbWVz L21pc3Rlcmlvc28tdGhlbWUuZWwKQEAgLTYzLDYgKzYzLDEzIEBACiAgICBgKGJ1dHRvbiAoKCxj bGFzcyAoOnVuZGVybGluZSB0KSkpKQogICAgYChsaW5rICgoLGNsYXNzICg6Zm9yZWdyb3VuZCAi IzU5ZTlmZiIgOnVuZGVybGluZSB0KSkpKQogICAgYChsaW5rLXZpc2l0ZWQgKCgsY2xhc3MgKDpm b3JlZ3JvdW5kICIjZWQ3NGNkIiA6dW5kZXJsaW5lIHQpKSkpCisgICA7OyBFZGlmZgorICAgYChl ZGlmZi1ldmVuLWRpZmYtQSAoKCxjbGFzcyAoOmJhY2tncm91bmQgIiMxZDI0MzAiKSkpKQorICAg YChlZGlmZi1ldmVuLWRpZmYtQiAoKCxjbGFzcyAoOmJhY2tncm91bmQgIiMxZDI0MzAiKSkpKQor ICAgYChlZGlmZi1ldmVuLWRpZmYtQyAoKCxjbGFzcyAoOmJhY2tncm91bmQgIiMxZDI0MzAiKSkp KQorICAgYChlZGlmZi1vZGQtZGlmZi1BICgoLGNsYXNzICg6YmFja2dyb3VuZCAiIzQxNTE2MCIp KSkpCisgICBgKGVkaWZmLW9kZC1kaWZmLUIgKCgsY2xhc3MgKDpiYWNrZ3JvdW5kICIjNDE1MTYw IikpKSkKKyAgIGAoZWRpZmYtb2RkLWRpZmYtQyAoKCxjbGFzcyAoOmJhY2tncm91bmQgIiM0MTUx NjAiKSkpKQogICAgOzsgR251cyBmYWNlcwogICAgYChnbnVzLWdyb3VwLW5ld3MtMSAoKCxjbGFz cyAoOmZvcmVncm91bmQgIiNmZjQyNDIiIDp3ZWlnaHQgYm9sZCkpKSkKICAgIGAoZ251cy1ncm91 cC1uZXdzLTEtbG93ICgoLGNsYXNzICg6Zm9yZWdyb3VuZCAiI2ZmNDI0MiIpKSkpCi0tIAoyLjIx LjAgKEFwcGxlIEdpdC0xMjIpCgo= --_002_DB8PR10MB27958AD0CEFC5D7762A935DF80BF0DB8PR10MB2795EURP_--