From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#3746: M-r in comint mode should use isearch Date: Mon, 23 Nov 2009 22:39:51 +0200 Organization: JURTA Message-ID: <87zl6dxkiw.fsf@mail.jurta.org> References: <200907031326.n63DQfPA027629@godzilla.ics.uci.edu> <87zlblpajc.fsf@mail.jurta.org> <200907051503.n65F3fDv003169@godzilla.ics.uci.edu> <87ab3hxprg.fsf@mail.jurta.org> <200907070121.n671LmLt029754@godzilla.ics.uci.edu> <87skh8ynnm.fsf@mail.jurta.org> <200907082349.n68NnKRj025444@godzilla.ics.uci.edu> <87ljmxo5pw.fsf@mail.jurta.org> <877htmbj2s.fsf@mail.jurta.org> Reply-To: Juri Linkov , 3746@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1259011427 17149 80.91.229.12 (23 Nov 2009 21:23:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 23 Nov 2009 21:23:47 +0000 (UTC) Cc: 3746@emacsbugs.donarmstrong.com, Dan Nicolaescu To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 23 22:23:39 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NCgNl-0002po-Im for geb-bug-gnu-emacs@m.gmane.org; Mon, 23 Nov 2009 22:23:38 +0100 Original-Received: from localhost ([127.0.0.1]:52561 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NCgNl-0000ZS-3f for geb-bug-gnu-emacs@m.gmane.org; Mon, 23 Nov 2009 16:23:37 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NCg8A-00021X-Jp for bug-gnu-emacs@gnu.org; Mon, 23 Nov 2009 16:07:30 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NCg85-0001z0-3i for bug-gnu-emacs@gnu.org; Mon, 23 Nov 2009 16:07:29 -0500 Original-Received: from [199.232.76.173] (port=60029 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NCg84-0001yp-Uo for bug-gnu-emacs@gnu.org; Mon, 23 Nov 2009 16:07:24 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:37937) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NCg84-0007qf-BL for bug-gnu-emacs@gnu.org; Mon, 23 Nov 2009 16:07:24 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nANL7Lr7022250; Mon, 23 Nov 2009 13:07:22 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id nANKt6l3020521; Mon, 23 Nov 2009 12:55:06 -0800 Resent-Date: Mon, 23 Nov 2009 12:55:06 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Juri Linkov Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Mon, 23 Nov 2009 20:55:06 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 3746 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 3746-submit@emacsbugs.donarmstrong.com id=B3746.125900931719951 (code B ref 3746); Mon, 23 Nov 2009 20:55:06 +0000 Original-Received: (at 3746) by emacsbugs.donarmstrong.com; 23 Nov 2009 20:48:37 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from mx2.starman.ee (smtp-out4.starman.ee [85.253.0.6]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id nANKmZ1Q019944 for <3746@emacsbugs.donarmstrong.com>; Mon, 23 Nov 2009 12:48:36 -0800 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Original-Received: from mail.starman.ee (82.131.34.24.cable.starman.ee [82.131.34.24]) by mx2.starman.ee (Postfix) with ESMTP id DE6413F40D9; Mon, 23 Nov 2009 22:48:29 +0200 (EET) In-Reply-To: (Stefan Monnier's message of "Thu, 19 Nov 2009 16:12:31 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Mon, 23 Nov 2009 16:07:29 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:32859 Archived-At: >> Maybe we should change `comint-previous-input' and `comint-next-input' >> to signal an error at the beginning/end of the history ring? > > That sounds fine to me, but pleast double check all uses of those > functions to make sure it won't introduce other problems. To avoid possible problems, I installed a non-intrusive implementation that signals an error inside `comint-history-isearch-search' before calling `comint-next-input' or `comint-previous-input'. -- Juri Linkov http://www.jurta.org/emacs/