bug#50881: C-h C-s leads to empty " *Metahelp*" buffer

bug#50881: C-h C-s leads to empty " *Metahelp*" buffer

[Stefan Kangas]

Severity: minor

Steps to reproduce:
0. emacs -Q
1. C-h C-s f RET

You are now looking at an empty " *Metahelp*" buffer.

My expectation is that the help screen gets displayed before the search
starts.

bug#50881: C-h C-s leads to empty " *Metahelp*" buffer

[Juri Linkov]

> Steps to reproduce:
> 0. emacs -Q
> 1. C-h C-s f RET
>
> You are now looking at an empty " *Metahelp*" buffer.
>
> My expectation is that the help screen gets displayed before the search
> starts.

I tried to reproduce this, then typed 'C-h C-h', and it highlights
matching parens on the first line.  This not only makes no sense,
but also distracting for users seeking help.
'show-paren-mode' should be disabled in all read-only buffers.

bug#50881: C-h C-s leads to empty " *Metahelp*" buffer

[Lars Ingebrigtsen]

Stefan Kangas <stefan@marxist.se> writes:

> Severity: minor
>
> Steps to reproduce:
> 0. emacs -Q
> 1. C-h C-s f RET
>
> You are now looking at an empty " *Metahelp*" buffer.
>
> My expectation is that the help screen gets displayed before the search
> starts.

Yup.  And the doc string isn't very helpful:

Search forward "help window".

Which sounds like it's talking about the *Help* window, not the `C-h
C-h' help-for-help window.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#50881: C-h C-s leads to empty " *Metahelp*" buffer

[Lars Ingebrigtsen]

Juri Linkov <juri@linkov.net> writes:

> I tried to reproduce this, then typed 'C-h C-h', and it highlights
> matching parens on the first line.  This not only makes no sense,
> but also distracting for users seeking help.
> 'show-paren-mode' should be disabled in all read-only buffers.

Yup.  Perhaps disable it in `special-mode'?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#50881: C-h C-s leads to empty " *Metahelp*" buffer

[Stefan Kangas]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Juri Linkov <juri@linkov.net> writes:
>
>> I tried to reproduce this, then typed 'C-h C-h', and it highlights
>> matching parens on the first line.  This not only makes no sense,
>> but also distracting for users seeking help.
>> 'show-paren-mode' should be disabled in all read-only buffers.
>
> Yup.  Perhaps disable it in `special-mode'?

Sounds good to me, but are there any special-modes where it is useful?

Perhaps we can just disable it in `special-mode', and if we think of
some modes where it seems really useful, we re-enable it for them?

bug#50881: C-h C-s leads to empty " *Metahelp*" buffer

[Eli Zaretskii]

> From: Juri Linkov <juri@linkov.net>
> Date: Wed, 29 Sep 2021 09:54:20 +0300
> Cc: 50881@debbugs.gnu.org
> 
> I tried to reproduce this, then typed 'C-h C-h', and it highlights
> matching parens on the first line.  This not only makes no sense,

Please elaborate why it makes no sense.

> but also distracting for users seeking help.
> 'show-paren-mode' should be disabled in all read-only buffers.

If the problem is with *Help* and other documentation buffers, why
turn it off in _all_ read-only buffers?  The latter is a much broader
category.  For example, debugging Lisp with Edebug makes the source
buffer read-only.

bug#50881: C-h C-s leads to empty " *Metahelp*" buffer

[Lars Ingebrigtsen]

Stefan Kangas <stefan@marxist.se> writes:

> Sounds good to me, but are there any special-modes where it is useful?
>
> Perhaps we can just disable it in `special-mode', and if we think of
> some modes where it seems really useful, we re-enable it for them?

I can't think of any special modes where it's useful, so I think that
sounds like a plan.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#50881: C-h C-s leads to empty " *Metahelp*" buffer

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Yup.  And the doc string isn't very helpful:
>
> Search forward "help window".
>
> Which sounds like it's talking about the *Help* window, not the `C-h
> C-h' help-for-help window.

I've now fixed the doc string, and I've made `C-h C-s' just signal an
error if the Metahelp buffer doesn't exist.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#50881: C-h C-s leads to empty " *Metahelp*" buffer

[Stefan Kangas]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I've now fixed the doc string, and I've made `C-h C-s' just signal an
> error if the Metahelp buffer doesn't exist.

Thanks.

bug#50881: C-h C-s leads to empty " *Metahelp*" buffer

[Juri Linkov]

>> 'show-paren-mode' should be disabled in all read-only buffers.
>
> If the problem is with *Help* and other documentation buffers, why
> turn it off in _all_ read-only buffers?  The latter is a much broader
> category.  For example, debugging Lisp with Edebug makes the source
> buffer read-only.

Maybe with Edebug it makes sense, I don't know because I immediately
disabled it globally, and noticed the problem only while trying
to reproduce the reported bug with 'emacs -Q'.

bug#50881: [External] : bug#50881: C-h C-s leads to empty " *Metahelp*" buffer

[Drew Adams]

> > 'show-paren-mode' should be disabled in all read-only buffers.
> 
> Yup.  Perhaps disable it in `special-mode'?

Huh?  Why would we disable it in all read-only buffers?
That would be a backward-incompatible change (and for
the worse).  I count on it in read-only buffers.

bug#50881: C-h C-s leads to empty " *Metahelp*" buffer

[Eli Zaretskii]

> From: Juri Linkov <juri@linkov.net>
> Cc: stefan@marxist.se,  50881@debbugs.gnu.org
> Date: Wed, 29 Sep 2021 19:58:08 +0300
> 
> >> 'show-paren-mode' should be disabled in all read-only buffers.
> >
> > If the problem is with *Help* and other documentation buffers, why
> > turn it off in _all_ read-only buffers?  The latter is a much broader
> > category.  For example, debugging Lisp with Edebug makes the source
> > buffer read-only.
> 
> Maybe with Edebug it makes sense, I don't know because I immediately
> disabled it globally, and noticed the problem only while trying
> to reproduce the reported bug with 'emacs -Q'.

That's the problem with thinking your personal preferences are
definitely good for everyone else.  They aren't.

Please, people, just this once, let it go.  We just flipped this
setting on; please let the dust settle at least for a while before you
come up with reasons why it should be turned back off.  It's very easy
to turn it off in your customizations, so if you cannot tolerate it,
just turn it off and move on.  Let's limit any changes related to
show-paren-mode to fixing bugs, like that recursive-load problem
someone just reported.  Everything else let's please filter out.

bug#50881: [External] : bug#50881: C-h C-s leads to empty " *Metahelp*" buffer

[Drew Adams]

> That's the problem with thinking your personal preferences are
> definitely good for everyone else.  They aren't.

100% agreement, FWIW.  And that goes also for
the descendant bugs, 50894 and 50895.

bug#50881: C-h C-s leads to empty " *Metahelp*" buffer

[Juri Linkov]

> That's the problem with thinking your personal preferences are
> definitely good for everyone else.  They aren't.

This is not a personal preference.  I looked through the eyes of
a beginner who types 'C-h C-h' to get help, and the first thing
the user sees is that parens are highlighted on the first line:

  (Type <PageDown> or <PageUp> to scroll, C-s to search, or q to exit.)

This is what we trying to tell the user with this information:

  Look, it's very important that the first paren on the first line
  matches its closing paren, so we highlighted these parens for you.

bug#50881: [External] : bug#50881: C-h C-s leads to empty " *Metahelp*" buffer

[Drew Adams]

> > That's the problem with thinking your personal preferences are
> > definitely good for everyone else.  They aren't.
> 
> This is not a personal preference.  I looked through the eyes of
> a beginner who types 'C-h C-h' to get help, and the first thing
> the user sees is that parens are highlighted on the first line:
> 
>   (Type <PageDown> or <PageUp> to scroll, C-s to search, or q to exit.)
> 
> This is what we trying to tell the user with this information:
> 
>   Look, it's very important that the first paren on the first line
>   matches its closing paren, so we highlighted these parens for you.

Mountain out of a mole hill?

Or maybe the new-user takeaway is that Emacs highlights
matching parens by default.  ("Hey, that can be useful!")

bug#50881: C-h C-s leads to empty " *Metahelp*" buffer

[Eli Zaretskii]

> From: Juri Linkov <juri@linkov.net>
> Cc: stefan@marxist.se,  50881@debbugs.gnu.org
> Date: Wed, 29 Sep 2021 22:20:10 +0300
> 
> > That's the problem with thinking your personal preferences are
> > definitely good for everyone else.  They aren't.
> 
> This is not a personal preference.  I looked through the eyes of
> a beginner

I don't think we can pretend to look at this through the eyes of a
beginner.  We are too far from that, all of us here.

> who types 'C-h C-h' to get help, and the first thing
> the user sees is that parens are highlighted on the first line:
> 
>   (Type <PageDown> or <PageUp> to scroll, C-s to search, or q to exit.)

Yes, and I see no problem with this.  So yes, it is personal
preference of yours.  Let's hear the beginners themselves when Emacs
28.1 hits the street.  Until then, let's stand by our own decision: to
enable this mode by default.