* bug#57630: [PATCH] emms.el: Maintain original player list order when selecting a player
@ 2022-09-06 18:54 Morgan Smith
2022-09-06 20:42 ` Lars Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: Morgan Smith @ 2022-09-06 18:54 UTC (permalink / raw)
To: 57630
[-- Attachment #1: Type: text/plain, Size: 240 bytes --]
Hello!
I'm not sure where to send emms patches so I guess I'll send them here.
I struggled for quite a while to figure out why emms was using the
second player in my config instead of the first. This fixes that issue.
Thanks,
Morgan
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-emms.el-Maintain-original-player-list-order-when-sel.patch --]
[-- Type: text/x-patch, Size: 920 bytes --]
From e9f3912066945afdf3ffb8e0c8fd35a21dfe099d Mon Sep 17 00:00:00 2001
From: Morgan Smith <Morgan.J.Smith@outlook.com>
Date: Tue, 6 Sep 2022 14:40:33 -0400
Subject: [PATCH] emms.el: Maintain original player list order when selecting a
player
(emms-players-for): Maintain original player list order when selecting a player
This allows users to prioritize players using the order of `emms-player-list'
as stated in various comments and documentation.
---
emms.el | 1 +
1 file changed, 1 insertion(+)
diff --git a/emms.el b/emms.el
index fccecb9..c22b295 100644
--- a/emms.el
+++ b/emms.el
@@ -1484,6 +1484,7 @@ If the track can be played by more than one player, call
(when (funcall (emms-player-get player 'playablep) track)
(push player players)))
emms-player-list)
+ (nreverse players)
(if (< 1 (length players))
(emms-players-preference track players)
(car players))))
--
2.37.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* bug#57630: [PATCH] emms.el: Maintain original player list order when selecting a player
2022-09-06 18:54 bug#57630: [PATCH] emms.el: Maintain original player list order when selecting a player Morgan Smith
@ 2022-09-06 20:42 ` Lars Ingebrigtsen
2022-09-06 21:43 ` Yoni Rabkin
2022-09-06 21:45 ` Yoni Rabkin
0 siblings, 2 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2022-09-06 20:42 UTC (permalink / raw)
To: Morgan Smith; +Cc: 57630, Yoni Rabkin
Morgan Smith <Morgan.J.Smith@outlook.com> writes:
> I'm not sure where to send emms patches so I guess I'll send them here.
>
> I struggled for quite a while to figure out why emms was using the
> second player in my config instead of the first. This fixes that issue.
The maintainer of emms is Yoni Rabkin; now added to the CCs.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#57630: [PATCH] emms.el: Maintain original player list order when selecting a player
2022-09-06 20:42 ` Lars Ingebrigtsen
@ 2022-09-06 21:43 ` Yoni Rabkin
2022-09-06 22:03 ` Lars Ingebrigtsen
2022-09-06 22:08 ` Stefan Kangas
2022-09-06 21:45 ` Yoni Rabkin
1 sibling, 2 replies; 6+ messages in thread
From: Yoni Rabkin @ 2022-09-06 21:43 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: Morgan Smith, 57630
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Morgan Smith <Morgan.J.Smith@outlook.com> writes:
>
>> I'm not sure where to send emms patches so I guess I'll send them here.
>>
>> I struggled for quite a while to figure out why emms was using the
>> second player in my config instead of the first. This fixes that issue.
>
> The maintainer of emms is Yoni Rabkin; now added to the CCs.
Addressed in the Savannah git repo and will appear in the next
release. This issue can be closed.
The way to select a player is via the preferences system in
emms.el. However, I see no reason not to flip the order in which the
players are collected if that is of use to someone.
I went ahead and made that change, but using a different method.
--
"Cut your own wood and it will warm you twice"
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#57630: [PATCH] emms.el: Maintain original player list order when selecting a player
2022-09-06 20:42 ` Lars Ingebrigtsen
2022-09-06 21:43 ` Yoni Rabkin
@ 2022-09-06 21:45 ` Yoni Rabkin
1 sibling, 0 replies; 6+ messages in thread
From: Yoni Rabkin @ 2022-09-06 21:45 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: Morgan Smith, 57630
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Morgan Smith <Morgan.J.Smith@outlook.com> writes:
>
>> I'm not sure where to send emms patches so I guess I'll send them here.
Please send further correspondence to the emms mailing list at:
emms-help@gnu.org
--
"Cut your own wood and it will warm you twice"
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#57630: [PATCH] emms.el: Maintain original player list order when selecting a player
2022-09-06 21:43 ` Yoni Rabkin
@ 2022-09-06 22:03 ` Lars Ingebrigtsen
2022-09-06 22:08 ` Stefan Kangas
1 sibling, 0 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2022-09-06 22:03 UTC (permalink / raw)
To: Yoni Rabkin; +Cc: Morgan Smith, 57630
Yoni Rabkin <yoni@rabkins.net> writes:
> Addressed in the Savannah git repo and will appear in the next
> release. This issue can be closed.
Thanks; closing this issue, then.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#57630: [PATCH] emms.el: Maintain original player list order when selecting a player
2022-09-06 21:43 ` Yoni Rabkin
2022-09-06 22:03 ` Lars Ingebrigtsen
@ 2022-09-06 22:08 ` Stefan Kangas
1 sibling, 0 replies; 6+ messages in thread
From: Stefan Kangas @ 2022-09-06 22:08 UTC (permalink / raw)
To: Yoni Rabkin, Lars Ingebrigtsen; +Cc: Morgan Smith, 57630-done
Yoni Rabkin <yoni@rabkins.net> writes:
> This issue can be closed.
Done.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-06 22:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-06 18:54 bug#57630: [PATCH] emms.el: Maintain original player list order when selecting a player Morgan Smith
2022-09-06 20:42 ` Lars Ingebrigtsen
2022-09-06 21:43 ` Yoni Rabkin
2022-09-06 22:03 ` Lars Ingebrigtsen
2022-09-06 22:08 ` Stefan Kangas
2022-09-06 21:45 ` Yoni Rabkin
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).