From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Morgan Smith Newsgroups: gmane.emacs.bugs Subject: bug#57630: [PATCH] emms.el: Maintain original player list order when selecting a player Date: Tue, 06 Sep 2022 14:54:15 -0400 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7406"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: 57630@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 06 20:55:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVdj8-0001oi-OL for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Sep 2022 20:55:14 +0200 Original-Received: from localhost ([::1]:52868 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVdj7-0007P3-8v for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Sep 2022 14:55:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51566) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVdiw-0007Ot-OU for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2022 14:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35746) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oVdiw-0008Ni-9y for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2022 14:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oVdiv-0006cs-RI for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2022 14:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Morgan Smith Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Sep 2022 18:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 57630 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.166249047025427 (code B ref -1); Tue, 06 Sep 2022 18:55:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 Sep 2022 18:54:30 +0000 Original-Received: from localhost ([127.0.0.1]:52678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVdiQ-0006c3-Gy for submit@debbugs.gnu.org; Tue, 06 Sep 2022 14:54:30 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:44548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVdiK-0006bq-7w for submit@debbugs.gnu.org; Tue, 06 Sep 2022 14:54:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVdiK-0007MZ-1u for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2022 14:54:24 -0400 Original-Received: from mail-bn8nam11olkn2010.outbound.protection.outlook.com ([40.92.20.10]:24206 helo=NAM11-BN8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVdiH-0008Jp-7t for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2022 14:54:22 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NeJ5RkbzMPm/nnTtSshtFMOYfkY7Q8psuYJxjStGEQDtc0aRmkFxTwqZ2IMjMQ4gFe1/Km7AzWu8ijWC8TkuQl3vSbZH0WQnrN3gI8zCzIvs93+sr8dGqbKrodi7utiMejOyhsUr6rZSXmjMzZgtdViOObzhGQdi52ae/LZ7Xn7zzjez8rLw2wXQIo42rve+hAvM0Z276ulZ3eyAg9R02fp8H2RkYtoITzbL3C4eImvY/40Y0L8Sljk6VGacH1V3tIMo7byE/TwTZrLA5PXg8z4sXilbZ0ng6CvGU8bxv/W3xGDJCw3DX299WH1QwdZS8rGXHkG3ihxYD/wm/JcLMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AOEQndQg6kMSRbTa56Fo2O0XWZRBPrSJAgw6ZCtQEqY=; b=JeVxQOISvETa3JLXZ9npUctkCZ5bvUQUC845o666NNdQ1YWagpoNEuHUAkFd/MsF0CxczdPMpRjgbzVNGghhwZeJYqKW37TwWxNNqbwnKJiCnWETlEhSSFMM+s4vhS1mTuFmW/hQdvpxD0iULHQ7Rau85QjYlwPHbk+9aZFnNq11kiza3vIPAf/yEzBJf8U1s04xahVRQSx0gAj9OQSxvs7bcdbOPwljkvQazLg9YQjFWfLMiTKeIPV6mAPjWUKIv7mNifu/MPCHHNlkC9n8LrHcayykmx3NdPIXVUttAsb9khB+bEc2XzDtrkh1nu7iku65SojVklnd+eaB4l8POA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AOEQndQg6kMSRbTa56Fo2O0XWZRBPrSJAgw6ZCtQEqY=; b=RPHx+AQOBfyXzdh3o604+IOyQF+Z17A+XVSS0TqIg/Kqt0Tevl1hMK6s6xM6QdW4qKuG/2fBgIdu06lJtOvTINzkE5M6Xlw4AKHC0dqcjgWlTa/ny0Ac6msbO2KZYAv9eAzHM4mk1463kQzLMtKWEDqk8RA6tiUy3hrPtcMDJxXuths0U5J4XVj5g+qOzx9bcwLstCF1tPhg4UNI24MxC9TceR2bR71HHEzN10Mg/ApaJDwOR8dcUh5FjlyddfQqWMt7BU77lyoN3FtacpSivxmCbMcWyYzN9Cz4m4LUtVlytraqdKl9JoE3ENSCvcTQEgXJ0tOR+IUwqvn6xzFrXQ== Original-Received: from DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) by MW5PR03MB6879.namprd03.prod.outlook.com (2603:10b6:303:1c9::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.12; Tue, 6 Sep 2022 18:54:18 +0000 Original-Received: from DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::1cf8:e25b:a93b:ffac]) by DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::1cf8:e25b:a93b:ffac%6]) with mapi id 15.20.5588.018; Tue, 6 Sep 2022 18:54:18 +0000 X-TMN: [LQYNPr9cajngoEIAymvNDtIU997QwQim] X-ClientProxiedBy: YQBPR0101CA0319.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:6c::19) To DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) X-Microsoft-Original-Message-ID: <87fsh4pc4o.fsf@outlook.com> X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ae8615e9-2932-44cc-df88-08da903933c3 X-MS-TrafficTypeDiagnostic: MW5PR03MB6879:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rlb+MibMubXFFNMoNgf4q5Dpug8NLzwncUjd4rYoXh4ECoaBgr+Z08qCd+IX945haPKrr0W5QWuV6yQ40Oo1zDMGwtLeGt6IBHQB/I4Gl4oiZKB0FGZhF1V7veTuWB3vHbVZg9FQBC2pAisUakHYmrdliqPOi3aiwRBrqzkipxShnWNuiFqiYne6mwtOGJ6lD7boAdVN59ATe82uuohpab31BJJYHVeCC+H34a8/1cBHhBEwU1cqBJsnywAW6LZDwvqA+1fDROLg6wJPkYglKyHaNMGd26NNNXkMDfAuGN6CVCXijNjFZjzOQByAwbWrzp8D6+0Q+VFgecuKYnMRI8fxy21sIFTCgi581WyVHGPyUImzXM5EqekSv4rHnnDGUP4ctAhN3zBzMcY9vI/5iaOYutGRU3AWsFZjc9xUr0VbGovcjs3gLI56g2NU5jlLgKyeBoHkAqr5inP2wAImMnXMLYZHmGkoledTnVaxXxKtPGpKJUNXfhQJSKXmCJdAGlCxwUwbTrfWiSe+gEQ+8DO+Xn14QWVgDd8vL1BFZp2lkf+21yE/F6S0lVd7JRkxXbL/j7LbB6i/oJNTo45RRXNQOFNqKgr25dD70vjP1XBTVB06gX9YN/5KhcK0VVF+bKqie3FK5G7+/K2iroKXiw== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 3gRD5Q4l/iS5SkyC0B8/c22XkMzC9OT6/3FURjELvexNE00bQLARRkLKn5Mp3UCOxAuQvDOcFsDpz91tZH47s/rHdCmhA0kdzyHiYuFqQru6l1Id0R4hdLHkjCelrLsP+s/UWEEXilImnSN9Y0YA8GLT80o2Rd5dtDEZUvX+16q+haBYWMwkG+W4oxs7zC1ppdxYGbNJtVhEBJEq6/zn7Xzk2rSoNFjjncV47qRnSontzOHQsmzYKgOTwL1uh9QLM/jywVbqFpRD2qix1k1PQ4C/lr1p9NdfuZFi2vMAArBGK9/023rvirINAPT64P3jjN4EnzrOuNLel0r+q8FJvBQn0ONxMz++q2YV+LGKjHjmZPx31ZB5fJPYIqWXD6fVBwWl6FIN8CvSUMuxBIy1keJENoy3bF7Or536Q3aCvwA3pKnOFCJNcLq65+CbrZJr9cpzQR1FBL9RB4g7CqgQRAPeBAdojKecUgqf+t6grV7wNBIz0ixN5QzAKrPhqpNC1Fq7aeFdGGm/phMhHmXLH2wfISJhIIbNJUciiuARx/NmhjNKlDRr7G963tuB9ANfoj1ohmB9JDj7hyU5gQiQwU4rQMMiT2vJWT5n9oMWL//vF4pBJpTiv/r128X++5SAoTEEJdOy7VRFWVoLdbQdpQZ9L//Hr7auNAc355UmV+m1Kwjm68DSv3qzEj+0mupqGj1fXRwm8L8DEBkC9E8z+KSCgWBQ6Mjgrv2n5joOmIHf9EOfUHwXF42jlt qsJFjqw/VJqjSpWlxA1u25zI8e/xnfGATZpFxleKasbBeV1UFDEJvYitfI1CsqMTeODmXjv+4A9dsVHNEJpH6OiNJjldwUVrbG X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae8615e9-2932-44cc-df88-08da903933c3 X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3163.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 18:54:18.5325 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR03MB6879 Received-SPF: pass client-ip=40.92.20.10; envelope-from=Morgan.J.Smith@outlook.com; helo=NAM11-BN8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241698 Archived-At: --=-=-= Content-Type: text/plain Hello! I'm not sure where to send emms patches so I guess I'll send them here. I struggled for quite a while to figure out why emms was using the second player in my config instead of the first. This fixes that issue. Thanks, Morgan --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-emms.el-Maintain-original-player-list-order-when-sel.patch >From e9f3912066945afdf3ffb8e0c8fd35a21dfe099d Mon Sep 17 00:00:00 2001 From: Morgan Smith Date: Tue, 6 Sep 2022 14:40:33 -0400 Subject: [PATCH] emms.el: Maintain original player list order when selecting a player (emms-players-for): Maintain original player list order when selecting a player This allows users to prioritize players using the order of `emms-player-list' as stated in various comments and documentation. --- emms.el | 1 + 1 file changed, 1 insertion(+) diff --git a/emms.el b/emms.el index fccecb9..c22b295 100644 --- a/emms.el +++ b/emms.el @@ -1484,6 +1484,7 @@ If the track can be played by more than one player, call (when (funcall (emms-player-get player 'playablep) track) (push player players))) emms-player-list) + (nreverse players) (if (< 1 (length players)) (emms-players-preference track players) (car players)))) -- 2.37.2 --=-=-=--