From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yoni Rabkin Newsgroups: gmane.emacs.bugs Subject: bug#57630: [PATCH] emms.el: Maintain original player list order when selecting a player Date: Tue, 06 Sep 2022 17:43:38 -0400 Message-ID: <878rmw18mt.fsf@rabkins.net> References: <87ilm0p73k.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24464"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) Cc: Morgan Smith , 57630@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 06 23:44:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVgMl-0006B1-IJ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Sep 2022 23:44:19 +0200 Original-Received: from localhost ([::1]:44540 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVgMk-0004pU-2C for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Sep 2022 17:44:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60764) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVgMU-0004pF-Vz for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2022 17:44:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35928) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oVgMU-00012X-AI for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2022 17:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oVgMT-0004iE-Vl for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2022 17:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yoni Rabkin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Sep 2022 21:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57630 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57630-submit@debbugs.gnu.org id=B57630.166250063818098 (code B ref 57630); Tue, 06 Sep 2022 21:44:01 +0000 Original-Received: (at 57630) by debbugs.gnu.org; 6 Sep 2022 21:43:58 +0000 Original-Received: from localhost ([127.0.0.1]:52860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVgMI-0004hi-RN for submit@debbugs.gnu.org; Tue, 06 Sep 2022 17:43:58 -0400 Original-Received: from smtprelay0014.hostedemail.com ([216.40.44.14]:43651 helo=relay.hostedemail.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVgME-0004hS-13 for 57630@debbugs.gnu.org; Tue, 06 Sep 2022 17:43:49 -0400 Original-Received: from omf07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2DC04160446; Tue, 6 Sep 2022 21:43:40 +0000 (UTC) Original-Received: from [HIDDEN] (Authenticated sender: yoni@rabkins.net) by omf07.hostedemail.com (Postfix) with ESMTPA id 87A522002C; Tue, 6 Sep 2022 21:43:39 +0000 (UTC) X-Ethics: Use GNU In-Reply-To: <87ilm0p73k.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 06 Sep 2022 22:42:55 +0200") X-Rspamd-Queue-Id: 87A522002C X-Stat-Signature: d66r3a7xhcratdpgopwdy4cxi46gdogi X-Rspamd-Server: rspamout02 X-Session-Marker: 796F6E69407261626B696E732E6E6574 X-Session-ID: U2FsdGVkX18bQI5fKbMbTCeRNT8ntyu+OCdYZHvyPvs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rabkins.net; h=from:to:cc:subject:references:date:in-reply-to:message-id:mime-version:content-type; s=dkim1; bh=pqVYnJpYeUJHj2V6usxO6UOJcCf3aUkWq/wXw79MSvo=; b=umktN2gm7GGgcsnSD+vf0V8PC2QvPlMjG/r5xHiYZ+aRLdh7y2Mv2zUu7CWsSlyrXzfLom500PchP0Yowh4euj0eJ7iW8sF2dnGepNHygVwT2FbEI//4qs54naduFmLOZ/IxkrnEdODfrZHKaUVd+pGiT6QiGkPJOvFNF5n4NGA= X-HE-Tag: 1662500619-111770 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241705 Archived-At: Lars Ingebrigtsen writes: > Morgan Smith writes: > >> I'm not sure where to send emms patches so I guess I'll send them here. >> >> I struggled for quite a while to figure out why emms was using the >> second player in my config instead of the first. This fixes that issue. > > The maintainer of emms is Yoni Rabkin; now added to the CCs. Addressed in the Savannah git repo and will appear in the next release. This issue can be closed. The way to select a player is via the preferences system in emms.el. However, I see no reason not to flip the order in which the players are collected if that is of use to someone. I went ahead and made that change, but using a different method. -- "Cut your own wood and it will warm you twice"