From: Morgan Smith <Morgan.J.Smith@outlook.com>
To: 57630@debbugs.gnu.org
Subject: bug#57630: [PATCH] emms.el: Maintain original player list order when selecting a player
Date: Tue, 06 Sep 2022 14:54:15 -0400 [thread overview]
Message-ID: <DM5PR03MB31635BB2D6A45E5EBF13FF3AC57E9@DM5PR03MB3163.namprd03.prod.outlook.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 240 bytes --]
Hello!
I'm not sure where to send emms patches so I guess I'll send them here.
I struggled for quite a while to figure out why emms was using the
second player in my config instead of the first. This fixes that issue.
Thanks,
Morgan
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-emms.el-Maintain-original-player-list-order-when-sel.patch --]
[-- Type: text/x-patch, Size: 920 bytes --]
From e9f3912066945afdf3ffb8e0c8fd35a21dfe099d Mon Sep 17 00:00:00 2001
From: Morgan Smith <Morgan.J.Smith@outlook.com>
Date: Tue, 6 Sep 2022 14:40:33 -0400
Subject: [PATCH] emms.el: Maintain original player list order when selecting a
player
(emms-players-for): Maintain original player list order when selecting a player
This allows users to prioritize players using the order of `emms-player-list'
as stated in various comments and documentation.
---
emms.el | 1 +
1 file changed, 1 insertion(+)
diff --git a/emms.el b/emms.el
index fccecb9..c22b295 100644
--- a/emms.el
+++ b/emms.el
@@ -1484,6 +1484,7 @@ If the track can be played by more than one player, call
(when (funcall (emms-player-get player 'playablep) track)
(push player players)))
emms-player-list)
+ (nreverse players)
(if (< 1 (length players))
(emms-players-preference track players)
(car players))))
--
2.37.2
next reply other threads:[~2022-09-06 18:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 18:54 Morgan Smith [this message]
2022-09-06 20:42 ` bug#57630: [PATCH] emms.el: Maintain original player list order when selecting a player Lars Ingebrigtsen
2022-09-06 21:43 ` Yoni Rabkin
2022-09-06 22:03 ` Lars Ingebrigtsen
2022-09-06 22:08 ` Stefan Kangas
2022-09-06 21:45 ` Yoni Rabkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM5PR03MB31635BB2D6A45E5EBF13FF3AC57E9@DM5PR03MB3163.namprd03.prod.outlook.com \
--to=morgan.j.smith@outlook.com \
--cc=57630@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).