bug#48359: 28.0.50; vc-annotate revert doesn't work

bug#48359: 28.0.50; vc-annotate revert doesn't work

[Dima Kogan]

Hi. This should be simple, but I can't figure it out quickly. Can I get
another set of eyes?

Using a very recent emacs built from git.

Recipe:

1. emacs -Q -nw file_in_a_git_repo
   Any file in any repo works probably. I'm using ~/.emacs.d/init.el

2. C-x v g
   vc-annotate

3. g
   Should "revert" the annotation buffer

This last step doesn't work: I get

  apply: Symbol's function definition is void: nil

Looking into that, I see that 'g' maps to (revert-buffer), which makes
sense. For some reason, revert-buffer-function is set to
#'help-mode-revert-buffer. This feels very strange. And is the cause of
the error: help-mode-revert-buffer assumes we're looking at a Help
buffer, and tries to call nil as a function. Is this speaking to anybody?

Thanks

bug#48359: 28.0.50; vc-annotate revert doesn't work

[Eli Zaretskii]

> From: Dima Kogan <dima@secretsauce.net>
> Date: Tue, 11 May 2021 11:55:33 -0700
> 
> 1. emacs -Q -nw file_in_a_git_repo
>    Any file in any repo works probably. I'm using ~/.emacs.d/init.el
> 
> 2. C-x v g
>    vc-annotate
> 
> 3. g
>    Should "revert" the annotation buffer
> 
> This last step doesn't work: I get
> 
>   apply: Symbol's function definition is void: nil
> 
> Looking into that, I see that 'g' maps to (revert-buffer), which makes
> sense. For some reason, revert-buffer-function is set to
> #'help-mode-revert-buffer. This feels very strange. And is the cause of
> the error: help-mode-revert-buffer assumes we're looking at a Help
> buffer, and tries to call nil as a function. Is this speaking to anybody?

Here's the backtrace of the code which sets revert-buffer-function to
help-mode-revert-buffer:

  help-mode()
  help-mode-setup()
  run-hooks(temp-buffer-setup-hook)
  vc-annotate("d:/gnu/git/emacs/trunk/src/bidi.c" ...
  funcall-interactively(vc-annotate "d:/gnu/git/emacs/trunk/src/bidi.c" ...
  call-interactively(vc-annotate nil nil)
  command-execute(vc-annotate)

bug#48359: 28.0.50; vc-annotate revert doesn't work

[Lars Ingebrigtsen]

Dima Kogan <dima@secretsauce.net> writes:

> 3. g
>    Should "revert" the annotation buffer
>
> This last step doesn't work: I get
>
>   apply: Symbol's function definition is void: nil

I've now fixed this in Emacs 29.  (By just resetting
`revert-buffer-function'.)  It might make sense to make a real reversion
function, but that doesn't really seem that useful in one of these buffers.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no