From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dima Kogan Newsgroups: gmane.emacs.bugs Subject: bug#48359: 28.0.50; vc-annotate revert doesn't work Date: Tue, 11 May 2021 11:55:33 -0700 Message-ID: <87o8dhyuai.fsf@jpl.nasa.gov> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22396"; mail-complaints-to="usenet@ciao.gmane.io" To: 48359@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 11 20:56:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lgXYF-0005en-6H for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 May 2021 20:56:15 +0200 Original-Received: from localhost ([::1]:46178 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgXYE-00008q-9m for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 May 2021 14:56:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgXY3-0008Ta-68 for bug-gnu-emacs@gnu.org; Tue, 11 May 2021 14:56:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54068) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lgXY2-0005UI-80 for bug-gnu-emacs@gnu.org; Tue, 11 May 2021 14:56:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lgXY2-0000m1-4Y for bug-gnu-emacs@gnu.org; Tue, 11 May 2021 14:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dima Kogan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 May 2021 18:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 48359 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.16207593242922 (code B ref -1); Tue, 11 May 2021 18:56:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 11 May 2021 18:55:24 +0000 Original-Received: from localhost ([127.0.0.1]:37380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgXXQ-0000l4-Hv for submit@debbugs.gnu.org; Tue, 11 May 2021 14:55:24 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:46052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgXXO-0000kw-MZ for submit@debbugs.gnu.org; Tue, 11 May 2021 14:55:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46136) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgXXO-00078q-D3 for bug-gnu-emacs@gnu.org; Tue, 11 May 2021 14:55:22 -0400 Original-Received: from out5-smtp.messagingengine.com ([66.111.4.29]:35425) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgXXM-0004xx-Hz for bug-gnu-emacs@gnu.org; Tue, 11 May 2021 14:55:22 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id A88A75C017F for ; Tue, 11 May 2021 14:55:19 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 11 May 2021 14:55:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secretsauce.net; h=from:to:subject:date:message-id:mime-version:content-type; s= fm3; bh=xe3+dl5riPC3VxWFyu/MLEFIfU5bx6/W817CkZQrmpQ=; b=TLizz5u0 RUFN9YSSEaVStfFMVl97DzQRyqJUch9yyHqreDD+nEO7CPtb8y1V1NNN1TKqTseI SMVpBbde5rqqTXrCtvtF/2j98QgkeuK2NzPO70nwpkViU+//j9mJ6GDhrXafTUon 2N90d0kru0rs8kTL0M74DvZdZi3ofYz+s/ei8XGA+Ph+HVtE+Lapg/IG39YLLsgg KCAjm3lhGrzF9QioWEsn8evaQDTB5YO3n0+jQrEiX1LoRPSFNRJD5F7yz55iybHh l74OgXL2yW4hf30vwuFCUutH6N/8io3wYxA8vJsFVGqZyoUjyNuipeCXD54mXe1B n3U7dVXh9nvMaA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=xe3+dl5riPC3VxWFyu/MLEFIfU5bx 6/W817CkZQrmpQ=; b=aAOAhmJbOKrqnJQasIKXsbVCkHamFz//M89LD7TApNzyY 89lXEQ9NXsxQiOt37XEZGhwMLO2aWtzPaFfFSNAO63CXhNYfrwwxhTVKiAXpNhzX +8MoThNR+hHU1+j3ysAgeA+4127GpMKX9gT24WUUf06Be2DRrtpSGLtYXDqFkC5A nsZVSOkCkX3nHQGtEMLkWgotPb38xwC4/RgbuY6w2DN0PV9vwBE2/XZXzEMDhVsk nCCEFuYtFrOwxohsk63p++xcvRWRltzQSrATSwVQdbt/h8DmLQ0M2EWglTjfa8Qr 7Fkvyl98KXeVc0kplwA6QGW8NsA0lNPoILbeut8Bg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdehtddgudefvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecufghrlhcuvffnffculddquddtmdenucfjughrpe fhvffufffkgggtsehttdertddttddtnecuhfhrohhmpeffihhmrgcumfhoghgrnhcuoegu ihhmrgesshgvtghrvghtshgruhgtvgdrnhgvtheqnecuggftrfgrthhtvghrnhepffdvff duhfekfffhieefhfffvddtgfefjeevuedvfedujeejudevfedtgeeguedvnecukfhppedu tdejrddvuddtrddvudefrddvgeefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepughimhgrsehsvggtrhgvthhsrghutggvrdhnvght X-ME-Proxy: Original-Received: from localhost (107-210-213-243.lightspeed.irvnca.sbcglobal.net [107.210.213.243]) by mail.messagingengine.com (Postfix) with ESMTPA for ; Tue, 11 May 2021 14:55:19 -0400 (EDT) Received-SPF: pass client-ip=66.111.4.29; envelope-from=dima@secretsauce.net; helo=out5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206274 Archived-At: Hi. This should be simple, but I can't figure it out quickly. Can I get another set of eyes? Using a very recent emacs built from git. Recipe: 1. emacs -Q -nw file_in_a_git_repo Any file in any repo works probably. I'm using ~/.emacs.d/init.el 2. C-x v g vc-annotate 3. g Should "revert" the annotation buffer This last step doesn't work: I get apply: Symbol's function definition is void: nil Looking into that, I see that 'g' maps to (revert-buffer), which makes sense. For some reason, revert-buffer-function is set to #'help-mode-revert-buffer. This feels very strange. And is the cause of the error: help-mode-revert-buffer assumes we're looking at a Help buffer, and tries to call nil as a function. Is this speaking to anybody? Thanks