From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48359: 28.0.50; vc-annotate revert doesn't work Date: Tue, 11 May 2021 22:10:34 +0300 Message-ID: <83lf8l3x3p.fsf@gnu.org> References: <87o8dhyuai.fsf@jpl.nasa.gov> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17903"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48359@debbugs.gnu.org To: Dima Kogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 11 21:11:20 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lgXmp-0004Xt-E0 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 May 2021 21:11:19 +0200 Original-Received: from localhost ([::1]:38396 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgXmo-0006kF-Cw for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 May 2021 15:11:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49996) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgXmY-0006bx-Ac for bug-gnu-emacs@gnu.org; Tue, 11 May 2021 15:11:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54112) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lgXmY-0006SS-2h for bug-gnu-emacs@gnu.org; Tue, 11 May 2021 15:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lgXmX-0001BE-Ui for bug-gnu-emacs@gnu.org; Tue, 11 May 2021 15:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 May 2021 19:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48359 X-GNU-PR-Package: emacs Original-Received: via spool by 48359-submit@debbugs.gnu.org id=B48359.16207602394506 (code B ref 48359); Tue, 11 May 2021 19:11:01 +0000 Original-Received: (at 48359) by debbugs.gnu.org; 11 May 2021 19:10:39 +0000 Original-Received: from localhost ([127.0.0.1]:37425 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgXmB-0001Ac-8g for submit@debbugs.gnu.org; Tue, 11 May 2021 15:10:39 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lgXm9-0001AP-Lk for 48359@debbugs.gnu.org; Tue, 11 May 2021 15:10:37 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33124) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgXm3-00067c-N0; Tue, 11 May 2021 15:10:32 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1050 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgXm1-0006c7-Ot; Tue, 11 May 2021 15:10:31 -0400 In-Reply-To: <87o8dhyuai.fsf@jpl.nasa.gov> (message from Dima Kogan on Tue, 11 May 2021 11:55:33 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206276 Archived-At: > From: Dima Kogan > Date: Tue, 11 May 2021 11:55:33 -0700 > > 1. emacs -Q -nw file_in_a_git_repo > Any file in any repo works probably. I'm using ~/.emacs.d/init.el > > 2. C-x v g > vc-annotate > > 3. g > Should "revert" the annotation buffer > > This last step doesn't work: I get > > apply: Symbol's function definition is void: nil > > Looking into that, I see that 'g' maps to (revert-buffer), which makes > sense. For some reason, revert-buffer-function is set to > #'help-mode-revert-buffer. This feels very strange. And is the cause of > the error: help-mode-revert-buffer assumes we're looking at a Help > buffer, and tries to call nil as a function. Is this speaking to anybody? Here's the backtrace of the code which sets revert-buffer-function to help-mode-revert-buffer: help-mode() help-mode-setup() run-hooks(temp-buffer-setup-hook) vc-annotate("d:/gnu/git/emacs/trunk/src/bidi.c" ... funcall-interactively(vc-annotate "d:/gnu/git/emacs/trunk/src/bidi.c" ... call-interactively(vc-annotate nil nil) command-execute(vc-annotate)