unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Dima Kogan <dima@secretsauce.net>
Cc: 48359@debbugs.gnu.org
Subject: bug#48359: 28.0.50; vc-annotate revert doesn't work
Date: Tue, 11 May 2021 22:10:34 +0300	[thread overview]
Message-ID: <83lf8l3x3p.fsf@gnu.org> (raw)
In-Reply-To: <87o8dhyuai.fsf@jpl.nasa.gov> (message from Dima Kogan on Tue, 11 May 2021 11:55:33 -0700)

> From: Dima Kogan <dima@secretsauce.net>
> Date: Tue, 11 May 2021 11:55:33 -0700
> 
> 1. emacs -Q -nw file_in_a_git_repo
>    Any file in any repo works probably. I'm using ~/.emacs.d/init.el
> 
> 2. C-x v g
>    vc-annotate
> 
> 3. g
>    Should "revert" the annotation buffer
> 
> This last step doesn't work: I get
> 
>   apply: Symbol's function definition is void: nil
> 
> Looking into that, I see that 'g' maps to (revert-buffer), which makes
> sense. For some reason, revert-buffer-function is set to
> #'help-mode-revert-buffer. This feels very strange. And is the cause of
> the error: help-mode-revert-buffer assumes we're looking at a Help
> buffer, and tries to call nil as a function. Is this speaking to anybody?

Here's the backtrace of the code which sets revert-buffer-function to
help-mode-revert-buffer:

  help-mode()
  help-mode-setup()
  run-hooks(temp-buffer-setup-hook)
  vc-annotate("d:/gnu/git/emacs/trunk/src/bidi.c" ...
  funcall-interactively(vc-annotate "d:/gnu/git/emacs/trunk/src/bidi.c" ...
  call-interactively(vc-annotate nil nil)
  command-execute(vc-annotate)





  reply	other threads:[~2021-05-11 19:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11 18:55 bug#48359: 28.0.50; vc-annotate revert doesn't work Dima Kogan
2021-05-11 19:10 ` Eli Zaretskii [this message]
2022-07-11 14:28 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83lf8l3x3p.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=48359@debbugs.gnu.org \
    --cc=dima@secretsauce.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).