* bug#13543: 24.2; [PATCH] (ert) "wrong-type-argument characterp" when assert fail on large (>28 bit) numbers
@ 2013-01-24 20:32 Oleksandr Gavenko
2013-02-04 7:49 ` Glenn Morris
0 siblings, 1 reply; 3+ messages in thread
From: Oleksandr Gavenko @ 2013-01-24 20:32 UTC (permalink / raw)
To: 13543
[-- Attachment #1: Type: text/plain, Size: 927 bytes --]
In GNU Emacs 24.2.1 (x86_64-pc-linux-gnu, GTK+ Version 2.24.10)
of 2012-09-09 on trouble, modified by Debian
'should' from lisp/emacs-lisp/ert.el fail to create character from number, for
example evaluate one of these expressions:
(should (equal #x1000000 1))
(should (equal 1 -1))
Problem come from "?%c" in:
(defun ert--explain-format-atom (x)
"Format the atom X for `ert--explain-equal'."
(typecase x
(fixnum (list x (format "#x%x" x) (format "?%c" x)))
(t x)))
Another problem from (format "?%c" x) is performance penalty when "x" is rare
character code (font library intensively scan for missing character glyph
among all system available fonts causing 5 second delay and 100% hard disk
usage).
I recommend remove formatting to character as amount of problems are larger
then amount of benefits.
I discover this issue when start write tests for low level binary parsing
library (ASN.1).
[-- Attachment #2: ert--explain-format-atom.patch --]
[-- Type: text/plain, Size: 958 bytes --]
=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog 2012-12-19 13:01:16 +0000
+++ lisp/ChangeLog 2013-01-24 20:29:45 +0000
@@ -1,3 +1,10 @@
+2013-01-24 Oleksandr Gavenko <gavenkoa@gmail.com>
+
+ * ert.el (ert--explain-format-atom): Delete formating into
+ character due to performance issue on attempts to find font glyph
+ for rare used character and impossibility handle negative or large
+ numbers.
+
2012-12-19 Michael Albinus <michael.albinus@gmx.de>
* net/tramp-sh.el (tramp-sh-handle-file-acl): Delete empty lines
=== modified file 'lisp/emacs-lisp/ert.el'
--- lisp/emacs-lisp/ert.el 2012-11-23 03:26:09 +0000
+++ lisp/emacs-lisp/ert.el 2013-01-24 20:21:48 +0000
@@ -568,7 +568,7 @@
(defun ert--explain-format-atom (x)
"Format the atom X for `ert--explain-equal'."
(cl-typecase x
- (fixnum (list x (format "#x%x" x) (format "?%c" x)))
+ (fixnum (list x (format "#x%x" x)))
(t x)))
(defun ert--explain-equal-rec (a b)
[-- Attachment #3: Type: text/plain, Size: 19 bytes --]
--
Best regards!
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#13543: 24.2; [PATCH] (ert) "wrong-type-argument characterp" when assert fail on large (>28 bit) numbers
2013-01-24 20:32 bug#13543: 24.2; [PATCH] (ert) "wrong-type-argument characterp" when assert fail on large (>28 bit) numbers Oleksandr Gavenko
@ 2013-02-04 7:49 ` Glenn Morris
2013-02-04 15:33 ` Oleksandr Gavenko
0 siblings, 1 reply; 3+ messages in thread
From: Glenn Morris @ 2013-02-04 7:49 UTC (permalink / raw)
To: Oleksandr Gavenko; +Cc: 13543
Oleksandr Gavenko wrote:
> 'should' from lisp/emacs-lisp/ert.el fail to create character from
> number, for example evaluate one of these expressions:
>
> (should (equal #x1000000 1))
> (should (equal 1 -1))
I can see some usefulness to printing the character form for something
like
(should (equal ?a ?b))
so I installed this change:
***************
*** 568,574 ****
(defun ert--explain-format-atom (x)
"Format the atom X for `ert--explain-equal'."
(cl-typecase x
! (fixnum (list x (format "#x%x" x) (format "?%c" x)))
(t x)))
(defun ert--explain-equal-rec (a b)
--- 568,575 ----
(defun ert--explain-format-atom (x)
"Format the atom X for `ert--explain-equal'."
(cl-typecase x
! (character (list x (format "#x%x" x) (format "?%c" x)))
! (fixnum (list x (format "#x%x" x)))
(t x)))
(defun ert--explain-equal-rec (a b)
> Another problem from (format "?%c" x) is performance penalty when "x"
> is rare character code (font library intensively scan for missing
> character glyph among all system available fonts causing 5 second
> delay and 100% hard disk usage).
This seems like a general issue rather than an ERT one.
> I recommend remove formatting to character as amount of problems are
> larger then amount of benefits.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#13543: 24.2; [PATCH] (ert) "wrong-type-argument characterp" when assert fail on large (>28 bit) numbers
2013-02-04 7:49 ` Glenn Morris
@ 2013-02-04 15:33 ` Oleksandr Gavenko
0 siblings, 0 replies; 3+ messages in thread
From: Oleksandr Gavenko @ 2013-02-04 15:33 UTC (permalink / raw)
To: Glenn Morris; +Cc: 13543
On 2013-02-04, Glenn Morris wrote:
>> 'should' from lisp/emacs-lisp/ert.el fail to create character from
>> number, for example evaluate one of these expressions:
>>
>> (should (equal #x1000000 1))
>> (should (equal 1 -1))
>
> I can see some usefulness to printing the character form for something
> like
>
> (should (equal ?a ?b))
>
> so I installed this change:
>
> ***************
> *** 568,574 ****
> (defun ert--explain-format-atom (x)
> "Format the atom X for `ert--explain-equal'."
> (cl-typecase x
> ! (fixnum (list x (format "#x%x" x) (format "?%c" x)))
> (t x)))
>
> (defun ert--explain-equal-rec (a b)
> --- 568,575 ----
> (defun ert--explain-format-atom (x)
> "Format the atom X for `ert--explain-equal'."
> (cl-typecase x
> ! (character (list x (format "#x%x" x) (format "?%c" x)))
> ! (fixnum (list x (format "#x%x" x)))
> (t x)))
>
> (defun ert--explain-equal-rec (a b)
>
Your idea look good to me. I think about it but afraid inconsistent of output
(print 3 filed for character and 2 for fixnum). That is why I don't suggest
this solution...
One essential point is that if some test check fail all followed tests doesn't
executed due to this bug. So this must be fixed in any way...
--
Best regards!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-04 15:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-24 20:32 bug#13543: 24.2; [PATCH] (ert) "wrong-type-argument characterp" when assert fail on large (>28 bit) numbers Oleksandr Gavenko
2013-02-04 7:49 ` Glenn Morris
2013-02-04 15:33 ` Oleksandr Gavenko
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).