From: Glenn Morris <rgm@gnu.org>
To: Oleksandr Gavenko <gavenkoa@gmail.com>
Cc: 13543@debbugs.gnu.org
Subject: bug#13543: 24.2; [PATCH] (ert) "wrong-type-argument characterp" when assert fail on large (>28 bit) numbers
Date: Mon, 04 Feb 2013 02:49:05 -0500 [thread overview]
Message-ID: <8gmwvktt72.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <878v7i1fvg.fsf@gavenkoa.example.com> (Oleksandr Gavenko's message of "Thu, 24 Jan 2013 22:32:35 +0200")
Oleksandr Gavenko wrote:
> 'should' from lisp/emacs-lisp/ert.el fail to create character from
> number, for example evaluate one of these expressions:
>
> (should (equal #x1000000 1))
> (should (equal 1 -1))
I can see some usefulness to printing the character form for something
like
(should (equal ?a ?b))
so I installed this change:
***************
*** 568,574 ****
(defun ert--explain-format-atom (x)
"Format the atom X for `ert--explain-equal'."
(cl-typecase x
! (fixnum (list x (format "#x%x" x) (format "?%c" x)))
(t x)))
(defun ert--explain-equal-rec (a b)
--- 568,575 ----
(defun ert--explain-format-atom (x)
"Format the atom X for `ert--explain-equal'."
(cl-typecase x
! (character (list x (format "#x%x" x) (format "?%c" x)))
! (fixnum (list x (format "#x%x" x)))
(t x)))
(defun ert--explain-equal-rec (a b)
> Another problem from (format "?%c" x) is performance penalty when "x"
> is rare character code (font library intensively scan for missing
> character glyph among all system available fonts causing 5 second
> delay and 100% hard disk usage).
This seems like a general issue rather than an ERT one.
> I recommend remove formatting to character as amount of problems are
> larger then amount of benefits.
next prev parent reply other threads:[~2013-02-04 7:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 20:32 bug#13543: 24.2; [PATCH] (ert) "wrong-type-argument characterp" when assert fail on large (>28 bit) numbers Oleksandr Gavenko
2013-02-04 7:49 ` Glenn Morris [this message]
2013-02-04 15:33 ` Oleksandr Gavenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8gmwvktt72.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=13543@debbugs.gnu.org \
--cc=gavenkoa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).