From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Oleksandr Gavenko Newsgroups: gmane.emacs.bugs Subject: bug#13543: 24.2; [PATCH] (ert) "wrong-type-argument characterp" when assert fail on large (>28 bit) numbers Date: Thu, 24 Jan 2013 22:32:35 +0200 Message-ID: <878v7i1fvg.fsf@gavenkoa.example.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1359059656 10936 80.91.229.3 (24 Jan 2013 20:34:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 24 Jan 2013 20:34:16 +0000 (UTC) To: 13543@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 24 21:34:34 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TyTVI-00074t-IN for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Jan 2013 21:34:32 +0100 Original-Received: from localhost ([::1]:54528 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TyTV1-0004sr-7d for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Jan 2013 15:34:15 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:35380) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TyTUq-0004rk-Sj for bug-gnu-emacs@gnu.org; Thu, 24 Jan 2013 15:34:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TyTUk-00075E-PP for bug-gnu-emacs@gnu.org; Thu, 24 Jan 2013 15:34:04 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42732) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TyTUk-00074z-L4 for bug-gnu-emacs@gnu.org; Thu, 24 Jan 2013 15:33:58 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TyTUo-00059O-CU for bug-gnu-emacs@gnu.org; Thu, 24 Jan 2013 15:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Oleksandr Gavenko Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Jan 2013 20:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 13543 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.135905958319706 (code B ref -1); Thu, 24 Jan 2013 20:34:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 24 Jan 2013 20:33:03 +0000 Original-Received: from localhost ([127.0.0.1]:48194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TyTTq-00057c-Nn for submit@debbugs.gnu.org; Thu, 24 Jan 2013 15:33:03 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:51805) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TyTTn-00057F-Ts for submit@debbugs.gnu.org; Thu, 24 Jan 2013 15:33:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TyTTh-0006aZ-M0 for submit@debbugs.gnu.org; Thu, 24 Jan 2013 15:32:55 -0500 Original-Received: from lists.gnu.org ([208.118.235.17]:34851) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TyTTh-0006aV-JL for submit@debbugs.gnu.org; Thu, 24 Jan 2013 15:32:53 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:34915) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TyTTc-0004DF-Cx for bug-gnu-emacs@gnu.org; Thu, 24 Jan 2013 15:32:53 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TyTTV-0006XW-SR for bug-gnu-emacs@gnu.org; Thu, 24 Jan 2013 15:32:48 -0500 Original-Received: from mail-ee0-f48.google.com ([74.125.83.48]:45342) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TyTTV-0006Wi-KO for bug-gnu-emacs@gnu.org; Thu, 24 Jan 2013 15:32:41 -0500 Original-Received: by mail-ee0-f48.google.com with SMTP id t10so4941806eei.35 for ; Thu, 24 Jan 2013 12:32:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:subject:date:message-id:mime-version :content-type; bh=eLoEtHobSTQqT1u9/EDVHVfdEII62WuAEGpedmCKPho=; b=epiYg7CT85RXPPEhfrao580tC8TfP88jkLm6Pz0vSE31MOQuadGYJR/TLu+jWW+plg cZE1nZHo/D9TTgaqGNjDkjAkC+ZDbNoZ5RHsTd9L3+NjVtU6SzLujBTQ55XXa205awal eU1WSbTQWwi+EaQenhohAvtvTuEPPsq9xSVN1zYobrxruxESphtq2Rdg7uA5R+V/FLo8 Uhj84P/vTAyCxX0nVpKHSV0BdOb/sbJUTYNN021qQf1ANRr6V2rJCnPEcVvnwh0bMslc 30SRfpVpoHTQsUEP4g98cKNAMOZ5nXo7FeA0c1w8pRfgnMYYLv1lgqjpaCExDaKKXd2m ZnsQ== X-Received: by 10.14.223.135 with SMTP id v7mr9697838eep.41.1359059559331; Thu, 24 Jan 2013 12:32:39 -0800 (PST) Original-Received: from desktop ([37.229.4.200]) by mx.google.com with ESMTPS id q5sm21767432eeo.17.2013.01.24.12.32.37 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 24 Jan 2013 12:32:38 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:70261 Archived-At: --=-=-= Content-Type: text/plain In GNU Emacs 24.2.1 (x86_64-pc-linux-gnu, GTK+ Version 2.24.10) of 2012-09-09 on trouble, modified by Debian 'should' from lisp/emacs-lisp/ert.el fail to create character from number, for example evaluate one of these expressions: (should (equal #x1000000 1)) (should (equal 1 -1)) Problem come from "?%c" in: (defun ert--explain-format-atom (x) "Format the atom X for `ert--explain-equal'." (typecase x (fixnum (list x (format "#x%x" x) (format "?%c" x))) (t x))) Another problem from (format "?%c" x) is performance penalty when "x" is rare character code (font library intensively scan for missing character glyph among all system available fonts causing 5 second delay and 100% hard disk usage). I recommend remove formatting to character as amount of problems are larger then amount of benefits. I discover this issue when start write tests for low level binary parsing library (ASN.1). --=-=-= Content-Type: text/plain Content-Disposition: inline Content-Description: ert--explain-format-atom.patch === modified file 'lisp/ChangeLog' --- lisp/ChangeLog 2012-12-19 13:01:16 +0000 +++ lisp/ChangeLog 2013-01-24 20:29:45 +0000 @@ -1,3 +1,10 @@ +2013-01-24 Oleksandr Gavenko + + * ert.el (ert--explain-format-atom): Delete formating into + character due to performance issue on attempts to find font glyph + for rare used character and impossibility handle negative or large + numbers. + 2012-12-19 Michael Albinus * net/tramp-sh.el (tramp-sh-handle-file-acl): Delete empty lines === modified file 'lisp/emacs-lisp/ert.el' --- lisp/emacs-lisp/ert.el 2012-11-23 03:26:09 +0000 +++ lisp/emacs-lisp/ert.el 2013-01-24 20:21:48 +0000 @@ -568,7 +568,7 @@ (defun ert--explain-format-atom (x) "Format the atom X for `ert--explain-equal'." (cl-typecase x - (fixnum (list x (format "#x%x" x) (format "?%c" x))) + (fixnum (list x (format "#x%x" x))) (t x))) (defun ert--explain-equal-rec (a b) --=-=-= Content-Type: text/plain -- Best regards! --=-=-=--