From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#13543: 24.2; [PATCH] (ert) "wrong-type-argument characterp" when assert fail on large (>28 bit) numbers Date: Mon, 04 Feb 2013 02:49:05 -0500 Message-ID: <8gmwvktt72.fsf@fencepost.gnu.org> References: <878v7i1fvg.fsf@gavenkoa.example.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1359964206 1237 80.91.229.3 (4 Feb 2013 07:50:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 4 Feb 2013 07:50:06 +0000 (UTC) Cc: 13543@debbugs.gnu.org To: Oleksandr Gavenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 04 08:50:26 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U2Goo-0005Ql-Vy for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Feb 2013 08:50:23 +0100 Original-Received: from localhost ([::1]:42602 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U2GoW-0002kw-EG for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Feb 2013 02:50:04 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:52155) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U2GoU-0002kp-Gd for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2013 02:50:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U2GoR-0005v6-Dl for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2013 02:50:02 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57893) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U2GoR-0005v1-AF for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2013 02:49:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1U2GpS-0002BK-2X for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2013 02:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Feb 2013 07:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13543 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13543-submit@debbugs.gnu.org id=B13543.13599642168327 (code B ref 13543); Mon, 04 Feb 2013 07:51:01 +0000 Original-Received: (at 13543) by debbugs.gnu.org; 4 Feb 2013 07:50:16 +0000 Original-Received: from localhost ([127.0.0.1]:35122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U2Gof-0002AD-OE for submit@debbugs.gnu.org; Mon, 04 Feb 2013 02:50:16 -0500 Original-Received: from fencepost.gnu.org ([208.118.235.10]:38558) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U2God-0002A5-3m for 13543@debbugs.gnu.org; Mon, 04 Feb 2013 02:50:12 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1U2GnZ-000390-Re; Mon, 04 Feb 2013 02:49:05 -0500 X-Spook: Pine Gap bootleg enemy of the state Lexis-Nexis MIT-LL X-Ran: `ZY?EYl7U}2ZI1@CfEnS=&!yt%fWoX32z:;~{bBQT>7L\8"h"hptmh4Gq&Y1V'sVr2(Q_& X-Hue: green X-Attribution: GM In-Reply-To: <878v7i1fvg.fsf@gavenkoa.example.com> (Oleksandr Gavenko's message of "Thu, 24 Jan 2013 22:32:35 +0200") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:70664 Archived-At: Oleksandr Gavenko wrote: > 'should' from lisp/emacs-lisp/ert.el fail to create character from > number, for example evaluate one of these expressions: > > (should (equal #x1000000 1)) > (should (equal 1 -1)) I can see some usefulness to printing the character form for something like (should (equal ?a ?b)) so I installed this change: *************** *** 568,574 **** (defun ert--explain-format-atom (x) "Format the atom X for `ert--explain-equal'." (cl-typecase x ! (fixnum (list x (format "#x%x" x) (format "?%c" x))) (t x))) (defun ert--explain-equal-rec (a b) --- 568,575 ---- (defun ert--explain-format-atom (x) "Format the atom X for `ert--explain-equal'." (cl-typecase x ! (character (list x (format "#x%x" x) (format "?%c" x))) ! (fixnum (list x (format "#x%x" x))) (t x))) (defun ert--explain-equal-rec (a b) > Another problem from (format "?%c" x) is performance penalty when "x" > is rare character code (font library intensively scan for missing > character glyph among all system available fonts causing 5 second > delay and 100% hard disk usage). This seems like a general issue rather than an ERT one. > I recommend remove formatting to character as amount of problems are > larger then amount of benefits.