From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: luangruo@yahoo.com, tumashu@163.com, 51821@debbugs.gnu.org
Subject: bug#51821: 29.0.50; Suggest add variable or frame parameter: line-height
Date: Sat, 20 Nov 2021 09:26:19 +0100 [thread overview]
Message-ID: <878rxjteqc.fsf@gnus.org> (raw)
In-Reply-To: <838rxkwoz8.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 19 Nov 2021 10:04:27 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
> No, it should fix both. Did you try that? If you did and it didn't
> work, can you show a recipe from "emacs -Q" so I could investigate?
No, I only tested in buffers with a monospaced font and then read the
doc string.
> The "default font" part above is an over-simplification: it is hard to
> say something accurate enough in a single short sentence. I did try
> to explain it more in the rest of the doc string: this actually
> affects any font which some face uses for ASCII characters.
Perhaps "default font(s)" would help.
>> Testing the patch, it also affects the height of faces with :height in
>> them, meaning that separator lines get much taller than they should be.
>
> As I told you, it is currently impossible to single out such faces.
Right, but I think I said that it should be pretty easy to carry that
information in struct face if we want to go that way.
> Also, I don't think we should necessarily exempt _any_ face that
> specifies :height, because if that face is used to display with mixed
> fonts, it will again have the same problem when both CJK fonts and
> non-CJK fonts are mixed.
Hm... Yeah, that's true. For instance, in eww in <h1> we have :height
1.3, and we probably want the CJK/non-CJK font mixture to be handled the
same way as if there isn't a :height there. OK, the :height thing
doesn't work.
> The separator lines are thus a very special
> case, and if we want to solve that, we need a more focused solution.
> For example, we could not stretch the height if the face's height is
> below some threshold, on the assumption that such small fonts will
> never used to display human-readable text.
Hm, yes, the separator lines are very special, and the :height thing is
more a hack than anything else. Perhaps we should just introduce a new
spec, like :pixel-height that allows us to specify specifically how big
the separator line should be.
Hm. Or not use faces at all for the separator lines? I don't know how
that would look, though.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-11-20 8:26 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 23:28 bug#51821: 29.0.50; Suggest add variable or frame parameter: line-height Feng Shu
2021-11-14 1:23 ` Lars Ingebrigtsen
2021-11-14 1:46 ` Feng Shu
2021-11-14 6:59 ` Eli Zaretskii
2021-11-14 7:01 ` Lars Ingebrigtsen
2021-11-14 7:04 ` Feng Shu
2021-11-14 8:03 ` Eli Zaretskii
2021-11-14 7:23 ` Eli Zaretskii
2021-11-15 5:33 ` Lars Ingebrigtsen
2021-11-19 23:03 ` Feng Shu
2021-11-20 7:00 ` Eli Zaretskii
2021-11-20 7:13 ` Feng Shu
2021-11-20 7:34 ` Eli Zaretskii
2021-11-20 7:43 ` Feng Shu
2021-11-14 11:29 ` Eli Zaretskii
2021-11-14 17:55 ` Lars Ingebrigtsen
2021-11-14 18:14 ` Eli Zaretskii
2021-11-14 22:42 ` Feng Shu
2021-11-15 12:39 ` Eli Zaretskii
2021-11-15 5:39 ` Lars Ingebrigtsen
2021-11-15 13:02 ` Eli Zaretskii
2021-11-16 7:34 ` Lars Ingebrigtsen
2021-11-16 15:10 ` Eli Zaretskii
2021-11-16 15:20 ` Lars Ingebrigtsen
2021-11-16 16:45 ` Eli Zaretskii
2021-11-18 18:26 ` Eli Zaretskii
2021-11-19 0:26 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-19 7:01 ` Eli Zaretskii
2021-11-19 1:57 ` Feng Shu
2021-11-19 7:08 ` Eli Zaretskii
2021-11-19 7:18 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-19 7:31 ` bug#51821: " tumashu
2021-11-19 8:28 ` Eli Zaretskii
2021-11-19 8:45 ` tumashu
2021-11-19 8:06 ` Eli Zaretskii
2021-11-19 9:33 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-19 12:27 ` Eli Zaretskii
2021-11-19 12:36 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-19 7:26 ` tumashu
2021-11-19 8:25 ` Eli Zaretskii
2021-11-19 8:54 ` tumashu
2021-11-19 9:09 ` tumashu
2021-11-19 12:18 ` Eli Zaretskii
2021-11-19 7:12 ` Lars Ingebrigtsen
2021-11-19 8:04 ` Eli Zaretskii
2021-11-20 8:26 ` Lars Ingebrigtsen [this message]
2021-11-20 8:39 ` Eli Zaretskii
2021-11-20 8:51 ` Lars Ingebrigtsen
2021-11-20 9:06 ` Eli Zaretskii
2021-11-20 9:27 ` Lars Ingebrigtsen
2021-11-20 9:53 ` Eli Zaretskii
2021-11-20 9:58 ` Lars Ingebrigtsen
2021-11-20 10:15 ` Eli Zaretskii
2021-11-21 8:06 ` Lars Ingebrigtsen
2021-11-21 8:18 ` Eli Zaretskii
2021-11-21 8:21 ` Lars Ingebrigtsen
2021-11-21 8:32 ` Eli Zaretskii
2021-11-21 8:38 ` Lars Ingebrigtsen
2021-11-21 10:00 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-21 14:05 ` Eli Zaretskii
2021-11-19 14:48 ` Feng Shu
2021-11-14 22:37 ` Feng Shu
2021-11-15 12:38 ` Eli Zaretskii
2021-11-16 3:51 ` Feng Shu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878rxjteqc.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=51821@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=luangruo@yahoo.com \
--cc=tumashu@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).