unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: tumashu@163.com, larsi@gnus.org, 51821@debbugs.gnu.org
Subject: bug#51821: 29.0.50; Suggest add variable or frame parameter: line-height
Date: Fri, 19 Nov 2021 14:27:21 +0200	[thread overview]
Message-ID: <83sfvsuy8m.fsf@gnu.org> (raw)
In-Reply-To: <878rxko5gh.fsf@yahoo.com> (message from Po Lu on Fri, 19 Nov 2021 17:33:18 +0800)

> From: Po Lu <luangruo@yahoo.com>
> Cc: tumashu@163.com,  larsi@gnus.org,  51821@debbugs.gnu.org
> Date: Fri, 19 Nov 2021 17:33:18 +0800
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> I think he expects the text in the smaller font to be "centered"
> >> vertically, instead of sharing the same baseline as the Chinese font,
> >> but I'm not sure.
> 
> > Really?  That can be done, but won't it look ugly on display?
> 
> IMO yes, but other people might have differing opinions.  Would it hurt
> to make this an option?

I'd rather not introduce one more option to control the line height
unless it's really needed.  The code there is already a "maze of
twisted passages all alike", quite hard to understand and modify, so
adding one more option could easily break something.

For now, it does sound like Feng Shu wants the baseline aligned, so
such an option is not required yet.

> > Do other GUI applications do that with mixed CJK and non-CJK fonts?
> 
> I found out earlier that the other applications simply scale the
> overlarge glyphs to fit some predefined height.

Emacs doesn't scale the font glyphs, AFAIK, primarily because that
won't work with bitmapped fonts, which we still support and which some
users still use (I remember recent enough bug reports due to some
change that broke bitmapped fonts).  We let the font backend do the
scaling, when we request a font of certain size, and the result is
what you see now.

But if you or someone else know how to scale font glyphs on the fly,
please show the code.  The main difficulty her, as I see it, is to
decide to which size to scale, since each character can have a glyph
with different metrics.





  reply	other threads:[~2021-11-19 12:27 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-13 23:28 bug#51821: 29.0.50; Suggest add variable or frame parameter: line-height Feng Shu
2021-11-14  1:23 ` Lars Ingebrigtsen
2021-11-14  1:46   ` Feng Shu
2021-11-14  6:59   ` Eli Zaretskii
2021-11-14  7:01     ` Lars Ingebrigtsen
2021-11-14  7:04       ` Feng Shu
2021-11-14  8:03         ` Eli Zaretskii
2021-11-14  7:23       ` Eli Zaretskii
2021-11-15  5:33         ` Lars Ingebrigtsen
2021-11-19 23:03     ` Feng Shu
2021-11-20  7:00       ` Eli Zaretskii
2021-11-20  7:13         ` Feng Shu
2021-11-20  7:34           ` Eli Zaretskii
2021-11-20  7:43             ` Feng Shu
2021-11-14 11:29 ` Eli Zaretskii
2021-11-14 17:55   ` Lars Ingebrigtsen
2021-11-14 18:14     ` Eli Zaretskii
2021-11-14 22:42       ` Feng Shu
2021-11-15 12:39         ` Eli Zaretskii
2021-11-15  5:39       ` Lars Ingebrigtsen
2021-11-15 13:02         ` Eli Zaretskii
2021-11-16  7:34           ` Lars Ingebrigtsen
2021-11-16 15:10             ` Eli Zaretskii
2021-11-16 15:20               ` Lars Ingebrigtsen
2021-11-16 16:45                 ` Eli Zaretskii
2021-11-18 18:26                   ` Eli Zaretskii
2021-11-19  0:26                     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-19  7:01                       ` Eli Zaretskii
2021-11-19  1:57                     ` Feng Shu
2021-11-19  7:08                       ` Eli Zaretskii
2021-11-19  7:18                         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-19  7:31                           ` bug#51821: " tumashu
2021-11-19  8:28                             ` Eli Zaretskii
2021-11-19  8:45                               ` tumashu
2021-11-19  8:06                           ` Eli Zaretskii
2021-11-19  9:33                             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-19 12:27                               ` Eli Zaretskii [this message]
2021-11-19 12:36                                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-19  7:26                         ` tumashu
2021-11-19  8:25                           ` Eli Zaretskii
2021-11-19  8:54                             ` tumashu
2021-11-19  9:09                             ` tumashu
2021-11-19 12:18                               ` Eli Zaretskii
2021-11-19  7:12                     ` Lars Ingebrigtsen
2021-11-19  8:04                       ` Eli Zaretskii
2021-11-20  8:26                         ` Lars Ingebrigtsen
2021-11-20  8:39                           ` Eli Zaretskii
2021-11-20  8:51                             ` Lars Ingebrigtsen
2021-11-20  9:06                               ` Eli Zaretskii
2021-11-20  9:27                                 ` Lars Ingebrigtsen
2021-11-20  9:53                                   ` Eli Zaretskii
2021-11-20  9:58                                     ` Lars Ingebrigtsen
2021-11-20 10:15                                       ` Eli Zaretskii
2021-11-21  8:06                                         ` Lars Ingebrigtsen
2021-11-21  8:18                                           ` Eli Zaretskii
2021-11-21  8:21                                             ` Lars Ingebrigtsen
2021-11-21  8:32                                               ` Eli Zaretskii
2021-11-21  8:38                                                 ` Lars Ingebrigtsen
2021-11-21 10:00                                                   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-21 14:05                                                   ` Eli Zaretskii
2021-11-19 14:48                     ` Feng Shu
2021-11-14 22:37   ` Feng Shu
2021-11-15 12:38     ` Eli Zaretskii
2021-11-16  3:51       ` Feng Shu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83sfvsuy8m.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=51821@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    --cc=luangruo@yahoo.com \
    --cc=tumashu@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).