From: "Feng Shu" <tumashu@163.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 51821@debbugs.gnu.org
Subject: bug#51821: 29.0.50; Suggest add variable or frame parameter: line-height
Date: Mon, 15 Nov 2021 06:37:23 +0800 [thread overview]
Message-ID: <87r1biqs7w.fsf@163.com> (raw)
In-Reply-To: <83bl2nugao.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 14 Nov 2021 13:29:03 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: "Feng Shu" <tumashu@163.com>
>> Date: Sun, 14 Nov 2021 07:28:46 +0800
>>
>> I have try the below code, and it work
>>
>> (insert (propertize "\n" 'line-height 1.4))
>>
>> But how to apply line-height global and let line-height work with
>> mode/header/tab-bar?
>>
>> Maybe we should add a variable or frame parameter: line-height
>
> Adding a variable is easy, but what would be its semantics? Emacs can
> display different faces in the same window, and some of those faces
> can have smaller height. If the line of text in a window uses the
> smaller faces, that line's height will be smaller as well.
>
> For example, evaluate the following:
>
> (defface small
> '((t :height 0.6))
> "")
>
> Then visit some file, and do this:
>
> M-x font-lock-mode RET
> M-x load-library RET facemenu RET
> C-SPC
> C-n
> C-n
> M-x facemenu-set-face RET small RET
>
> Now you should see 2 lines in a smaller font; those lines have
> correspondingly smaller height.
I think user should set to (t . RATIO) instead in most case.
Maybe line-height can be a alist ((face1 . RATIO) (face2 .RATIO)).
‘(FACE . RATIO)’
If the height spec is a cons of the format shown, the numeric
height is RATIO times the height of face FACE. RATIO can be any
type of number, or ‘nil’ which means a ratio of 1. If FACE is ‘t’,
it refers to the current face.
>
> So if we require all the lines to be at least line-height pixels,
> those smaller lines will also become higher, and that is not what's
> expected, I guess?
If user set line-height to a INTEGER with a variable, I think it
is user expected.
>
> So what would be the correct interpretation of the line-height
> variable or frame parameter, when different faces are being used?
--
next prev parent reply other threads:[~2021-11-14 22:37 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 23:28 bug#51821: 29.0.50; Suggest add variable or frame parameter: line-height Feng Shu
2021-11-14 1:23 ` Lars Ingebrigtsen
2021-11-14 1:46 ` Feng Shu
2021-11-14 6:59 ` Eli Zaretskii
2021-11-14 7:01 ` Lars Ingebrigtsen
2021-11-14 7:04 ` Feng Shu
2021-11-14 8:03 ` Eli Zaretskii
2021-11-14 7:23 ` Eli Zaretskii
2021-11-15 5:33 ` Lars Ingebrigtsen
2021-11-19 23:03 ` Feng Shu
2021-11-20 7:00 ` Eli Zaretskii
2021-11-20 7:13 ` Feng Shu
2021-11-20 7:34 ` Eli Zaretskii
2021-11-20 7:43 ` Feng Shu
2021-11-14 11:29 ` Eli Zaretskii
2021-11-14 17:55 ` Lars Ingebrigtsen
2021-11-14 18:14 ` Eli Zaretskii
2021-11-14 22:42 ` Feng Shu
2021-11-15 12:39 ` Eli Zaretskii
2021-11-15 5:39 ` Lars Ingebrigtsen
2021-11-15 13:02 ` Eli Zaretskii
2021-11-16 7:34 ` Lars Ingebrigtsen
2021-11-16 15:10 ` Eli Zaretskii
2021-11-16 15:20 ` Lars Ingebrigtsen
2021-11-16 16:45 ` Eli Zaretskii
2021-11-18 18:26 ` Eli Zaretskii
2021-11-19 0:26 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-19 7:01 ` Eli Zaretskii
2021-11-19 1:57 ` Feng Shu
2021-11-19 7:08 ` Eli Zaretskii
2021-11-19 7:18 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-19 7:31 ` bug#51821: " tumashu
2021-11-19 8:28 ` Eli Zaretskii
2021-11-19 8:45 ` tumashu
2021-11-19 8:06 ` Eli Zaretskii
2021-11-19 9:33 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-19 12:27 ` Eli Zaretskii
2021-11-19 12:36 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-19 7:26 ` tumashu
2021-11-19 8:25 ` Eli Zaretskii
2021-11-19 8:54 ` tumashu
2021-11-19 9:09 ` tumashu
2021-11-19 12:18 ` Eli Zaretskii
2021-11-19 7:12 ` Lars Ingebrigtsen
2021-11-19 8:04 ` Eli Zaretskii
2021-11-20 8:26 ` Lars Ingebrigtsen
2021-11-20 8:39 ` Eli Zaretskii
2021-11-20 8:51 ` Lars Ingebrigtsen
2021-11-20 9:06 ` Eli Zaretskii
2021-11-20 9:27 ` Lars Ingebrigtsen
2021-11-20 9:53 ` Eli Zaretskii
2021-11-20 9:58 ` Lars Ingebrigtsen
2021-11-20 10:15 ` Eli Zaretskii
2021-11-21 8:06 ` Lars Ingebrigtsen
2021-11-21 8:18 ` Eli Zaretskii
2021-11-21 8:21 ` Lars Ingebrigtsen
2021-11-21 8:32 ` Eli Zaretskii
2021-11-21 8:38 ` Lars Ingebrigtsen
2021-11-21 10:00 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-21 14:05 ` Eli Zaretskii
2021-11-19 14:48 ` Feng Shu
2021-11-14 22:37 ` Feng Shu [this message]
2021-11-15 12:38 ` Eli Zaretskii
2021-11-16 3:51 ` Feng Shu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1biqs7w.fsf@163.com \
--to=tumashu@163.com \
--cc=51821@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).