From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: tumashu@163.com, 51821@debbugs.gnu.org
Subject: bug#51821: 29.0.50; Suggest add variable or frame parameter: line-height
Date: Mon, 15 Nov 2021 15:02:53 +0200 [thread overview]
Message-ID: <83y25pshaa.fsf@gnu.org> (raw)
In-Reply-To: <875ysu2d18.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 15 Nov 2021 06:39:15 +0100)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: tumashu@163.com, 51821@debbugs.gnu.org
> Date: Mon, 15 Nov 2021 06:39:15 +0100
>
> It has to work across different fonts -- I think that's the real use
> case here, that if you're missing different fonts (which you commonly
> are when writing with different scripts), then the Emacs display gets
> pretty messy (uneven line heights all over the place).
You mean, because of "tofu"? But tofu doesn't change the line height,
AFAIK. So I think I'm missing something.
> * After redisplay has composed a line, it should check whether the line
> height is less than `line-height', and if so, add empty space at the
> bottom (or the top, or perhaps both, to center it).
>
> ** But -- if the line is composed purely of text with a face with an
> explicit :height property, it should do nothing.
The last part ruins it all. I guess you are thinking about faces in
their 'defface' form? But when a face gets to be used by the display
code, it is converted to the internal form and always completely
specified, and thus always has an explicit :height property already
calculated. And of course the default face must always be completely
specified at this point.
next prev parent reply other threads:[~2021-11-15 13:02 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-13 23:28 bug#51821: 29.0.50; Suggest add variable or frame parameter: line-height Feng Shu
2021-11-14 1:23 ` Lars Ingebrigtsen
2021-11-14 1:46 ` Feng Shu
2021-11-14 6:59 ` Eli Zaretskii
2021-11-14 7:01 ` Lars Ingebrigtsen
2021-11-14 7:04 ` Feng Shu
2021-11-14 8:03 ` Eli Zaretskii
2021-11-14 7:23 ` Eli Zaretskii
2021-11-15 5:33 ` Lars Ingebrigtsen
2021-11-19 23:03 ` Feng Shu
2021-11-20 7:00 ` Eli Zaretskii
2021-11-20 7:13 ` Feng Shu
2021-11-20 7:34 ` Eli Zaretskii
2021-11-20 7:43 ` Feng Shu
2021-11-14 11:29 ` Eli Zaretskii
2021-11-14 17:55 ` Lars Ingebrigtsen
2021-11-14 18:14 ` Eli Zaretskii
2021-11-14 22:42 ` Feng Shu
2021-11-15 12:39 ` Eli Zaretskii
2021-11-15 5:39 ` Lars Ingebrigtsen
2021-11-15 13:02 ` Eli Zaretskii [this message]
2021-11-16 7:34 ` Lars Ingebrigtsen
2021-11-16 15:10 ` Eli Zaretskii
2021-11-16 15:20 ` Lars Ingebrigtsen
2021-11-16 16:45 ` Eli Zaretskii
2021-11-18 18:26 ` Eli Zaretskii
2021-11-19 0:26 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-19 7:01 ` Eli Zaretskii
2021-11-19 1:57 ` Feng Shu
2021-11-19 7:08 ` Eli Zaretskii
2021-11-19 7:18 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-19 7:31 ` bug#51821: " tumashu
2021-11-19 8:28 ` Eli Zaretskii
2021-11-19 8:45 ` tumashu
2021-11-19 8:06 ` Eli Zaretskii
2021-11-19 9:33 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-19 12:27 ` Eli Zaretskii
2021-11-19 12:36 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-19 7:26 ` tumashu
2021-11-19 8:25 ` Eli Zaretskii
2021-11-19 8:54 ` tumashu
2021-11-19 9:09 ` tumashu
2021-11-19 12:18 ` Eli Zaretskii
2021-11-19 7:12 ` Lars Ingebrigtsen
2021-11-19 8:04 ` Eli Zaretskii
2021-11-20 8:26 ` Lars Ingebrigtsen
2021-11-20 8:39 ` Eli Zaretskii
2021-11-20 8:51 ` Lars Ingebrigtsen
2021-11-20 9:06 ` Eli Zaretskii
2021-11-20 9:27 ` Lars Ingebrigtsen
2021-11-20 9:53 ` Eli Zaretskii
2021-11-20 9:58 ` Lars Ingebrigtsen
2021-11-20 10:15 ` Eli Zaretskii
2021-11-21 8:06 ` Lars Ingebrigtsen
2021-11-21 8:18 ` Eli Zaretskii
2021-11-21 8:21 ` Lars Ingebrigtsen
2021-11-21 8:32 ` Eli Zaretskii
2021-11-21 8:38 ` Lars Ingebrigtsen
2021-11-21 10:00 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-11-21 14:05 ` Eli Zaretskii
2021-11-19 14:48 ` Feng Shu
2021-11-14 22:37 ` Feng Shu
2021-11-15 12:38 ` Eli Zaretskii
2021-11-16 3:51 ` Feng Shu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y25pshaa.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=51821@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=tumashu@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).