From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#51821: 29.0.50; Suggest add variable or frame parameter: line-height Date: Sat, 20 Nov 2021 09:26:19 +0100 Message-ID: <878rxjteqc.fsf@gnus.org> References: <87bl2nhbyp.fsf@163.com> <83bl2nugao.fsf@gnu.org> <878rxq62qt.fsf@gnus.org> <83k0hatxjl.fsf@gnu.org> <875ysu2d18.fsf@gnus.org> <83y25pshaa.fsf@gnu.org> <874k8c8sg0.fsf@gnus.org> <83ilws16hj.fsf@gnu.org> <87wnl8qg8b.fsf@gnus.org> <83czn0123n.fsf@gnu.org> <83v90pwcab.fsf@gnu.org> <87mtm0wrdt.fsf@gnus.org> <838rxkwoz8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36764"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: luangruo@yahoo.com, tumashu@163.com, 51821@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 20 09:27:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1moLiN-0009Od-PI for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 20 Nov 2021 09:27:15 +0100 Original-Received: from localhost ([::1]:36196 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1moLiM-00066V-9y for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 20 Nov 2021 03:27:14 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:59472) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1moLiA-00065T-VL for bug-gnu-emacs@gnu.org; Sat, 20 Nov 2021 03:27:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58275) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1moLiA-0004CF-N2 for bug-gnu-emacs@gnu.org; Sat, 20 Nov 2021 03:27:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1moLiA-0006Rt-CU for bug-gnu-emacs@gnu.org; Sat, 20 Nov 2021 03:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 Nov 2021 08:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51821 X-GNU-PR-Package: emacs Original-Received: via spool by 51821-submit@debbugs.gnu.org id=B51821.163739679424727 (code B ref 51821); Sat, 20 Nov 2021 08:27:02 +0000 Original-Received: (at 51821) by debbugs.gnu.org; 20 Nov 2021 08:26:34 +0000 Original-Received: from localhost ([127.0.0.1]:41585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moLhi-0006Qk-FA for submit@debbugs.gnu.org; Sat, 20 Nov 2021 03:26:34 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:40846) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1moLhe-0006QO-AG for 51821@debbugs.gnu.org; Sat, 20 Nov 2021 03:26:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=p73iDr1e4Ps5VH2jtJq5XyhI0wDQwCMBxVT/eeiEoBo=; b=FFwJMgYqeyOOYgoY7LePVhDbEV XGNAZqmDmnOIcSmlb+esR/1Sf/IhQoYnIBHfDFm4vGWt9ikqTzTO69Uukg4459jv3x+yIcCTtTife 5+lv4tXjKw8jJ/AEPr7pW/9WdZYd3hQHatHSJHFiMU1hLPXo2yY8RCBewYHdhSy5F3hs=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1moLhU-0001Ny-3e; Sat, 20 Nov 2021 09:26:22 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEUkJCsTFBQ1QV1E XJT///8eAeP6AAAAAWJLR0QEj2jZUQAAAAd0SU1FB+ULFAgQFQv6dkoAAAGoSURBVDjLjZThke0g CIVBGxBsQKEBxP57e5iY++Kd3ZnNTP7k4xwQMID08wN/BeUDiCSjqZfZPIKmczfyC2gNkJslQ+KR eLyB8HTxTmXQW0EmyQb3sJ7fAHzwiBy1f4FiQ6aF5JVcbjCXk1H+AmwrnBRrGgeonQCgFGP5D3KA vL4DYH6DpZACWELC9gUsyQKI8wTaRaKDy0uOqhQu0ACqn4AjC3IAPgGlUGAKgOcBSUQQr4IfUHCd YwGCQ1H7pVixIEvyAHarMlZ0FMWBeDg4NCDtZSIVASqYpIVius4OeynCPuQgDT5bItx1Xq2NV0LI xjEbQA/TdPc2EgXIyu43MPqAhOSVh27FC3SyGGL+KDYJUFb5GQHnHHOuWVwS6GU8IA+XJ/t6Rky3 4raqfVtFJ17AY5l3ONYTVN9JUOUC/QG6QTE/QaZyO8EBUs5wza9oOXJgjsiomPQLJK1ttrioVk/A U5t5NFs0Lso++ZVctc0uVDwXezXxBiiUwmpsQFdLnG0pcH2MeXS9gScPhxGbZaxdlc33zL0V6xZr 3Uoc9p45/faT+Q38A+qPZ25rcqMwAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIxLTExLTIwVDA4OjE2 OjIxKzAwOjAwD8xZyAAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMS0xMS0yMFQwODoxNjoyMSswMDow MH6R4XQAAAAASUVORK5CYII= X-Now-Playing: Judee Sill's _Heart Food_: "There's a Rugged Road" In-Reply-To: <838rxkwoz8.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 19 Nov 2021 10:04:27 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220459 Archived-At: Eli Zaretskii writes: > No, it should fix both. Did you try that? If you did and it didn't > work, can you show a recipe from "emacs -Q" so I could investigate? No, I only tested in buffers with a monospaced font and then read the doc string. > The "default font" part above is an over-simplification: it is hard to > say something accurate enough in a single short sentence. I did try > to explain it more in the rest of the doc string: this actually > affects any font which some face uses for ASCII characters. Perhaps "default font(s)" would help. >> Testing the patch, it also affects the height of faces with :height in >> them, meaning that separator lines get much taller than they should be. > > As I told you, it is currently impossible to single out such faces. Right, but I think I said that it should be pretty easy to carry that information in struct face if we want to go that way. > Also, I don't think we should necessarily exempt _any_ face that > specifies :height, because if that face is used to display with mixed > fonts, it will again have the same problem when both CJK fonts and > non-CJK fonts are mixed. Hm... Yeah, that's true. For instance, in eww in

we have :height 1.3, and we probably want the CJK/non-CJK font mixture to be handled the same way as if there isn't a :height there. OK, the :height thing doesn't work. > The separator lines are thus a very special > case, and if we want to solve that, we need a more focused solution. > For example, we could not stretch the height if the face's height is > below some threshold, on the assumption that such small fonts will > never used to display human-readable text. Hm, yes, the separator lines are very special, and the :height thing is more a hack than anything else. Perhaps we should just introduce a new spec, like :pixel-height that allows us to specify specifically how big the separator line should be. Hm. Or not use faces at all for the separator lines? I don't know how that would look, though. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no