From: Augusto Stoffel <arstoffel@gmail.com>
To: arstoffel@gmail.com
Cc: joaotavora@gmail.com, 58141@debbugs.gnu.org
Subject: bug#58141: [Eglot] Default eglot-diagnostic-tag-unnecessary-face is problematic'
Date: Sat, 18 Feb 2023 16:00:45 +0100 [thread overview]
Message-ID: <874jrjf276.fsf@gmail.com> (raw)
In-Reply-To: <87pmffd8ya.fsf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 182 bytes --]
This was a while back, but in any case this is my suggestion for this
face. I haven't seen eglot-diagnostic-tag-deprecated-face appear in
nature so I'm not sure how well it works.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Improve-eglot-diagnostic-tag-unnecessary-face.patch --]
[-- Type: text/x-patch, Size: 987 bytes --]
From 0772f1b46af4e1745d417db0a62b6de64575face Mon Sep 17 00:00:00 2001
From: Augusto Stoffel <arstoffel@gmail.com>
Date: Sat, 18 Feb 2023 15:58:23 +0100
Subject: [PATCH] Improve eglot-diagnostic-tag-unnecessary-face
* progmodes/elgot.el (eglot-diagnostic-tag-unnecessary-face): Use wavy
underline, as in all other Flymake faces.
---
lisp/progmodes/eglot.el | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index 6d192d9b333..8075412411e 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -324,7 +324,10 @@ eglot-mode-line
"Face for package-name in Eglot's mode line.")
(defface eglot-diagnostic-tag-unnecessary-face
- '((t (:inherit shadow)))
+ '((((supports :underline (:style wave)))
+ :underline (:style wave :color "gray"))
+ (t
+ :inherit flymake-note))
"Face used to render unused or unnecessary code.")
(defface eglot-diagnostic-tag-deprecated-face
--
2.39.2
next prev parent reply other threads:[~2023-02-18 15:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 11:39 bug#58141: [Eglot] Default eglot-diagnostic-tag-unnecessary-face is problematic Augusto Stoffel
2022-10-08 11:15 ` Augusto Stoffel
2023-02-18 15:00 ` Augusto Stoffel [this message]
2023-02-23 11:59 ` bug#58141: [Eglot] Default eglot-diagnostic-tag-unnecessary-face is problematic' João Távora
2023-02-23 18:55 ` Augusto Stoffel
2023-02-23 19:10 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jrjf276.fsf@gmail.com \
--to=arstoffel@gmail.com \
--cc=58141@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).