From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#58141: [Eglot] Default eglot-diagnostic-tag-unnecessary-face is problematic' Date: Sat, 18 Feb 2023 16:00:45 +0100 Message-ID: <874jrjf276.fsf@gmail.com> References: <87pmffd8ya.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13377"; mail-complaints-to="usenet@ciao.gmane.io" Cc: joaotavora@gmail.com, 58141@debbugs.gnu.org To: arstoffel@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 18 16:01:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pTOiL-0003Hu-2P for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Feb 2023 16:01:25 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pTOi4-0001wz-Iy; Sat, 18 Feb 2023 10:01:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTOi0-0001qq-Ow for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2023 10:01:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pTOhy-0000xI-Kj for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2023 10:01:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pTOhy-0000uC-1v for bug-gnu-emacs@gnu.org; Sat, 18 Feb 2023 10:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Feb 2023 15:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58141 X-GNU-PR-Package: emacs Original-Received: via spool by 58141-submit@debbugs.gnu.org id=B58141.16767324573463 (code B ref 58141); Sat, 18 Feb 2023 15:01:02 +0000 Original-Received: (at 58141) by debbugs.gnu.org; 18 Feb 2023 15:00:57 +0000 Original-Received: from localhost ([127.0.0.1]:44722 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTOht-0000tn-41 for submit@debbugs.gnu.org; Sat, 18 Feb 2023 10:00:57 -0500 Original-Received: from mail-ed1-f47.google.com ([209.85.208.47]:41936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTOhr-0000tY-4I for 58141@debbugs.gnu.org; Sat, 18 Feb 2023 10:00:56 -0500 Original-Received: by mail-ed1-f47.google.com with SMTP id i28so2806597eda.8 for <58141@debbugs.gnu.org>; Sat, 18 Feb 2023 07:00:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to; bh=qQy5n89Bs8tUrVuxGknrLAuSZgDVIVVyIH4Lotch/hA=; b=kL5PgDW5rRYbyTY9NQ7v3YrI+WdHzA//FSechHNwJdqgJm5q7k8S2O1uAXgQ02btO/ X1w5FvsxLVnPndQ8iCkTPUWMdKwcBz0W1aZdgdfkhkbXmZO+ai4/RHx9wtVyzBh1mSb2 tz7Y0hOwF3DX5c8zCGU2Pk+a9lErsjJ54Tqkh2aw8YlHtKYoWUexKcR1hg87BbUhOiRf gDTtSPg0lSrH1fpy5CtRJ0IcG9HURsq4lcLPumWfokukp7GswO9oX8Zbw+ez3IqhhkcB laCJMG4KJ1oAi9dcvi9oOk05HhTu50hZr7g+qNM5UMeJP0HSIwutwyIf2A1IswhrG3FK zuGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qQy5n89Bs8tUrVuxGknrLAuSZgDVIVVyIH4Lotch/hA=; b=I0ls3TBeuXYvJo3vzX+pklZ2ijiHa+JUDNkY40kC8AHKVOAgyvX9nbaM9yhrot5TnE l415Fqs5JDNfdZGGxNjaI3hWxp/gYpxV6GWmIEJC6Sp7/rrSBxkGSdADMMY0wrHOBKgO zAeZbUslaIeZUpbVSNbF+LzKDEqU45dM5LKxTMGgsgUAXkTZJ7ngSG1hI5y7QSmMYl2K RoxBehi1ewzeMCNMutdKvS/KObS4TjA/QJKHVJtXLUoJvOJXdgQtjm6811NkRCN9lFa/ 2/7YUunuN0TDwkX/7IEHbntyufetoeFTepjpGjKfo/MOZagiIzzY/j2XZlvUIQ++AgIA 8gpA== X-Gm-Message-State: AO0yUKWFc9FXrXrU6ov+lopHqEO7K65L8EGflST0t5FS48ZPF4npiQ3c wOQPZJJdzRAmbOSGW7DAKDE= X-Google-Smtp-Source: AK7set9m9a4U8BEmPWQBbyOrBZihlijeAIGkb4MDOOe+TKs0bt8cfFmn5OSdGA+rZbNf7BTxLLJCdw== X-Received: by 2002:a17:906:ef8c:b0:8b1:806b:7dbb with SMTP id ze12-20020a170906ef8c00b008b1806b7dbbmr5875265ejb.51.1676732448950; Sat, 18 Feb 2023 07:00:48 -0800 (PST) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::6fd0]) by smtp.gmail.com with ESMTPSA id z7-20020a1709060ac700b008b17fe9ac6csm2434082ejf.178.2023.02.18.07.00.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Feb 2023 07:00:47 -0800 (PST) In-Reply-To: <87pmffd8ya.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255967 Archived-At: --=-=-= Content-Type: text/plain This was a while back, but in any case this is my suggestion for this face. I haven't seen eglot-diagnostic-tag-deprecated-face appear in nature so I'm not sure how well it works. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Improve-eglot-diagnostic-tag-unnecessary-face.patch >From 0772f1b46af4e1745d417db0a62b6de64575face Mon Sep 17 00:00:00 2001 From: Augusto Stoffel Date: Sat, 18 Feb 2023 15:58:23 +0100 Subject: [PATCH] Improve eglot-diagnostic-tag-unnecessary-face * progmodes/elgot.el (eglot-diagnostic-tag-unnecessary-face): Use wavy underline, as in all other Flymake faces. --- lisp/progmodes/eglot.el | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index 6d192d9b333..8075412411e 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -324,7 +324,10 @@ eglot-mode-line "Face for package-name in Eglot's mode line.") (defface eglot-diagnostic-tag-unnecessary-face - '((t (:inherit shadow))) + '((((supports :underline (:style wave))) + :underline (:style wave :color "gray")) + (t + :inherit flymake-note)) "Face used to render unused or unnecessary code.") (defface eglot-diagnostic-tag-deprecated-face -- 2.39.2 --=-=-=--