From: "João Távora" <joaotavora@gmail.com>
To: Augusto Stoffel <arstoffel@gmail.com>
Cc: 58141@debbugs.gnu.org
Subject: bug#58141: [Eglot] Default eglot-diagnostic-tag-unnecessary-face is problematic'
Date: Thu, 23 Feb 2023 11:59:29 +0000 [thread overview]
Message-ID: <CALDnm53KMgyXoKYsGtvVDCGeZ5XFONNaaEkyr0bk5osCu=Pc0w@mail.gmail.com> (raw)
In-Reply-To: <874jrjf276.fsf@gmail.com>
On Sat, Feb 18, 2023 at 3:00 PM Augusto Stoffel <arstoffel@gmail.com> wrote:
>
> This was a while back, but in any case this is my suggestion for this
> face. I haven't seen eglot-diagnostic-tag-deprecated-face appear in
> nature so I'm not sure how well it works.
I'm not a fan of hardcoding colors in Eglot, since that needs themes
to update for the new face. Supporting the optional underline is
probably fine, though.
João
next prev parent reply other threads:[~2023-02-23 11:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 11:39 bug#58141: [Eglot] Default eglot-diagnostic-tag-unnecessary-face is problematic Augusto Stoffel
2022-10-08 11:15 ` Augusto Stoffel
2023-02-18 15:00 ` bug#58141: [Eglot] Default eglot-diagnostic-tag-unnecessary-face is problematic' Augusto Stoffel
2023-02-23 11:59 ` João Távora [this message]
2023-02-23 18:55 ` Augusto Stoffel
2023-02-23 19:10 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALDnm53KMgyXoKYsGtvVDCGeZ5XFONNaaEkyr0bk5osCu=Pc0w@mail.gmail.com' \
--to=joaotavora@gmail.com \
--cc=58141@debbugs.gnu.org \
--cc=arstoffel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).