From: Augusto Stoffel <arstoffel@gmail.com>
To: 58141@debbugs.gnu.org
Cc: "João Távora" <joaotavora@gmail.com>
Subject: bug#58141: [Eglot] Default eglot-diagnostic-tag-unnecessary-face is problematic
Date: Wed, 28 Sep 2022 13:39:25 +0200 [thread overview]
Message-ID: <87pmffd8ya.fsf@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 72 bytes --]
Or at least I really dislike the default value, which looks like this:
[-- Attachment #2: Screenshot from 2022-09-28 13-16-40.png --]
[-- Type: image/png, Size: 6092 bytes --]
[-- Attachment #3: Type: text/plain, Size: 599 bytes --]
When I first saw this face appearing, I had no idea what was going on.
That this is a Flymake warning is unexpected, since there's nothing
squiggly about it. Moreover, it overrides all other font-locking, which
presumably still has meaningful information. Finally, I think it's hard
to be sure the result is readable in all custom themes, even all
reasonable ones.
In general, I would argue that “creative” decorations should be left off
by default. So concretely in this case my suggestion would be to let
eglot-diagnostic-*-face inherit from one of the good old Flymake faces.
next reply other threads:[~2022-09-28 11:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 11:39 Augusto Stoffel [this message]
2022-10-08 11:15 ` bug#58141: [Eglot] Default eglot-diagnostic-tag-unnecessary-face is problematic Augusto Stoffel
2023-02-18 15:00 ` bug#58141: [Eglot] Default eglot-diagnostic-tag-unnecessary-face is problematic' Augusto Stoffel
2023-02-23 11:59 ` João Távora
2023-02-23 18:55 ` Augusto Stoffel
2023-02-23 19:10 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmffd8ya.fsf@gmail.com \
--to=arstoffel@gmail.com \
--cc=58141@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).