From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop Date: Thu, 29 Feb 2024 09:03:33 +0200 Message-ID: <86plwfsqey.fsf@gnu.org> References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> <86sf1k1fss.fsf@gnu.org> <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> <87r0h2x816.fsf@outlook.com> <8634tiymd4.fsf@gnu.org> <87cyslxziy.fsf@gmx.net> <86frxhxezx.fsf@gnu.org> <3f0da1b2-e256-6124-4d6a-47c922ccd64f@gmail.com> <86bk84wci4.fsf@gnu.org> <7b67c305-1e41-9db2-55d3-f74f1ac302a6@gmail.com> <10a0d839-24f6-b521-1504-a5ca568b3dcc@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12439"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69232@debbugs.gnu.org, jimjoe@gmx.net To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 29 08:28:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rfaq0-00031L-Lh for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Feb 2024 08:28:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rfapf-0002V8-Vq; Thu, 29 Feb 2024 02:28:01 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rfapM-0002Pv-0S for bug-gnu-emacs@gnu.org; Thu, 29 Feb 2024 02:27:37 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rfapL-0001pL-Or for bug-gnu-emacs@gnu.org; Thu, 29 Feb 2024 02:27:35 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rfapm-00056M-IM for bug-gnu-emacs@gnu.org; Thu, 29 Feb 2024 02:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Feb 2024 07:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69232 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69232-submit@debbugs.gnu.org id=B69232.170919166119552 (code B ref 69232); Thu, 29 Feb 2024 07:28:02 +0000 Original-Received: (at 69232) by debbugs.gnu.org; 29 Feb 2024 07:27:41 +0000 Original-Received: from localhost ([127.0.0.1]:59114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfapR-00055I-8f for submit@debbugs.gnu.org; Thu, 29 Feb 2024 02:27:41 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfapP-00054v-SR for 69232@debbugs.gnu.org; Thu, 29 Feb 2024 02:27:40 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rfaSB-0003Ko-D6; Thu, 29 Feb 2024 02:03:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dWWLdi/4Gdnd25MJvmbdJhSFRYJKDdUMAF/BkhukO6A=; b=YajQ8DZjFFzT jB95fYC7tvZHHeec9VqQe9uVoZkZ/C6afjEUtqIsV4F2J77Hkw8eXVMAmv8WsajSEGurtuSyd87rT m5PkRt4Fg4h7UhjKRb0sxvj0hObqF/Ki5Hh1FupR+Hvdq8gbtAn7HG0m3fDNbJFL/E2YiCAbPd9C1 kem6vA2cfWsCS8s2MVtMdB0pwk85NRuWB4gOW4CVPTNcDovHto1I1++5JaGYSW6F5NfdhlA6qXxvw VK0FcaHxpyJ1/fE01GEYliVamyYDmI5FHeXrb/uMKnHta0oedkgQxhwWx97WtD9mzF3xX4hG/yCiQ sh7ZlIe0+f9RvNF2BMKhcw==; In-Reply-To: <10a0d839-24f6-b521-1504-a5ca568b3dcc@gmail.com> (message from Jim Porter on Wed, 28 Feb 2024 15:39:16 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280782 Archived-At: > Date: Wed, 28 Feb 2024 15:39:16 -0800 > From: Jim Porter > Cc: 69232@debbugs.gnu.org, jimjoe@gmx.net > > On 2/25/2024 2:41 PM, Jim Porter wrote: > > On 2/25/2024 11:49 AM, Eli Zaretskii wrote: > >>> If anything, I think this should be the default, with some other options > >>> provided for people who don't want to lose any history. That way the > >>> default behavior is what people know. > >> > >> I don't think I mind. > > > > Thanks. Even if there were multiple options, this is probably what I'd > > choose, if only out of habit. > > Here's a patch that deletes "future history" in the case we'd previously > discussed. I also added some regression tests for this. I think this all > works correctly, but it's probably worth some manual testing over a few > days just to be on the safe side. Thanks, but I thought we were talking about some user option, since at least some people said they don't like what other browsers do? > +(defun eww-save-history (&optional clear-future) > + "Save the current page's data to the history. > +If the current page is a historial one loaded from > +`eww-history' (e.g. by calling `eww-back-url'), this will update the > +page's entry in `eww-history' and return nil. Otherwise, add a new > +entry to `eww-history' and return t. > + > +If CLEAR-FUTURE is non-nil, clear any future history elements from > +`eww-history'." This should probably explain what it means by "future history elements". Thanks.