From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop Date: Sat, 02 Mar 2024 09:38:03 +0200 Message-ID: <86plwdozhg.fsf@gnu.org> References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> <86sf1k1fss.fsf@gnu.org> <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> <87r0h2x816.fsf@outlook.com> <8634tiymd4.fsf@gnu.org> <87cyslxziy.fsf@gmx.net> <86frxhxezx.fsf@gnu.org> <3f0da1b2-e256-6124-4d6a-47c922ccd64f@gmail.com> <86bk84wci4.fsf@gnu.org> <7b67c305-1e41-9db2-55d3-f74f1ac302a6@gmail.com> <10a0d839-24f6-b521-1504-a5ca568b3dcc@gmail.com> <86plwfsqey.fsf@gnu.org> <77426857-4d81-29da-9b1a-70931393215e@gmail.com> <878r32u9ut.fsf@gmx.net> <99e36690-ffbe-f373-50d2-32c92717a560@gmail.com> <86wmqmquoe.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9228"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69232@debbugs.gnu.org, jimjoe@gmx.net To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 02 08:39:00 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rgJxU-0002A0-3Z for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Mar 2024 08:39:00 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rgJx8-0005Qt-CN; Sat, 02 Mar 2024 02:38:38 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rgJx4-0005Pe-5g for bug-gnu-emacs@gnu.org; Sat, 02 Mar 2024 02:38:34 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rgJx3-0003LJ-Th for bug-gnu-emacs@gnu.org; Sat, 02 Mar 2024 02:38:33 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rgJxV-0001aR-Nb for bug-gnu-emacs@gnu.org; Sat, 02 Mar 2024 02:39:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Mar 2024 07:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69232 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69232-submit@debbugs.gnu.org id=B69232.17093651226073 (code B ref 69232); Sat, 02 Mar 2024 07:39:01 +0000 Original-Received: (at 69232) by debbugs.gnu.org; 2 Mar 2024 07:38:42 +0000 Original-Received: from localhost ([127.0.0.1]:37895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rgJxC-0001Zt-8G for submit@debbugs.gnu.org; Sat, 02 Mar 2024 02:38:42 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51288) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rgJx9-0001Zg-U4 for 69232@debbugs.gnu.org; Sat, 02 Mar 2024 02:38:40 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rgJwc-00034u-Cp; Sat, 02 Mar 2024 02:38:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=sEEfn6kgLlEurM/gzLteigsF6Knsvc8Mbd2C18dzEyw=; b=QwMM/+Guh0u5 SNJQy2/MW74kPIDqrcJw+Sj7lX07Nr4l2Ihw8JBQwa8aae193WZPKlsWXY3W0DBsn4DxlB/PL3htJ lV0QzmXPJA+83v6ABPAVXRAr/SskwHkc4EZUokcCK80U4CKHgEo5Iu7Q3/DXFqq/OojRggkCwANum QwVeCxlkYevV86+jEROJ9aKy0dYqAxv5tkXvCpM1HFtdTf1pbqNdwxoK7MKtEwW8kEV+CDvj5ulRS NazknEwl50owKiGoh7OLtR+sAKn+VUqe3BIn6FS60m9o1BtUuPZO2GXh+lTCulu6bpNQme8ssQ5eD eJ94/tYE+auozgiTx+KeVA==; In-Reply-To: (message from Jim Porter on Fri, 1 Mar 2024 12:13:08 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280890 Archived-At: > Date: Fri, 1 Mar 2024 12:13:08 -0800 > Cc: 69232@debbugs.gnu.org, jimjoe@gmx.net > From: Jim Porter > > > Therefore, I suggest a history-specific defcustom, whose possible > > values could be 'clear', 'clone', and 'add', and whose effect will be > > to call the corresponding function via eww-before-browse-function. > > The defcustom could also have a user-defined function value to allow > > additional functions, of course. > > I've done something close to this, though I retained the previous form > where the possible values are things like 'eww-delete-future-history'. > That keeps the code to *use* this option simpler (no special-case symbol > names), and the only difference with your suggestion is that users who > manually edit their init.el will have a longer symbol name to type. > > For Customize users, I added 'function-item' choices so they should just > be able to click on the option they want without having to worry about > the exact symbol name. > > If you strongly prefer to have this accept non-function symbol names > like 'clear', let me know and I can change it. I don't care too much, > but this way seemed simpler and easier to maintain. I think what you did is functionally equivalent, and not harder to use in practice. So I'm okay with this version of the patch. Thanks.