From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop Date: Mon, 19 Feb 2024 14:12:07 +0200 Message-ID: <864je4r6ug.fsf@gnu.org> References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36370"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69232@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 19 13:13:02 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rc2W5-0009Di-AG for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Feb 2024 13:13:01 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rc2Vn-0000dB-5O; Mon, 19 Feb 2024 07:12:44 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rc2Vl-0000cg-En for bug-gnu-emacs@gnu.org; Mon, 19 Feb 2024 07:12:41 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rc2Vl-0000FY-5s for bug-gnu-emacs@gnu.org; Mon, 19 Feb 2024 07:12:41 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rc2W5-0006Ok-OW for bug-gnu-emacs@gnu.org; Mon, 19 Feb 2024 07:13:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Feb 2024 12:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69232 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69232-submit@debbugs.gnu.org id=B69232.170834476324568 (code B ref 69232); Mon, 19 Feb 2024 12:13:01 +0000 Original-Received: (at 69232) by debbugs.gnu.org; 19 Feb 2024 12:12:43 +0000 Original-Received: from localhost ([127.0.0.1]:40521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc2Vm-0006OC-PW for submit@debbugs.gnu.org; Mon, 19 Feb 2024 07:12:43 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc2Vk-0006Nu-9v for 69232@debbugs.gnu.org; Mon, 19 Feb 2024 07:12:41 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rc2VJ-0000CX-Nn; Mon, 19 Feb 2024 07:12:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=v83KbppGFyEt2tia3j62uV4rkdww/I9T0fGeEdrYrJ4=; b=Bl5fVY2e53bD tlaMMGS+AL6PhUB0eZJZikkU2uswvxI2TwvmvfONa+TlykYlZzXTtLiXe+cOi6Rwqw1S0+HHnW6V/ dHVucX9i/aWFtCYLkR1hcJvLYPpVUYedxWwg8luv9CbHSCUko8DgmF5d0z4LzMu3ixxz7eeqF66LS 7IVDJmU6mW5A8u8vr0XL+HDACH1Y7G+0c4TKTgTPYO1+xj78h7lzhx75BP4GO5le1AnsRmPXNSYVM Ydw6I0NRgPEEX+5wQxvILJ3Kmq2NnDDtF/L3Th/CGFhw6OfpfMP9CvgOd+G9gxyFGFuZJj6rp6yFg AVz4hIsVq+7LVZua1zqxvQ==; In-Reply-To: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> (message from Jim Porter on Sat, 17 Feb 2024 20:59:57 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280247 Archived-At: > Date: Sat, 17 Feb 2024 20:59:57 -0800 > From: Jim Porter > > If you navigate back in EWW history, and then forward, you can never hit > the "end": it keeps adding duplicate history elements, even though > you're not visiting any new pages. To see this in action, start from > `emacs -Q`, then: > > M-x eww RET fsf.org RET > M-x eww RET gnu.org RET > H ;; Notice that there's one item in the history: the FSF page[1] > q ;; Close history window > l ;; Go back one in the history to the FSF page > H ;; Notice that there are two items in the history > r ;; Go forward one, back at the GNU page > r ;; Go forward again, now at the FSF page(?!) > r ;; Ditto, now at the GNU page > r ;; Repeat ad infinitum > H ;; Now there are many entries, alternating between GNU and FSF > > Attached is a patch that fixes this. Now, 'eww-save-history' will update > the history entry in-place when viewing a historical page, and > 'eww-back-url' / 'eww-forward-url' take that into account. I also fixed > the predicates for when the back/forward menu items were enabled. > > I think this is just a straightforward bug fix, so I didn't add a NEWS > entry. I could add one though if it seems worthwhile. I'm not sure this is a bug fix, and I think this behavior change does need a NEWS entry. And have sure you are that no one will want the current behavior?