From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37756: [PATCH] Wrong initialization of fringe bitmap Date: Wed, 16 Oct 2019 21:35:03 +0300 Message-ID: <83zhi0cze0.fsf@gnu.org> References: <838spmgx1t.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="140108"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37756@debbugs.gnu.org To: Carlos Pita Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 16 20:36:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKo9b-000aIO-Ht for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 20:36:11 +0200 Original-Received: from localhost ([::1]:46976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKo9a-000782-Es for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Oct 2019 14:36:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54849) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKo9U-00074t-C7 for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 14:36:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKo9T-0000qC-DQ for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 14:36:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37707) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKo9T-0000q0-5a for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 14:36:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKo9S-0007xV-Ip for bug-gnu-emacs@gnu.org; Wed, 16 Oct 2019 14:36:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Oct 2019 18:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37756 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37756-submit@debbugs.gnu.org id=B37756.157125093030547 (code B ref 37756); Wed, 16 Oct 2019 18:36:02 +0000 Original-Received: (at 37756) by debbugs.gnu.org; 16 Oct 2019 18:35:30 +0000 Original-Received: from localhost ([127.0.0.1]:46528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKo8v-0007wc-Vd for submit@debbugs.gnu.org; Wed, 16 Oct 2019 14:35:30 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKo8u-0007wR-SJ for 37756@debbugs.gnu.org; Wed, 16 Oct 2019 14:35:29 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48571) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iKo8p-0000TZ-CZ; Wed, 16 Oct 2019 14:35:23 -0400 Original-Received: from [176.228.60.248] (port=3308 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iKo8o-00046U-Mv; Wed, 16 Oct 2019 14:35:23 -0400 In-reply-to: (message from Carlos Pita on Wed, 16 Oct 2019 14:28:29 -0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169476 Archived-At: > From: Carlos Pita > Date: Wed, 16 Oct 2019 14:28:29 -0300 > Cc: 37756@debbugs.gnu.org > > Here is a patch that removes the superfluous line with a detailed > explanation in the commit message. Thanks, but please format the log message according to CONTRIBUTE: it should name the function in which the change is being made, start with a capital letter, and keep 2 spaces between sentences. Also, there's no need to describe in such detail what the code does, when the code speaks for itself. You could just say "Remove redundant zeroing of fb.bits".