unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: luangruo@yahoo.com, 50424@debbugs.gnu.org, alan@idiocy.org
Subject: bug#50424: 27.2; Tab bar button mouse face not clearing entirely
Date: Sun, 12 Sep 2021 06:50:30 +0300	[thread overview]
Message-ID: <83y282fo55.fsf@gnu.org> (raw)
In-Reply-To: <87ee9uzymn.fsf@mail.linkov.net> (message from Juri Linkov on Sat, 11 Sep 2021 22:43:44 +0300)

> From: Juri Linkov <juri@linkov.net>
> Date: Sat, 11 Sep 2021 22:43:44 +0300
> Cc: luangruo@yahoo.com, 50424@debbugs.gnu.org
> 
> > Thanks, I really appreciate your help.  After seeing the result
> > of your patch, one question that came up is whether it's possible
> > not to change the previously used dimensions?  With enlarged height
> > and width, now the buttons are not vertically aligned:
> 
> Sorry, actually this question was addressed to Eli
> for the commit with the same subject but different hash:
> db74a93659 that contains such changes:
> 
> - :margin (2 . 0)
> + :margin ,tab-bar-button-margin

This is to make the code do what the variable's documentation says.
Without that change, the images were sized using :margin '(2 . 0)',
but the C code used the value of tab-bar-button-margin, a simple
scalar, to place the image and clear its background.  The way to
affect the image dimensions is by changing the value of
tab-bar-button-margin, not by hard-coding the margin in the image
properties.





      reply	other threads:[~2021-09-12  3:50 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87eea2cebb.fsf.ref@yahoo.com>
2021-09-06  8:12 ` bug#50424: 27.2; Tab bar button mouse face not clearing entirely Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-06 10:50   ` Eli Zaretskii
2021-09-06 11:31     ` Stephen Berman
2021-09-06 11:46       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-06 12:00     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-06 12:30     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-06 17:39       ` Eli Zaretskii
2021-09-07  0:30         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-07 10:41           ` Eli Zaretskii
2021-09-07 13:02             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-07 13:12               ` Eli Zaretskii
2021-09-07 23:13             ` Alan Third
2021-09-08  6:05               ` Eli Zaretskii
2021-09-08 16:57                 ` Alan Third
2021-09-11 12:11                   ` Eli Zaretskii
2021-09-11 18:49                   ` Juri Linkov
2021-09-11 19:41                     ` Eli Zaretskii
2021-09-11 19:45                       ` Juri Linkov
2021-09-12  3:46                         ` Eli Zaretskii
2021-09-12  6:05                           ` Eli Zaretskii
2021-09-12  7:06                           ` Juri Linkov
2021-09-12  8:35                             ` Eli Zaretskii
2021-09-12 16:06                               ` Juri Linkov
2021-09-12 16:25                                 ` Eli Zaretskii
2021-09-13  7:59                                   ` Juri Linkov
2021-09-13 11:59                                     ` Eli Zaretskii
2021-09-11 19:43                     ` Juri Linkov
2021-09-12  3:50                       ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83y282fo55.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=50424@debbugs.gnu.org \
    --cc=alan@idiocy.org \
    --cc=juri@linkov.net \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).