From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50424: 27.2; Tab bar button mouse face not clearing entirely Date: Sun, 12 Sep 2021 06:50:30 +0300 Message-ID: <83y282fo55.fsf@gnu.org> References: <87eea2cebb.fsf.ref@yahoo.com> <87eea2cebb.fsf@yahoo.com> <83eea2rn8z.fsf@gnu.org> <87h7exc2dk.fsf@yahoo.com> <83lf49r4bc.fsf@gnu.org> <87czplb51o.fsf@yahoo.com> <83ilzcpt0d.fsf@gnu.org> <83mtonob41.fsf@gnu.org> <87tuiryn17.fsf@mail.linkov.net> <87ee9uzymn.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11388"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 50424@debbugs.gnu.org, alan@idiocy.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 12 05:52:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mPGXN-0002mL-G8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Sep 2021 05:52:13 +0200 Original-Received: from localhost ([::1]:53524 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPGXL-0003Qj-RF for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 11 Sep 2021 23:52:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42118) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPGXE-0003Nw-NL for bug-gnu-emacs@gnu.org; Sat, 11 Sep 2021 23:52:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58528) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mPGXB-0004Ti-Vh for bug-gnu-emacs@gnu.org; Sat, 11 Sep 2021 23:52:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mPGXB-0006lS-U2 for bug-gnu-emacs@gnu.org; Sat, 11 Sep 2021 23:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Sep 2021 03:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50424 X-GNU-PR-Package: emacs Original-Received: via spool by 50424-submit@debbugs.gnu.org id=B50424.163141866225928 (code B ref 50424); Sun, 12 Sep 2021 03:52:01 +0000 Original-Received: (at 50424) by debbugs.gnu.org; 12 Sep 2021 03:51:02 +0000 Original-Received: from localhost ([127.0.0.1]:41841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPGWD-0006k1-EN for submit@debbugs.gnu.org; Sat, 11 Sep 2021 23:51:01 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPGWB-0006jj-BF for 50424@debbugs.gnu.org; Sat, 11 Sep 2021 23:51:00 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49910) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPGW4-0003VY-3H; Sat, 11 Sep 2021 23:50:52 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4010 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPGVr-0007pF-Rd; Sat, 11 Sep 2021 23:50:52 -0400 In-Reply-To: <87ee9uzymn.fsf@mail.linkov.net> (message from Juri Linkov on Sat, 11 Sep 2021 22:43:44 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214108 Archived-At: > From: Juri Linkov > Date: Sat, 11 Sep 2021 22:43:44 +0300 > Cc: luangruo@yahoo.com, 50424@debbugs.gnu.org > > > Thanks, I really appreciate your help. After seeing the result > > of your patch, one question that came up is whether it's possible > > not to change the previously used dimensions? With enlarged height > > and width, now the buttons are not vertically aligned: > > Sorry, actually this question was addressed to Eli > for the commit with the same subject but different hash: > db74a93659 that contains such changes: > > - :margin (2 . 0) > + :margin ,tab-bar-button-margin This is to make the code do what the variable's documentation says. Without that change, the images were sized using :margin '(2 . 0)', but the C code used the value of tab-bar-button-margin, a simple scalar, to place the image and clear its background. The way to affect the image dimensions is by changing the value of tab-bar-button-margin, not by hard-coding the margin in the image properties.