From: Eli Zaretskii <eliz@gnu.org>
To: Alan Third <alan@idiocy.org>
Cc: luangruo@yahoo.com, 50424@debbugs.gnu.org, juri@linkov.net
Subject: bug#50424: 27.2; Tab bar button mouse face not clearing entirely
Date: Sat, 11 Sep 2021 15:11:32 +0300 [thread overview]
Message-ID: <83lf43gvm3.fsf@gnu.org> (raw)
In-Reply-To: <YTjrjq5jCS4DFZXh@idiocy.org> (message from Alan Third on Wed, 8 Sep 2021 17:57:50 +0100)
> Date: Wed, 8 Sep 2021 17:57:50 +0100
> From: Alan Third <alan@idiocy.org>
> Cc: luangruo@yahoo.com, juri@linkov.net, 50424@debbugs.gnu.org
>
> I think all it's doing is ensuring the total area the image takes up
> is the same whether there's a relief or not.
>
> The total width = image + relief width + margin width, so if you
> reduce the size of the relief you have to increase the size of the
> margin by the same amount to make sure it takes up the same amount of
> space and doesn't move.
>
> As far as I can see, what's happening here is that the margin is
> pushing the relief one pixel into the separator to the left, so I
> suspect that's why it's not being cleared.
>
> I'm somewhat surprised that it's not pushing the right hand side one
> pixel too far in the other direction and causing it to not be cleared
> either, but maybe that's just chance.
>
> The change below fixes it here, but I've not made sure it does the
> right thing with different sized margins and so on.
Thanks, I installed this, since it fixes at least the default case.
next prev parent reply other threads:[~2021-09-11 12:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87eea2cebb.fsf.ref@yahoo.com>
2021-09-06 8:12 ` bug#50424: 27.2; Tab bar button mouse face not clearing entirely Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-06 10:50 ` Eli Zaretskii
2021-09-06 11:31 ` Stephen Berman
2021-09-06 11:46 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-06 12:00 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-06 12:30 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-06 17:39 ` Eli Zaretskii
2021-09-07 0:30 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-07 10:41 ` Eli Zaretskii
2021-09-07 13:02 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-07 13:12 ` Eli Zaretskii
2021-09-07 23:13 ` Alan Third
2021-09-08 6:05 ` Eli Zaretskii
2021-09-08 16:57 ` Alan Third
2021-09-11 12:11 ` Eli Zaretskii [this message]
2021-09-11 18:49 ` Juri Linkov
2021-09-11 19:41 ` Eli Zaretskii
2021-09-11 19:45 ` Juri Linkov
2021-09-12 3:46 ` Eli Zaretskii
2021-09-12 6:05 ` Eli Zaretskii
2021-09-12 7:06 ` Juri Linkov
2021-09-12 8:35 ` Eli Zaretskii
2021-09-12 16:06 ` Juri Linkov
2021-09-12 16:25 ` Eli Zaretskii
2021-09-13 7:59 ` Juri Linkov
2021-09-13 11:59 ` Eli Zaretskii
2021-09-11 19:43 ` Juri Linkov
2021-09-12 3:50 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lf43gvm3.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=50424@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=juri@linkov.net \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).