From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: luangruo@yahoo.com, 50424@debbugs.gnu.org, alan@idiocy.org
Subject: bug#50424: 27.2; Tab bar button mouse face not clearing entirely
Date: Sun, 12 Sep 2021 11:35:33 +0300 [thread overview]
Message-ID: <83k0jmfay2.fsf@gnu.org> (raw)
In-Reply-To: <87zgsii8cy.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 12 Sep 2021 10:06:09 +0300)
> From: Juri Linkov <juri@linkov.net>
> Cc: alan@idiocy.org, luangruo@yahoo.com, 50424@debbugs.gnu.org
> Date: Sun, 12 Sep 2021 10:06:09 +0300
>
> > Then I don't understand the two horizontally-adjacent images. What
> > are they? two separate frame? If they are two frames, then where are
> > the frame decorations? In short, I don't understand what am I seeing
> > there, and how did you get this display.
>
> These are two separate images that show the changed tab dimensions
> before changes when :margin was (2 . 0), and after changes
> when now :margin is 4.
>
> > And also, when you say "buttons are not vertically aligned", what
> > exactly do you mean? Not aligned with what?
>
> Now buttons are not aligned to the baseline, and thus are
> not centered vertically anymore.
Isn't that evidence that something is wrong in how the labels and
buttons are displayed? The margin of 4 is symmetrical, so why aren't
the buttons centered? And why do we need to use zero vertical margin
to get them centered? This seems to mean we have some hidden problem
here.
> This patch restores the original tab dimensions, while also keeps fixed
> the reported problem of mouse face not clearing entirely:
>
> diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el
> index 8be08d4b8b..edbadec09d 100644
> --- a/lisp/tab-bar.el
> +++ b/lisp/tab-bar.el
> @@ -161,7 +161,7 @@ tab-bar--load-buttons
> (add-text-properties 0 (length tab-bar-new-button)
> `(display (image :type xpm
> :file "tabs/new.xpm"
> - :margin ,tab-bar-button-margin
> + :margin ,(cons tab-bar-button-margin 0)
> :ascent center))
> tab-bar-new-button))
Sorry, this cannot be right. tab-bar-button-margin is documented and
used as determining the button margins completely:
doc: /* Margin around tab-bar buttons in pixels.
If an integer, use that for both horizontal and vertical margins.
Otherwise, value should be a pair of integers `(HORZ . VERT)' with
HORZ specifying the horizontal margin, and VERT specifying the
vertical margin. */);
We cannot arbitrarily decide that the value matters only for the
horizontal margin, but not for the vertical one. When the user or a
Lisp program change the value of that variable, they should get the
effect they expect based on the documentation. Also, the code in
xterm.c/w32term.c clearly behaves according to the doc string of
tab-bar-button-margin, which is yet another reason not to do what you
propose. And what will happen with your code if tab-bar-button-margin
is set to a cons cell, as allowed by the documentation above?
If we want the default value of tab-bar-button-margin to be a cons
cell, let's change the default value to be a cons cell, it's not more
complicated than setting it to a scalar, even in C. But tab-bar.el
should use in its image specs the exact value of
tab-bar-button-margin, it cannot decide to change it behind the back
of the caller.
next prev parent reply other threads:[~2021-09-12 8:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87eea2cebb.fsf.ref@yahoo.com>
2021-09-06 8:12 ` bug#50424: 27.2; Tab bar button mouse face not clearing entirely Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-06 10:50 ` Eli Zaretskii
2021-09-06 11:31 ` Stephen Berman
2021-09-06 11:46 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-06 12:00 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-06 12:30 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-06 17:39 ` Eli Zaretskii
2021-09-07 0:30 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-07 10:41 ` Eli Zaretskii
2021-09-07 13:02 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-07 13:12 ` Eli Zaretskii
2021-09-07 23:13 ` Alan Third
2021-09-08 6:05 ` Eli Zaretskii
2021-09-08 16:57 ` Alan Third
2021-09-11 12:11 ` Eli Zaretskii
2021-09-11 18:49 ` Juri Linkov
2021-09-11 19:41 ` Eli Zaretskii
2021-09-11 19:45 ` Juri Linkov
2021-09-12 3:46 ` Eli Zaretskii
2021-09-12 6:05 ` Eli Zaretskii
2021-09-12 7:06 ` Juri Linkov
2021-09-12 8:35 ` Eli Zaretskii [this message]
2021-09-12 16:06 ` Juri Linkov
2021-09-12 16:25 ` Eli Zaretskii
2021-09-13 7:59 ` Juri Linkov
2021-09-13 11:59 ` Eli Zaretskii
2021-09-11 19:43 ` Juri Linkov
2021-09-12 3:50 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k0jmfay2.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=50424@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=juri@linkov.net \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).